GNU bug report logs - #14957
24.3.50; Flyspell language visible in mode line

Previous Next

Full log

View this message in rfc822 format

From: "Sebastien Vauban" <sva-news <at> mygooglest.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 14957 <at> debbugs.gnu.org
Subject: bug#14957: 24.3.50; Flyspell language visible in mode line
Date: Wed, 15 Jan 2014 11:13:42 +0100

Stefan Monnier wrote:
>>   (defconst csv-mode-line-help-echo (get-text-property 0 (quote help-echo)
>> (car default-mode-line-format)) "Primary default mode line help echo text.")
>
> This is clearly a bug in csv-mode.el.
> Try the patch below,

It does work like expected. Thanks!

> diff --git a/packages/csv-mode/csv-mode.el b/packages/csv-mode/csv-mode.el
> index dbc6182..a8ae4e4 100644
> --- a/packages/csv-mode/csv-mode.el
> +++ b/packages/csv-mode/csv-mode.el
> @@ -1,6 +1,6 @@
>  ;;; csv-mode.el --- Major mode for editing comma/char separated values  -*- lexical-binding: t -*-
>  
> -;; Copyright (C) 2003, 2004, 2012, 2013  Free Software Foundation, Inc
> +;; Copyright (C) 2003, 2004, 2012, 2013, 2014  Free Software Foundation, Inc
>  
>  ;; Author: Francis J. Wright <F.J.Wright at qmul.ac.uk>
>  ;; Time-stamp: <23 August 2004>
> @@ -247,10 +247,6 @@ Number of spaces used by `csv-align-fields' after separators."
>  ;;;  Mode definition, key bindings and menu
>  ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
>  
> -(defconst csv-mode-line-help-echo
> -  ;; See bindings.el for details of `mode-line-format' construction.
> -  (get-text-property 0 'help-echo (car (default-value 'mode-line-format)))
> -  "Primary default mode line help echo text.")
>  
>  (defconst csv-mode-line-format
>    ;; See bindings.el for details of `mode-line-format' construction.
> @@ -260,7 +256,6 @@ Number of spaces used by `csv-align-fields' after separators."
>        (setcdr x (cons
>                   `(csv-field-index-string
>                     ("" csv-field-index-string
> -                    ;; ,(propertize "--" 'help-echo csv-mode-line-help-echo)
>                      ))
>                   (cdr x))))
>      ml)
> @@ -803,8 +798,7 @@ Called by `csv-field-index-idle-timer'."
>  	  (when (not (eq field csv-field-index-old))
>  	    (setq csv-field-index-old field
>  		  csv-field-index-string
> -		  (and field (propertize (format "F%d" field)
> -					 'help-echo csv-mode-line-help-echo)))
> +		  (and field (format "F%d" field)))
>  	    (force-mode-line-update))))))
>  
>  ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

Best regards,
  Seb

-- 
Sebastien Vauban

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.