GNU bug report logs - #14950
24.3.50; gnus: Fontification of URLs is not satisfactory

Previous Next

Full log

Message #19 received at 14950-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 14950-done <at> debbugs.gnu.org, Jambunathan K <kjambunathan <at> gmail.com>
Subject: Re: bug#14950: 24.3.50;
 gnus: Fontification of URLs is not satisfactory
Date: Fri, 26 Jul 2013 08:40:56 +0900

Andreas Schwab wrote:
> Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

>> What should be improved is the default value of the user option
>> `gnus-button-url-regexp'.  But it is too complicated to let me
>> encourage to do it without enbugging.  Anyone?

> How about this?

> diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el
> index 31a108a..2433db2 100644
> --- a/lisp/gnus/gnus-art.el
> +++ b/lisp/gnus/gnus-art.el
> @@ -7177,7 +7177,8 @@ groups."
>  	  "\\(?:"
>  	  ;; Match paired parentheses, e.g. in Wikipedia URLs:
>  	  ;; http://thread.gmane.org/47B4E3B2.3050402 <at> gmail.com
> - "[" chars punct "]+" "(" "[" chars punct "]+" "[" chars "]*)" "["
> chars "]*"
> +	  "[" chars punct "]+" "(" "[" chars punct "]+" "[" chars "]*)"
> +	  "\\(?:" "[" chars punct "]+" "[" chars "]" "\\)?"
>  	  "\\|"
>  	  "[" chars punct     "]+" "[" chars "]"
>  	  "\\)"))

Great!  I understood what what you changed meant.  Thanks.
The original one only matches the last part of a url like:

http://.../abc.def(ghi)jklmno

But yours matches:

http://.../abc.def(ghi)jkl.mno

Maybe making it match the one like

http://.../abc.def(ghi)jkl.mno/pqr(stu)vwx

is not necessary.  I've installed your patch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.