GNU bug report logs - #14948
Key binding to print VC root log from VC dir

Previous Next

Package: emacs;

Reported by: Matthias Meulien <orontee <at> gmail.com>

Date: Wed, 24 Jul 2013 21:38:02 UTC

Severity: wishlist

Tags: patch

Done: Juanma Barranquero <lekktu <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14948 in the body.
You can then email your comments to 14948 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#14948; Package emacs. (Wed, 24 Jul 2013 21:38:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Matthias Meulien <orontee <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org.

Your message specified a Severity: in the pseudo-header, but the severity value wishlist tags: patch from a buffer visiting a file was not recognised. The default severity normal is being used instead. The recognised values are: critical, grave, serious, important, normal, minor, wishlist.

(Wed, 24 Jul 2013 21:38:02 GMT) Full text and rfc822 format available.


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Matthias Meulien <orontee <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: emacs-devel <at> gnu.org
Subject: Key binding to print VC root log from VC dir
Date: Wed, 24 Jul 2013 23:41:09 +0200
[Message part 1 (text/plain, inline)]
Severity: wishlist Tags: patch  From a buffer visiting a file 
under version control one has the following two key bindings to 
display logs:

         C-x v l runs the command vc-print-log

         C-x v L runs the command vc-print-root-log

From a buffer in `vc-dir-mode' one has the key binding:

         l runs the command vc-print-log

But there is no `vc-print-root-log' key binding...

[vc_dir_print_root_log.patch (text/x-diff, inline)]
From 58b23b29b45e2d3f17ed76e8ff010501d966d2c0 Mon Sep 17 00:00:00 2001
From: Matthias Meulien <orontee <at> gmail.com>
Date: Wed, 24 Jul 2013 23:39:51 +0200
Subject: [PATCH] lisp/vc/vc-dir.el (vc-dir-mode-map): Keybinding for
 vc-print-root-log

---
 lisp/vc/vc-dir.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index 80f7849..325e66e 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -240,6 +240,7 @@ See `run-hooks'."
     (define-key map "i" 'vc-register)	   ;; C-x v i
     (define-key map "+" 'vc-update)	   ;; C-x v +
     (define-key map "l" 'vc-print-log)	   ;; C-x v l
+    (define-key map "L" 'vc-print-root-log) ;; C-x v L
     ;; More confusing than helpful, probably
     ;;(define-key map "R" 'vc-revert) ;; u is taken by vc-dir-unmark.
     ;;(define-key map "A" 'vc-annotate) ;; g is taken by revert-buffer
-- 
1.8.3.3

[Message part 3 (text/plain, inline)]
Thanks for reading,
-- 
Matthias

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14948; Package emacs. (Fri, 26 Jul 2013 07:20:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <raaahh <at> gmail.com>
To: Matthias Meulien <orontee <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org, emacs-devel <at> gnu.org
Subject: Re: Key binding to print VC root log from VC dir
Date: Fri, 26 Jul 2013 10:18:13 +0300
Matthias Meulien <orontee <at> gmail.com> writes:

> Severity: wishlist Tags: patch  From a buffer visiting a file under
> version control one has the following two key bindings to display
> logs:
>
>          C-x v l runs the command vc-print-log
>
>          C-x v L runs the command vc-print-root-log
>
> From a buffer in `vc-dir-mode' one has the key binding:
>
>          l runs the command vc-print-log
>
> But there is no `vc-print-root-log' key binding...

There is. It's a global one. `C-x v L' works for me in vc-dir-mode
buffers even without this patch.

What's the problem you're trying to solve?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14948; Package emacs. (Fri, 26 Jul 2013 07:54:02 GMT) Full text and rfc822 format available.

Message #11 received at 14948 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Dmitry Gutov <raaahh <at> gmail.com>
Cc: 14948 <at> debbugs.gnu.org, Matthias Meulien <orontee <at> gmail.com>,
 emacs-devel <at> gnu.org
Subject: Re: bug#14948: Key binding to print VC root log from VC dir
Date: Fri, 26 Jul 2013 03:53:06 -0400
>> C-x v l runs the command vc-print-log
>> C-x v L runs the command vc-print-root-log
>> 
>> From a buffer in `vc-dir-mode' one has the key binding:
>> 
>> l runs the command vc-print-log
>> 
>> But there is no `vc-print-root-log' key binding...

> There is. It's a global one. `C-x v L' works for me in vc-dir-mode
> buffers even without this patch.

But since `C-x v l' is duplicated as `l', it makes a lot of sense to
duplicate `C-x v L' as `L' as his patch suggests.

Could someone install his patch, please?


        Stefan




Reply sent to Juanma Barranquero <lekktu <at> gmail.com>:
You have taken responsibility. (Fri, 26 Jul 2013 09:53:02 GMT) Full text and rfc822 format available.

Notification sent to Matthias Meulien <orontee <at> gmail.com>:
bug acknowledged by developer. (Fri, 26 Jul 2013 09:53:02 GMT) Full text and rfc822 format available.

Message #16 received at 14948-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 14948-done <at> debbugs.gnu.org, Matthias Meulien <orontee <at> gmail.com>,
 Dmitry Gutov <raaahh <at> gmail.com>, Emacs developers <emacs-devel <at> gnu.org>
Subject: Re: bug#14948: Key binding to print VC root log from VC dir
Date: Fri, 26 Jul 2013 11:51:20 +0200
On Fri, Jul 26, 2013 at 9:53 AM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:

> Could someone install his patch, please?

Done as revno:113554




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14948; Package emacs. (Fri, 26 Jul 2013 13:37:03 GMT) Full text and rfc822 format available.

Message #19 received at 14948 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <raaahh <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: emacs-devel <at> gnu.org, Matthias Meulien <orontee <at> gmail.com>,
 Dmitry Gutov <raaahh <at> gmail.com>, 14948 <at> debbugs.gnu.org
Subject: Re: bug#14948: Key binding to print VC root log from VC dir
Date: Fri, 26 Jul 2013 16:36:03 +0300
Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

> But since `C-x v l' is duplicated as `l', it makes a lot of sense to
> duplicate `C-x v L' as `L' as his patch suggests.

I see.
Shall we add a similar 'D' binding for `vc-root-diff'?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14948; Package emacs. (Fri, 26 Jul 2013 15:11:02 GMT) Full text and rfc822 format available.

Message #22 received at 14948 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dmitry Gutov <raaahh <at> gmail.com>
Cc: emacs-devel <at> gnu.org, Matthias Meulien <orontee <at> gmail.com>,
 14948 <at> debbugs.gnu.org
Subject: Re: bug#14948: Key binding to print VC root log from VC dir
Date: Fri, 26 Jul 2013 11:10:34 -0400
>> But since `C-x v l' is duplicated as `l', it makes a lot of sense to
>> duplicate `C-x v L' as `L' as his patch suggests.
> I see.
> Shall we add a similar 'D' binding for `vc-root-diff'?

That would make sense.


        Stefan




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14948; Package emacs. (Sat, 27 Jul 2013 00:12:02 GMT) Full text and rfc822 format available.

Message #25 received at 14948-done <at> debbugs.gnu.org (full text, mbox):

From: Xue Fuqiao <xfq.free <at> gmail.com>
To: 14948-done <at> debbugs.gnu.org
Subject: Re: Key binding to print VC root log from VC dir
Date: Sat, 27 Jul 2013 08:11:08 +0800
Done as revision 113563, thanks.

--
Best regards, Xue Fuqiao.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14948; Package emacs. (Sat, 27 Jul 2013 11:58:01 GMT) Full text and rfc822 format available.

Message #28 received at 14948-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <raaahh <at> gmail.com>
To: Xue Fuqiao <xfq.free <at> gmail.com>
Cc: 14948-done <at> debbugs.gnu.org
Subject: Re: bug#14948: Key binding to print VC root log from VC dir
Date: Sat, 27 Jul 2013 14:57:02 +0300
Xue Fuqiao <xfq.free <at> gmail.com> writes:

> Done as revision 113563, thanks.

Thank you. It has actually been a "paper cut" bug for me for a while.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 25 Aug 2013 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 11 years and 297 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.