From unknown Fri Aug 15 17:20:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14944: 24.3.50; Cygw32 build break Resent-From: Kazuhiro Ito Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2013 11:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14944 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 14944@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13746636092507 (code B ref -1); Wed, 24 Jul 2013 11:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Jul 2013 11:00:09 +0000 Received: from localhost ([127.0.0.1]:46512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V1wnc-0000e0-C4 for submit@debbugs.gnu.org; Wed, 24 Jul 2013 07:00:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49688) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V1wnX-0000cw-8o for submit@debbugs.gnu.org; Wed, 24 Jul 2013 07:00:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1wnR-0005MH-5R for submit@debbugs.gnu.org; Wed, 24 Jul 2013 06:59:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1wnR-0005Lr-2f for submit@debbugs.gnu.org; Wed, 24 Jul 2013 06:59:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1wnP-0004cB-RA for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2013 06:59:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1wnO-0005GC-Lu for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2013 06:59:51 -0400 Received: from mail-ae1-f8.auone-net.jp ([106.187.231.8]:55179 helo=dmta01.auone-net.jp) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1wnO-0005Fc-CX for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2013 06:59:50 -0400 Received: from amlmta038.auone-net.jp (amlmta038-MM [10.188.22.109]) by dmta01.auone-net.jp (au one net mail) with ESMTP id 3308B560182 for ; Wed, 24 Jul 2013 19:59:46 +0900 (JST) Received: from GUNGNIR.med.osaka-cu.ac.jp ([114.179.36.76]) by amlmta038.auone-net.jp id 51efb3a1000c82dc000028f0000028f2e0000292119a; Wed, 24 Jul 2013 19:59:45 +0900 Date: Wed, 24 Jul 2013 19:59:40 +0900 Message-ID: <878v0wp6jn.wl%%xmue@d1.dion.ne.jp> From: Kazuhiro Ito User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.3 (amd64-w64-nt6.1.7601) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-MXM-DELIVERY-TYPE: 3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -2.4 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Because make_save_ptr is not defined in Cygw32, Cygw32 can't be built on trunk. (snip) w32fns.o: In function `w32_monitor_enum': /build/emacs/trunk/src/w32fns.c:4933: undefined reference to `make_save_ptr' collect2: error: ld returned 1 exit status (snip) make_save_ptr is defined as below in src/alloc.c #if defined HAVE_NS || defined DOS_NT Lisp_Object make_save_ptr (void *a) { Lisp_Object val = allocate_misc (Lisp_Misc_Save_Value); struct Lisp_Save_Value *p = XSAVE_VALUE (val); p->save_type = SAVE_POINTER; p->data[0].pointer = a; return val; } #endif -- Kazuhiro Ito From unknown Fri Aug 15 17:20:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14944: 24.3.50; Cygw32 build break Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2013 11:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14944 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kazuhiro Ito Cc: 14944@debbugs.gnu.org, Paul Eggert Received: via spool by 14944-submit@debbugs.gnu.org id=B14944.137466615414650 (code B ref 14944); Wed, 24 Jul 2013 11:43:02 +0000 Received: (at 14944) by debbugs.gnu.org; 24 Jul 2013 11:42:34 +0000 Received: from localhost ([127.0.0.1]:46611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V1xSk-0003oE-Dz for submit@debbugs.gnu.org; Wed, 24 Jul 2013 07:42:34 -0400 Received: from limerock04.mail.cornell.edu ([128.84.12.60]:38354) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V1xSh-0003nx-VN for 14944@debbugs.gnu.org; Wed, 24 Jul 2013 07:42:33 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id r6OBgLDI029954; Wed, 24 Jul 2013 07:42:21 -0400 Received: from [192.168.1.3] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r6OBgJPd029004 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 Jul 2013 07:42:20 -0400 Message-ID: <51EFBD96.3060206@cornell.edu> Date: Wed, 24 Jul 2013 07:42:14 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 References: <878v0wp6jn.wl%%xmue@d1.dion.ne.jp> In-Reply-To: <878v0wp6jn.wl%%xmue@d1.dion.ne.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 7/24/2013 6:59 AM, Kazuhiro Ito wrote: > Because make_save_ptr is not defined in Cygw32, Cygw32 can't be built > on trunk. > > (snip) > w32fns.o: In function `w32_monitor_enum': > /build/emacs/trunk/src/w32fns.c:4933: undefined reference to `make_save_ptr' > collect2: error: ld returned 1 exit status > (snip) > > > make_save_ptr is defined as below in src/alloc.c > > #if defined HAVE_NS || defined DOS_NT > Lisp_Object > make_save_ptr (void *a) > { > Lisp_Object val = allocate_misc (Lisp_Misc_Save_Value); > struct Lisp_Save_Value *p = XSAVE_VALUE (val); > p->save_type = SAVE_POINTER; > p->data[0].pointer = a; > return val; > } > #endif This happened because of a change in rev 113453, in which make_save_ptr (formerly called make_save_pointer) was defined only on platforms that need it. The cygw32 platform was missed. The following should fix it. === modified file 'src/alloc.c' --- src/alloc.c 2013-07-21 15:56:55 +0000 +++ src/alloc.c 2013-07-24 11:35:40 +0000 @@ -3371,7 +3371,7 @@ return val; } -#if defined HAVE_NS || defined DOS_NT +#if defined HAVE_NS || defined DOS_NT || defined HAVE_NTGUI Lisp_Object make_save_ptr (void *a) { Ken From unknown Fri Aug 15 17:20:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14944: 24.3.50; Cygw32 build break Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2013 14:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14944 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ken Brown Cc: 14944@debbugs.gnu.org, kzhr@d1.dion.ne.jp, eggert@cs.ucla.edu Reply-To: Eli Zaretskii Received: via spool by 14944-submit@debbugs.gnu.org id=B14944.137467676329378 (code B ref 14944); Wed, 24 Jul 2013 14:40:03 +0000 Received: (at 14944) by debbugs.gnu.org; 24 Jul 2013 14:39:23 +0000 Received: from localhost ([127.0.0.1]:47198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V20Dq-0007dj-9s for submit@debbugs.gnu.org; Wed, 24 Jul 2013 10:39:22 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:42706) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V20Dh-0007d2-H1 for 14944@debbugs.gnu.org; Wed, 24 Jul 2013 10:39:17 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MQG006003ADXL00@a-mtaout20.012.net.il> for 14944@debbugs.gnu.org; Wed, 24 Jul 2013 17:38:57 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MQG0069M3CWTJ30@a-mtaout20.012.net.il>; Wed, 24 Jul 2013 17:38:56 +0300 (IDT) Date: Wed, 24 Jul 2013 17:38:50 +0300 From: Eli Zaretskii In-reply-to: <51EFBD96.3060206@cornell.edu> X-012-Sender: halo1@inter.net.il Message-id: <83fvv4vx8l.fsf@gnu.org> References: <878v0wp6jn.wl%%xmue@d1.dion.ne.jp> <51EFBD96.3060206@cornell.edu> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 24 Jul 2013 07:42:14 -0400 > From: Ken Brown > Cc: 14944@debbugs.gnu.org, Paul Eggert > > This happened because of a change in rev 113453, in which make_save_ptr > (formerly called make_save_pointer) was defined only on platforms that > need it. The cygw32 platform was missed. The following should fix it. > > === modified file 'src/alloc.c' > --- src/alloc.c 2013-07-21 15:56:55 +0000 > +++ src/alloc.c 2013-07-24 11:35:40 +0000 > @@ -3371,7 +3371,7 @@ > return val; > } > > -#if defined HAVE_NS || defined DOS_NT > +#if defined HAVE_NS || defined DOS_NT || defined HAVE_NTGUI > Lisp_Object > make_save_ptr (void *a) > { If you are adding HAVE_NTGUI, then DOS_NT is redundant, and should be removed. From unknown Fri Aug 15 17:20:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kazuhiro Ito Subject: bug#14944: closed (Re: bug#14944: 24.3.50; Cygw32 build break) Message-ID: References: <51EFEEED.1010902@cornell.edu> <878v0wp6jn.wl%%xmue@d1.dion.ne.jp> X-Gnu-PR-Message: they-closed 14944 X-Gnu-PR-Package: emacs Reply-To: 14944@debbugs.gnu.org Date: Wed, 24 Jul 2013 15:14:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1374678842-3950-1" This is a multi-part message in MIME format... ------------=_1374678842-3950-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #14944: 24.3.50; Cygw32 build break which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 14944@debbugs.gnu.org. --=20 14944: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D14944 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1374678842-3950-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 14944-done) by debbugs.gnu.org; 24 Jul 2013 15:13:03 +0000 Received: from localhost ([127.0.0.1]:47236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V20kR-0000yZ-2N for submit@debbugs.gnu.org; Wed, 24 Jul 2013 11:13:03 -0400 Received: from limerock02.mail.cornell.edu ([128.84.12.100]:60764) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V20kO-0000xo-BQ for 14944-done@debbugs.gnu.org; Wed, 24 Jul 2013 11:13:01 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id r6OFCgun012395; Wed, 24 Jul 2013 11:12:45 -0400 Received: from [192.168.1.6] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id r6OFCf1p010008 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 24 Jul 2013 11:12:41 -0400 Message-ID: <51EFEEED.1010902@cornell.edu> Date: Wed, 24 Jul 2013 11:12:45 -0400 From: Ken Brown User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130107 Thunderbird/17.0.2 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#14944: 24.3.50; Cygw32 build break References: <878v0wp6jn.wl%%xmue@d1.dion.ne.jp> <51EFBD96.3060206@cornell.edu> <83fvv4vx8l.fsf@gnu.org> In-Reply-To: <83fvv4vx8l.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14944-done Cc: kzhr@d1.dion.ne.jp, 14944-done@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 7/24/2013 10:38 AM, Eli Zaretskii wrote: >> Date: Wed, 24 Jul 2013 07:42:14 -0400 >> From: Ken Brown >> Cc: 14944@debbugs.gnu.org, Paul Eggert >> >> This happened because of a change in rev 113453, in which make_save_ptr >> (formerly called make_save_pointer) was defined only on platforms that >> need it. The cygw32 platform was missed. The following should fix it. >> >> === modified file 'src/alloc.c' >> --- src/alloc.c 2013-07-21 15:56:55 +0000 >> +++ src/alloc.c 2013-07-24 11:35:40 +0000 >> @@ -3371,7 +3371,7 @@ >> return val; >> } >> >> -#if defined HAVE_NS || defined DOS_NT >> +#if defined HAVE_NS || defined DOS_NT || defined HAVE_NTGUI >> Lisp_Object >> make_save_ptr (void *a) >> { > > If you are adding HAVE_NTGUI, then DOS_NT is redundant, and should be > removed. Done, as bzr 113529. I'm closing the bug. Ken ------------=_1374678842-3950-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Jul 2013 11:00:09 +0000 Received: from localhost ([127.0.0.1]:46512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V1wnc-0000e0-C4 for submit@debbugs.gnu.org; Wed, 24 Jul 2013 07:00:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49688) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V1wnX-0000cw-8o for submit@debbugs.gnu.org; Wed, 24 Jul 2013 07:00:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1wnR-0005MH-5R for submit@debbugs.gnu.org; Wed, 24 Jul 2013 06:59:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1wnR-0005Lr-2f for submit@debbugs.gnu.org; Wed, 24 Jul 2013 06:59:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1wnP-0004cB-RA for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2013 06:59:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1wnO-0005GC-Lu for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2013 06:59:51 -0400 Received: from mail-ae1-f8.auone-net.jp ([106.187.231.8]:55179 helo=dmta01.auone-net.jp) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1wnO-0005Fc-CX for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2013 06:59:50 -0400 Received: from amlmta038.auone-net.jp (amlmta038-MM [10.188.22.109]) by dmta01.auone-net.jp (au one net mail) with ESMTP id 3308B560182 for ; Wed, 24 Jul 2013 19:59:46 +0900 (JST) Received: from GUNGNIR.med.osaka-cu.ac.jp ([114.179.36.76]) by amlmta038.auone-net.jp id 51efb3a1000c82dc000028f0000028f2e0000292119a; Wed, 24 Jul 2013 19:59:45 +0900 Date: Wed, 24 Jul 2013 19:59:40 +0900 Message-ID: <878v0wp6jn.wl%%xmue@d1.dion.ne.jp> From: Kazuhiro Ito To: bug-gnu-emacs@gnu.org Subject: 24.3.50; Cygw32 build break User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/24.3 (amd64-w64-nt6.1.7601) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-MXM-DELIVERY-TYPE: 3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Because make_save_ptr is not defined in Cygw32, Cygw32 can't be built on trunk. (snip) w32fns.o: In function `w32_monitor_enum': /build/emacs/trunk/src/w32fns.c:4933: undefined reference to `make_save_ptr' collect2: error: ld returned 1 exit status (snip) make_save_ptr is defined as below in src/alloc.c #if defined HAVE_NS || defined DOS_NT Lisp_Object make_save_ptr (void *a) { Lisp_Object val = allocate_misc (Lisp_Misc_Save_Value); struct Lisp_Save_Value *p = XSAVE_VALUE (val); p->save_type = SAVE_POINTER; p->data[0].pointer = a; return val; } #endif -- Kazuhiro Ito ------------=_1374678842-3950-1--