GNU bug report logs - #1491
bug in ebrowse 22.1

Previous Next

Package: emacs;

Reported by: Lars Rasmusson <lars.rasmusson <at> gmail.com>

Date: Thu, 4 Dec 2008 14:40:04 UTC

Severity: normal

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Rasmusson <lars.rasmusson <at> gmail.com>
To: 1491 <at> debbugs.gnu.org
Subject: bug#1491: Info received (Same problem in 23.0.60)
Date: Sat, 6 Dec 2008 08:00:59 +0100

Isn't this a bug?
On line ebrowse.c:2037
          for (--p; p >= inbuffer && *p != '\n'; --p)
		;
I think it  should be
          for (--p; p > inbuffer && *p != '\n'; --p)
		;

otherwise p may point to one character before inbuffer.
The backwards scanning is done correctly nine lines
further up, on ebrowse.c:2028

(OS X really has some neat features to prevent accessing
data from screwed up pointers! :-) )

/Lars


Btw, is it really ok to write as in ebrowse.c:1530  ?

  /* Skip over white space.  The `#' has been consumed already.  */
  while (WHITEP (GET (c)))
    ;

GET(c) will eat up one character of the input, no matter whether it is a
white space or not...
This bug report was last modified 16 years and 132 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.