GNU bug report logs - #14863
bitwise-bit-count is wrong for negative arguments

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14863 in the body.
You can then email your comments to 14863 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Göran Weinholt <goran <at> weinholt.se>
To: bug-guile <at> gnu.org
Subject: bitwise-bit-count is wrong for negative arguments
Date: Sun, 14 Jul 2013 17:19:07 +0200

[Message part 1 (text/plain, inline)]

Hello schemers,

the bitwise-bit-count procedure from (rnrs) is wrong for negative
arguments in Guile 2.0.9:

scheme@(guile-user)> (import (rnrs))
scheme@(guile-user)> (bitwise-bit-count #b-101)
$1 = 1

The correct result is -2.

Regards,

-- 
Göran Weinholt <goran <at> weinholt.se>
13             MR. JAKES:  I think our economy was based on
14 industrial process.
15             JUSTICE SCALIA:  It was based on horses, for
16 Pete's sake.

[Message part 2 (application/pgp-signature, inline)]

Message #10 received at 14863-done <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Göran Weinholt <goran <at> weinholt.se>
Cc: 14863-done <at> debbugs.gnu.org
Subject: Re: bug#14863: bitwise-bit-count is wrong for negative arguments
Date: Sun, 14 Jul 2013 14:14:05 -0400

Göran Weinholt <goran <at> weinholt.se> writes:

> the bitwise-bit-count procedure from (rnrs) is wrong for negative
> arguments in Guile 2.0.9:
>
> scheme@(guile-user)> (import (rnrs))
> scheme@(guile-user)> (bitwise-bit-count #b-101)
> $1 = 1
>
> The correct result is -2.

Indeed, thanks for the report.  Now fixed on the stable-2.0 branch.

http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=e8f329972666db6c9d4644619473e14d54db3a80

     Mark

Message #13 received at 14863 <at> debbugs.gnu.org (full text, mbox):

From: Göran Weinholt <goran <at> weinholt.se>
To: Mark H Weaver <mhw <at> netris.org>
Cc: 14863 <at> debbugs.gnu.org
Subject: Re: bug#14863: bitwise-bit-count is wrong for negative arguments
Date: Tue, 16 Jul 2013 16:08:07 +0200

[Message part 1 (text/plain, inline)]

Mark H Weaver <mhw <at> netris.org> writes:

> Göran Weinholt <goran <at> weinholt.se> writes:
>
>> the bitwise-bit-count procedure from (rnrs) is wrong for negative
>> arguments in Guile 2.0.9:
>>
>> scheme@(guile-user)> (import (rnrs))
>> scheme@(guile-user)> (bitwise-bit-count #b-101)
>> $1 = 1
>>
>> The correct result is -2.
>
> Indeed, thanks for the report.  Now fixed on the stable-2.0 branch.
>
> http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=e8f329972666db6c9d4644619473e14d54db3a80

I just discovered that fxbit-count has the same bug.

Regards,

-- 
Göran Weinholt <goran <at> weinholt.se>
20             JUSTICE KENNEDY:  That seems odd.  I mean,
21 Microsoft doesn't say please buy our disk because it's
22 the prettiest disk in the business.

[Message part 2 (application/pgp-signature, inline)]

Message #16 received at 14863 <at> debbugs.gnu.org (full text, mbox):

From: Mark H Weaver <mhw <at> netris.org>
To: Göran Weinholt <goran <at> weinholt.se>
Cc: 14863 <at> debbugs.gnu.org
Subject: Re: bug#14863: bitwise-bit-count is wrong for negative arguments
Date: Tue, 16 Jul 2013 12:29:37 -0400

Göran Weinholt <goran <at> weinholt.se> writes:

> Mark H Weaver <mhw <at> netris.org> writes:
>
>> Göran Weinholt <goran <at> weinholt.se> writes:
>>
>>> the bitwise-bit-count procedure from (rnrs) is wrong for negative
>>> arguments in Guile 2.0.9:
>>>
>>> scheme@(guile-user)> (import (rnrs))
>>> scheme@(guile-user)> (bitwise-bit-count #b-101)
>>> $1 = 1
>>>
>>> The correct result is -2.
>>
>> Indeed, thanks for the report.  Now fixed on the stable-2.0 branch.
>>
>> http://git.savannah.gnu.org/gitweb/?p=guile.git;a=commitdiff;h=e8f329972666db6c9d4644619473e14d54db3a80
>
> I just discovered that fxbit-count has the same bug.

Fixed in a1c9ecf0a46fb3b09a268030f790aa487d38a433.

     Thanks!
       Mark

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.