From unknown Fri Jun 20 07:18:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14860 <14860@debbugs.gnu.org> To: bug#14860 <14860@debbugs.gnu.org> Subject: Status: Advice causes byte compile warning: function used to take 0+ arguments, now takes 0 Reply-To: bug#14860 <14860@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:18:55 +0000 retitle 14860 Advice causes byte compile warning: function used to take 0+ = arguments, now takes 0 reassign 14860 emacs submitter 14860 Stefan Monnier severity 14860 minor tag 14860 confirmed fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 19:36:03 2013 Received: (at submit) by debbugs.gnu.org; 13 Jul 2013 23:36:03 +0000 Received: from localhost ([127.0.0.1]:53461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uy9MB-0002kI-02 for submit@debbugs.gnu.org; Sat, 13 Jul 2013 19:36:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36837) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uy9M8-0002ja-FE for submit@debbugs.gnu.org; Sat, 13 Jul 2013 19:36:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uy9M1-0001ER-IW for submit@debbugs.gnu.org; Sat, 13 Jul 2013 19:35:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.5 required=5.0 tests=BAYES_05, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uy9M1-0001EL-Du for submit@debbugs.gnu.org; Sat, 13 Jul 2013 19:35:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uy9Lz-0003hI-Ja for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2013 19:35:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uy9Lx-0001DQ-SD for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2013 19:35:51 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:43709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uy9Lx-0001DE-Oe for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2013 19:35:49 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r6DNZagF013841; Sat, 13 Jul 2013 19:35:41 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 45AACAE2D3; Sat, 13 Jul 2013 19:35:32 -0400 (EDT) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0 Message-ID: X-debbugs-cc: Peter Vasil Date: Sat, 13 Jul 2013 19:35:32 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4638=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4638> : streams <999563> : uri <1476119> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain [ Making it into a proper bug-report. ] --=-=-= Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 8bit Return-Path: X-Original-To: monnier@iro.umontreal.ca Delivered-To: monnier@iro.umontreal.ca Received: from perlin.iro.umontreal.ca (perlin.iro.umontreal.ca [132.204.24.51]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id B7FE684C0F for ; Sat, 13 Jul 2013 07:03:03 -0400 (EDT) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by perlin.iro.umontreal.ca (Postfix) with ESMTP id BC470830002 for ; Sat, 13 Jul 2013 07:02:40 -0400 (EDT) Received: from localhost ([::1]:41434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uxxb6-0002ii-Pl for monnier@iro.umontreal.ca; Sat, 13 Jul 2013 07:02:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uxxaw-0002hh-5c for emacs-devel@gnu.org; Sat, 13 Jul 2013 07:02:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uxxat-0000py-Pp for emacs-devel@gnu.org; Sat, 13 Jul 2013 07:02:30 -0400 Received: from serv32.loswebos.de ([213.187.93.131]:42374) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uxxat-0000oY-JX for emacs-devel@gnu.org; Sat, 13 Jul 2013 07:02:27 -0400 Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by serv32.loswebos.de (Postfix) with ESMTPSA id 9F9D81994B19 for ; Sat, 13 Jul 2013 13:01:32 +0200 (CEST) Received: by mail-wg0-f54.google.com with SMTP id n11so9060708wgh.9 for ; Sat, 13 Jul 2013 04:02:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=wnVwUgTzrjgOZ139YCQK8a7FM7zXhO2SorBoOBLL0Vk=; b=YOxStNSnaTSb9j0IBsm6sreHD8ZXbJXJQoEC0VLajFhMXD8n+uM1JY6uMM9tLO6SPs TZKSvQTl3xKopxUS+RwHoYa145R3Gh24mTgVQRKmcFDtzsb0yzF/5rFLeiF0DCaJUYYw IY8aiF0F4bEPsCeP0Ha4PEmmICnw7Ay1rfNjtJUjz5z5KvbiRntSBapZfyqVoB5vUAof DFK0lc6+sCn2i9M4D6w4V1xU1H2pHxSwK7VTtLBgqahJm7XJHufQGZ58csYXpV/htj1r 6ww/EoZeCvrazIMP9T4ZnPqq1LsPS67EJWwczpNvrnvLC6ef2/ZoTJZdEF6zs+1pYRhY AqhQ== MIME-Version: 1.0 X-Received: by 10.180.9.242 with SMTP id d18mr3928120wib.18.1373713344408; Sat, 13 Jul 2013 04:02:24 -0700 (PDT) Received: by 10.216.22.132 with HTTP; Sat, 13 Jul 2013 04:02:24 -0700 (PDT) Date: Sat, 13 Jul 2013 13:02:24 +0200 Message-ID: Subject: emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0 From: Peter Vasil To: emacs-devel@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 213.187.93.131 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+monnier=iro.umontreal.ca@gnu.org Sender: emacs-devel-bounces+monnier=iro.umontreal.ca@gnu.org X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.533, requis 5, autolearn=not spam, BAYES_00 -2.60, MC_TSTLAST 0.00, RCVD_BY_IP 0.07, SPF_HELO_PASS -0.00) X-DIRO-MailScanner-From: emacs-devel-bounces+monnier=iro.umontreal.ca@gnu.org X-Spam-Status: No Hi list, I have the following function in my init.el file (defun goto-line-with-feedback () "Show line numbers temporarily, while prompting for the line number input" (interactive) (let ((line-numbers-off-p (if (boundp 'linum-mode) (not linum-mode) t))) (unwind-protect (progn (when line-numbers-off-p (linum-mode 1)) (call-interactively 'goto-line)) (when line-numbers-off-p (linum-mode -1))))) When I byte-compile init.el I get the following warning: function goto-line-with-feedback used to take 0+ arguments, now takes 0 With emacs 24.3 I don't get this warning only with emacs trunk. I am on revision 113411 Thanks, Peter --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 20:03:09 2013 Received: (at 14860) by debbugs.gnu.org; 14 Jul 2013 00:03:09 +0000 Received: from localhost ([127.0.0.1]:53474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uy9mP-0003lu-Bk for submit@debbugs.gnu.org; Sat, 13 Jul 2013 20:03:09 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:40744) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uy9mN-0003lk-Qu for 14860@debbugs.gnu.org; Sat, 13 Jul 2013 20:03:08 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r6E02wVo019639; Sat, 13 Jul 2013 20:03:02 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 5B560AE2D3; Sat, 13 Jul 2013 20:02:56 -0400 (EDT) From: Stefan Monnier To: 14860@debbugs.gnu.org Subject: Re: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0 Message-ID: References: Date: Sat, 13 Jul 2013 20:02:56 -0400 In-Reply-To: (Stefan Monnier's message of "Sat, 13 Jul 2013 19:35:32 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4638=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4638> : streams <999578> : uri <1476132> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 14860 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > (defun goto-line-with-feedback () > "Show line numbers temporarily, while prompting for the line number input" > (interactive) > (let ((line-numbers-off-p (if (boundp 'linum-mode) > (not linum-mode) > t))) > (unwind-protect > (progn > (when line-numbers-off-p > (linum-mode 1)) > (call-interactively 'goto-line)) > (when line-numbers-off-p > (linum-mode -1))))) > When I byte-compile init.el I get the following warning: > function goto-line-with-feedback used to take 0+ arguments, now takes 0 I can't reproduce this here. What does C-h f goto-line-with-feedback RET say, after starting an Emacs session? Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 13 21:04:09 2013 Received: (at 14860) by debbugs.gnu.org; 14 Jul 2013 01:04:09 +0000 Received: from localhost ([127.0.0.1]:53496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UyAjQ-00068Y-Qm for submit@debbugs.gnu.org; Sat, 13 Jul 2013 21:04:09 -0400 Received: from mout.web.de ([212.227.15.4]:63253) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UyAjO-00067j-Ad for 14860@debbugs.gnu.org; Sat, 13 Jul 2013 21:04:07 -0400 Received: from drachen.dragon ([90.187.133.75]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0MK2FR-1Uz0Cx14CL-001OGM; Sun, 14 Jul 2013 03:03:59 +0200 From: Michael Heerdegen To: Stefan Monnier Subject: Re: bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0 References: Date: Sun, 14 Jul 2013 03:03:53 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 13 Jul 2013 20:02:56 -0400") Message-ID: <87mwpqq7eu.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:O4+1JNg55Zw5nIC4FQEBZqgynonZBJpkqKaA7zdDXPi0pWs1y2a 8kp+7ntxjOaRKpD2tPa5OJaFqGovaGpCrGH+0CZMXZWtGBvDoU4vbMIHJ5NFd6wyUs0Wl2l a8cup4FBvswia4lO5Z+1eZG7nrKaJw7gnJgkRGuu984AXE43xlawwQonB7h8796YnNOHBG/ Y6TT7s7i01t4ytL5bp+nw== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 14860 Cc: 14860@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Stefan Monnier writes: > > When I byte-compile init.el I get the following warning: > > function goto-line-with-feedback used to take 0+ arguments, now takes 0 FWIW, I get exactly the same message when using nadvices. Example: put this into a file: --8<---------------cut here---------------start------------->8--- (defun test () (message "test")) (advice-add 'test :before (lambda () (message "before advice"))) --8<---------------cut here---------------end--------------->8--- load it, and byte-compile it: ==> | In test: | test.el:1:8:Warning: function test used to take 0+ arguments, now takes 0 Regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 02:34:44 2013 Received: (at 14860) by debbugs.gnu.org; 14 Jul 2013 06:34:44 +0000 Received: from localhost ([127.0.0.1]:53613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UyFtL-0003qP-OH for submit@debbugs.gnu.org; Sun, 14 Jul 2013 02:34:44 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:52649) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UyFtJ-0003qG-Vp for 14860@debbugs.gnu.org; Sun, 14 Jul 2013 02:34:42 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r6E6YbkE029100; Sun, 14 Jul 2013 02:34:38 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 928ECAE0F1; Sun, 14 Jul 2013 02:34:35 -0400 (EDT) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0 Message-ID: References: <87mwpqq7eu.fsf@web.de> Date: Sun, 14 Jul 2013 02:34:35 -0400 In-Reply-To: <87mwpqq7eu.fsf@web.de> (Michael Heerdegen's message of "Sun, 14 Jul 2013 03:03:53 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4638=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4638> : streams <999820> : uri <1476297> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 14860 Cc: 14860@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >> > When I byte-compile init.el I get the following warning: >> > function goto-line-with-feedback used to take 0+ arguments, now takes 0 > FWIW, I get exactly the same message when using nadvices. Example: put That's expected, yes. But in his case it's on a user-defined function, so it seems unlikely he put an advice on it. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 13:41:34 2013 Received: (at submit) by debbugs.gnu.org; 14 Jul 2013 17:41:34 +0000 Received: from localhost ([127.0.0.1]:54111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UyQIf-00020w-Kc for submit@debbugs.gnu.org; Sun, 14 Jul 2013 13:41:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48938) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UyQId-00020g-9z for submit@debbugs.gnu.org; Sun, 14 Jul 2013 13:41:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyQIX-0002lN-5k for submit@debbugs.gnu.org; Sun, 14 Jul 2013 13:41:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.5 required=5.0 tests=BAYES_05, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyQIX-0002lJ-3p for submit@debbugs.gnu.org; Sun, 14 Jul 2013 13:41:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyQIW-0004XQ-7u for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2013 13:41:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyQIV-0002k6-HM for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2013 13:41:24 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:39908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyQIV-0002jw-Do for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2013 13:41:23 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r6EHfDF1005916; Sun, 14 Jul 2013 13:41:18 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id D5D51AE0F1; Sun, 14 Jul 2013 13:41:06 -0400 (EDT) From: Stefan Monnier To: Peter Vasil Subject: Re: bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0 Message-ID: References: Date: Sun, 14 Jul 2013 13:41:06 -0400 In-Reply-To: (Peter Vasil's message of "Sun, 14 Jul 2013 10:56:00 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: * X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 1 X-NAI-Spam-Rules: 2 Rules triggered TO_ALIAS_IN_SUBJ=1, RV4639=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4639> : streams <1000219> : uri <1476639> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) > Indeed, I have an advice on that function > (defadvice goto-line-with-feedback > (after > expand-after-goto-line-with-feedback > activate compile) > "hideshow-expand affected block when using > goto-line-with-feedback in a collapsed buffer" > (save-excursion > (hs-show-block))) Than it's a known issue. I do wonder, tho: why on earth do you have an advice on your hand-written function? Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:04:17 2013 Received: (at 14860) by debbugs.gnu.org; 14 Jul 2013 18:04:17 +0000 Received: from localhost ([127.0.0.1]:54128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UyQed-0002nv-KG for submit@debbugs.gnu.org; Sun, 14 Jul 2013 14:04:16 -0400 Received: from serv32.loswebos.de ([213.187.93.131]:38417) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UyIJE-0002gw-0T for 14860@debbugs.gnu.org; Sun, 14 Jul 2013 05:09:36 -0400 Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by serv32.loswebos.de (Postfix) with ESMTPSA id 9F6491994BCA for <14860@debbugs.gnu.org>; Sun, 14 Jul 2013 11:08:36 +0200 (CEST) Received: by mail-wi0-f171.google.com with SMTP id hj3so1933669wib.10 for <14860@debbugs.gnu.org>; Sun, 14 Jul 2013 02:09:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Bwkgfx9IkqMXzoZLdctiUnvi5yygBepRZZVDE5wOfJQ=; b=MJMyxgJBDSjpS3+0Eg2dr466Cr5eS7tXlNu7p6wa8cKZc27Q6yq6wqBN1QhsrFQjFB nduayxGqiLKlmiCbF21zSHSmJwjmBEQT4aiwHoUp4Vl76S2Gcp2copxDBqjuA8T09w2E QvRFvxzLSxP9q1SjtkgAfgz9rPi4SYEGOdpuT7AOr9ldrl36Yd5H7yL+69G8AUUVwvWg zLAqjFIu+ojPe8VnA2TNpUCkj3QX6Qj2lj4i7BBX1xQOi+19G6HTxgUg+fJ6iCwhP+rw WyghkQX6ttmaR9XcMtd3/exWlsIv4/RvdedLWMtgspC+9fltLMeQEgpbHmNqDn5cC0vM P7Cg== MIME-Version: 1.0 X-Received: by 10.180.78.39 with SMTP id y7mr5948339wiw.4.1373792969065; Sun, 14 Jul 2013 02:09:29 -0700 (PDT) Received: by 10.216.22.132 with HTTP; Sun, 14 Jul 2013 02:09:29 -0700 (PDT) In-Reply-To: References: Date: Sun, 14 Jul 2013 11:09:29 +0200 Message-ID: Subject: Re: bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0 From: Peter Vasil To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14860 X-Mailman-Approved-At: Sun, 14 Jul 2013 14:04:13 -0400 Cc: 14860@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Indeed, I have an advice on that function (defadvice goto-line-with-feedback (after expand-after-goto-line-with-feedback activate compile) "hideshow-expand affected block when using goto-line-with-feedback in a collapsed buffer" (save-excursion (hs-show-block))) Peter On Sun, Jul 14, 2013 at 1:35 AM, Stefan Monnier wrote: > [ Making it into a proper bug-report. ] > > > > ---------- Forwarded message ---------- > From: Peter Vasil > To: emacs-devel@gnu.org > Cc: > Date: Sat, 13 Jul 2013 13:02:24 +0200 > Subject: emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0 > Hi list, > > I have the following function in my init.el file > > (defun goto-line-with-feedback () > "Show line numbers temporarily, while prompting for the line number input" > (interactive) > (let ((line-numbers-off-p (if (boundp 'linum-mode) > (not linum-mode) > t))) > (unwind-protect > (progn > (when line-numbers-off-p > (linum-mode 1)) > (call-interactively 'goto-line)) > (when line-numbers-off-p > (linum-mode -1))))) > > When I byte-compile init.el I get the following warning: > function goto-line-with-feedback used to take 0+ arguments, now takes 0 > > With emacs 24.3 I don't get this warning only with emacs trunk. > I am on revision 113411 > > Thanks, > Peter > From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 14 14:28:25 2013 Received: (at submit) by debbugs.gnu.org; 14 Jul 2013 18:28:25 +0000 Received: from localhost ([127.0.0.1]:54168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UyR20-0003iw-Vs for submit@debbugs.gnu.org; Sun, 14 Jul 2013 14:28:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58511) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UyR1y-0003ie-Kq for submit@debbugs.gnu.org; Sun, 14 Jul 2013 14:28:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyR1p-0000Z4-Fv for submit@debbugs.gnu.org; Sun, 14 Jul 2013 14:28:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyR1p-0000Z0-Ca for submit@debbugs.gnu.org; Sun, 14 Jul 2013 14:28:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyR1m-0003iB-Ak for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2013 14:28:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyR1k-0000YH-09 for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2013 14:28:10 -0400 Received: from serv32.loswebos.de ([213.187.93.131]:49731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyR1j-0000XE-Q6 for bug-gnu-emacs@gnu.org; Sun, 14 Jul 2013 14:28:07 -0400 Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by serv32.loswebos.de (Postfix) with ESMTPSA id 5E8D01994A6B for ; Sun, 14 Jul 2013 20:27:12 +0200 (CEST) Received: by mail-wg0-f48.google.com with SMTP id f11so9491469wgh.15 for ; Sun, 14 Jul 2013 11:28:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=a0II0DCfpIdfq18SNYyteHLaurm2Vowcta5v+nx3dIo=; b=Q+BNVIWUb1iCn5KLYHFOk1g0+djGKARmnHh/kYP2LBhsFPYmKwZGQRVJpjbXGChNgz dv7wZY7ziCrW37ViiFq9VaTfTIR7Yf3jPEKB6kxnl4wnhD21mjVZVd75IiDoFvUoozsb KHbU60IChdGlctNuCtzLjbcV/690zH2v3npjSjRW0n2rwN02xi0rHgkkxkoqGAjsHlwy FQonUlT6GZEUUkP/vvUOj/q4+VXRUkyUpFkrugrcouT3T+hvs3AhWCFmzjcqV7FRe2tw K1ZQW5EdGN+3SiT9006wYDHuZnZp4hTO25pSoSCJ55mmsfT9v2akt7dxfooQQqi7m9u1 04Gw== MIME-Version: 1.0 X-Received: by 10.180.78.39 with SMTP id y7mr6830725wiw.4.1373826485310; Sun, 14 Jul 2013 11:28:05 -0700 (PDT) Received: by 10.216.22.132 with HTTP; Sun, 14 Jul 2013 11:28:05 -0700 (PDT) In-Reply-To: References: Date: Sun, 14 Jul 2013 20:28:05 +0200 Message-ID: Subject: Re: bug#14860: [Peter Vasil] emacs 24.3.50.1: Byte compile warning Warning: function used to take 0+ arguments, now takes 0 From: Peter Vasil To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I had the advice only because I adviced the regular goto-line to call hs-show-block and when I added the got-line-with-feedback I just copied the first advice and did not realize that it makes no sense. I have removed the advice now and I've put the hs-show-block into got-line-with-feedback function. Sorry for the noise. Peter On Sun, Jul 14, 2013 at 7:41 PM, Stefan Monnier wrote: >> Indeed, I have an advice on that function >> (defadvice goto-line-with-feedback >> (after >> expand-after-goto-line-with-feedback >> activate compile) >> "hideshow-expand affected block when using >> goto-line-with-feedback in a collapsed buffer" >> (save-excursion >> (hs-show-block))) > > Than it's a known issue. I do wonder, tho: why on earth do you have an > advice on your hand-written function? > > > Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 14 22:15:11 2017 Received: (at control) by debbugs.gnu.org; 15 Apr 2017 02:15:11 +0000 Received: from localhost ([127.0.0.1]:47669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czDF1-0000jb-4t for submit@debbugs.gnu.org; Fri, 14 Apr 2017 22:15:11 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:36094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czDEz-0000dD-S7 for control@debbugs.gnu.org; Fri, 14 Apr 2017 22:15:10 -0400 Received: by mail-io0-f180.google.com with SMTP id l7so120067405ioe.3 for ; Fri, 14 Apr 2017 19:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=b4ExVuEnRMUqtAocf4aKRoTVvmHONxE3tBvYbEm2BOs=; b=sTu8bJXFDUtCoMXI09LFusSEGVAOSUAy3fq9/F/gT8sCo5dW+1vmZiYI/3eS/wt2zC AbP6ME/CVHGjxYbBas3FdWZ4bPSNgUk872VwDK4Bqp4t8LH3lbWAxbBK2aCwfcGvKTd/ CPn3llQsxDFfsTewVqMydp20M5Wr33qje+oulKuuwpsmPw/E+joNVG0Wx1820GTVQC39 0OW50CirWINH3nTasYicWQgFE72SXlPI9VCsz7w0h0fGi7fxvfzCu50RF7ygYKf95lC2 SGlfvRu/SUqTi3SzjrBLAfb99toJew4uBKP5T0oRRcPNZmYCQ0PfchheKv1aA4jA117I jSDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=b4ExVuEnRMUqtAocf4aKRoTVvmHONxE3tBvYbEm2BOs=; b=lbB116+LefypcalMDgbey0eTs58XQbxMZFX8uDzbbSSmJE/Se7l8spyMhS2Z/87946 15EPQfjupwpa/DvESRAdyEqjIcUOROkezfLeUtpZbAvmTipqs93OXlAretfi3/s5DJ89 kAGGfARVpRTgo9YE6iN4gmFlL0rZUxprdYJ4oC04ApzGxiTELAV4/9BWMbBKnKavv6Go W0bZWk2IThvf+vRmcTRyhBESVWJ/JZC8AoJLkPZ9w/kZVePBigbyiRxVXSHT2hY/z3BJ E15XfQYtQM3BDkK/8bXTPvNI95K0ORshoh8HpfE8RDKh3hJUQusUGPJlyD1DFuu86loF KtAQ== X-Gm-Message-State: AN3rC/46ZQgI/9tqra1J13zGfpXRSvRVpey2uqGVeRUh7FuOBz00xr8r 1BY2e/swglxA1SPI X-Received: by 10.107.188.194 with SMTP id m185mr393934iof.137.1492222504323; Fri, 14 Apr 2017 19:15:04 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id w134sm1869885iow.24.2017.04.14.19.15.03 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Apr 2017 19:15:03 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #14860 Date: Fri, 14 Apr 2017 22:16:33 -0400 Message-ID: <87zifis9dq.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) retitle 14860 Advice causes byte compile warning: function used to take 0+ arguments, now takes 0 tags 14860 confirmed quit From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 09 13:50:37 2017 Received: (at control) by debbugs.gnu.org; 9 Jul 2017 17:50:37 +0000 Received: from localhost ([127.0.0.1]:59091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUGLs-0004dw-TZ for submit@debbugs.gnu.org; Sun, 09 Jul 2017 13:50:37 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:34947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUGLp-0004df-Om; Sun, 09 Jul 2017 13:50:34 -0400 Received: by mail-it0-f66.google.com with SMTP id v193so10007791itc.2; Sun, 09 Jul 2017 10:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kgAXsF+0ZOkVx+U/qXLKzdhJ2SFMrnUs3EKdWNfbOmA=; b=JVH8Aitd6/DjxWgHTKKJ7O7JqrbAqne2IIgornk8lECYOKogUYPTj8mEU039/El/KS iO9dvW9ZBCqwfuLfMeQ9b+vTMB8NHgaQ1d534ENA6wcGjBQyF6+2qCXn1jAhH/Z5TQZa UgCF+adGh+u6u2e/FiBN7TWL1tCcvnOFuF7sbDOwnIhHkb1JhYOqQ2omPD6zzymXV3B8 vUDOaBwij73SG5zgElfgE+/3Dx2/uscVh8/xSfvn6CYfo2vQYLetjCF2yttuPcQiyxOX OJ395yeMjod7NyL4tDUkCCJkNhERVXqZZAt3g4ZZdt2fE3MUvh8V9oo0GB0zpQJrVuZD W1wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=kgAXsF+0ZOkVx+U/qXLKzdhJ2SFMrnUs3EKdWNfbOmA=; b=D6i0MF89V5w2FADjoN31vvaXCwhuRC5cZILsbRK8jppNwGL6DPIb7Sm2WalzqGepXC quA0ZdrkaTQaUf+tEPUCPuzq9OoM3TM/paKwrR5pwaR31slQMl83juSIe15vEhOf5sDP AgNezhVFprfBIJIEjQpsBuel9m9rl1nLdkVPtjercsYIiBGCxYKva81PB5YplAWCchUf K6zTSibdah9Xy1kZJbWFVN8fbXfzb+T7sfVif0c+VSuWUTrfob4dSgqSSbJdHB0QjwG8 EiVu1GUr2Lcn0W1sOJ+iNxPt17nCmJIbxf2jxBD97mXiS7Q7bng4pSfWx2Z06rp+Z4IV vQVQ== X-Gm-Message-State: AIVw110gzwMEfqIXk18TxCOkshWsCGexincq7z2B+NhUwioVEJQ8Ri7V RNinSzkYqKe1Mhoq X-Received: by 10.107.16.9 with SMTP id y9mr60274ioi.134.1499622628060; Sun, 09 Jul 2017 10:50:28 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id l27sm21842ioi.6.2017.07.09.10.50.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 09 Jul 2017 10:50:27 -0700 (PDT) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#27630: 26.0.50; Byte-compilation warnings in files.el References: <83eftpjynh.fsf@gnu.org> Date: Sun, 09 Jul 2017 13:52:01 -0400 In-Reply-To: <83eftpjynh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Jul 2017 20:41:38 +0300") Message-ID: <877ezhh51a.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control Cc: 27630@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) forcemerge 14860 27630 quit Eli Zaretskii writes: > Compiling files.el produces the following 2 warnings: > > In create-file-buffer: > files.el:1816:8:Warning: function create-file-buffer used to take 0+ > arguments, now takes 1 > > In insert-directory: > files.el:6595:43:Warning: function insert-directory used to take 0+ arguments, > now takes 2-4 > > These warnings are meant to be emitted when a function's signature > changes, but in this case there's no change, so this seems to be a > bug. The only hint I found as to why this happens is that both > functions appear in advice-add (insert-directory appears in advice-add > only on MS-Windows). I believe this is Bug#14860. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 14 11:29:54 2017 Received: (at 14860-done) by debbugs.gnu.org; 14 Jul 2017 15:29:54 +0000 Received: from localhost ([127.0.0.1]:39192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dW2XS-0007Bx-LB for submit@debbugs.gnu.org; Fri, 14 Jul 2017 11:29:54 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:49944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dW2XQ-0007Bn-27 for 14860-done@debbugs.gnu.org; Fri, 14 Jul 2017 11:29:53 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v6EFTmoS021299; Fri, 14 Jul 2017 11:29:49 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 9F5EE661EE; Fri, 14 Jul 2017 11:29:48 -0400 (EDT) From: Stefan Monnier To: 14860-done@debbugs.gnu.org Subject: Byte-compilation warnings for advised functions Message-ID: References: <83eftpjynh.fsf@gnu.org> <877ezhh51a.fsf@users.sourceforge.net> Date: Fri, 14 Jul 2017 11:29:48 -0400 In-Reply-To: <877ezhh51a.fsf@users.sourceforge.net> (npostavs's message of "Sun, 09 Jul 2017 13:52:01 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.1 X-NAI-Spam-Rules: 3 Rules triggered GEN_SPAM_FEATRE=0.1, EDT_SA_DN_PASS=0, RV6072=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6072> : inlines <5978> : streams <1754165> : uri <2462782> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 14860-done Cc: Eli Zaretskii , npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) I believe I now fixed the warnings for good in bytecomp.el. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 08:37:27 2017 Received: (at 14860) by debbugs.gnu.org; 15 Jul 2017 12:37:27 +0000 Received: from localhost ([127.0.0.1]:39609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWMK7-00017z-LK for submit@debbugs.gnu.org; Sat, 15 Jul 2017 08:37:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45867) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWMK6-00017m-3R for 14860@debbugs.gnu.org; Sat, 15 Jul 2017 08:37:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWMJx-00009P-9P for 14860@debbugs.gnu.org; Sat, 15 Jul 2017 08:37:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWMJj-00007K-Rz; Sat, 15 Jul 2017 08:37:03 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1721 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dWMJj-0001RI-9f; Sat, 15 Jul 2017 08:37:03 -0400 Date: Sat, 15 Jul 2017 15:37:07 +0300 Message-Id: <831sphg9l8.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Fri, 14 Jul 2017 11:29:48 -0400) Subject: Re: Byte-compilation warnings for advised functions References: <83eftpjynh.fsf@gnu.org> <877ezhh51a.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 14860 Cc: 14860@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Stefan Monnier > Cc: Eli Zaretskii , npostavs@users.sourceforge.net > Date: Fri, 14 Jul 2017 11:29:48 -0400 > > I believe I now fixed the warnings for good in bytecomp.el. Thanks, works here. From unknown Fri Jun 20 07:18:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 13 Aug 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 19:33:34 2017 Received: (at control) by debbugs.gnu.org; 21 Oct 2017 23:33:34 +0000 Received: from localhost ([127.0.0.1]:54748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e63Go-00048j-7Y for submit@debbugs.gnu.org; Sat, 21 Oct 2017 19:33:34 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:51373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e63Gm-00048R-6x; Sat, 21 Oct 2017 19:33:32 -0400 Received: by mail-it0-f43.google.com with SMTP id o135so2314348itb.0; Sat, 21 Oct 2017 16:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nb7bUdO+WE2khXPyZlnd+K9slZRYbe3gn05Yu+faAGM=; b=eiEVajC15xE0qEzs5jU1bxznQEaR3R4Pu7WbhlX5x66PTkmy1LdEZZp3wRXMI77XoU uz6ww7LZLJreQKE8XzS4vJ6u1RceUZKx0RdUJbtdT7H7EEfginO2L+VUsxx362xwPULp plY36O5FnpwE/SB4wGmC9IlNruMNmifS+DrcC8hRJOQUYMfUQVtzOH1Z7RRCZRCWLNgq d7OKOHcbSGFKV8hLbdTf+5lAW9HrrZTpLDd4kW27mV4CkyxhR28sr0AEq0xZeVPtKb+B 7rx1EvnvIkDrmj59FarRaaLLpV/yfoKW/A3XGXqorhTg4FqD4X2vUKu2kzmSVVzenlj8 mQ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=nb7bUdO+WE2khXPyZlnd+K9slZRYbe3gn05Yu+faAGM=; b=HCryJwJUl7Hlq3fuvkbp5PYwOPTUc0t95t3lerjdPBuFXXQFXs8a8/mOITYmcmrfdS MDOMzsXthBUiH/kmlNTmLYIiK4MyFy02Dwf4ykl8EsJBOyFRIUPKkF+9gbsivrRq2W7L wsUO3WqXTxWJWEf/sSt2ugrkqFYnLRCrXJi7YJyhjtxwzbWfujnHXuh7ObXxqSb52NV9 a6hNnbg8M+WgGvJwBp/qpk0AnasJTO2cmOWy86DJlt3PEm56u0f5uYeVJ/I9KJakqpHb 9jCeT3oN7/IdXAaTcXXgcYvoYsu4U6smGaI2D16o50pLMagSwy6o8Uq9gDxZto068L9o cHnA== X-Gm-Message-State: AMCzsaVcOe/xL0XlfNYsvEjnL/mDk0iPCqc87NDrtV8pLaoghGcG1SNF lX1SFwoWnPzJYZBQ/XXvkxMuNw== X-Google-Smtp-Source: ABhQp+QINMEhCpDuMyXNJcHA063fGxGA+DN4ZJXp2iqyIO2+aFRD/r91xTsX/rxzAr43Dr4ZYKWucQ== X-Received: by 10.36.164.75 with SMTP id v11mr4211998iti.33.1508628806353; Sat, 21 Oct 2017 16:33:26 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m12sm903590ita.17.2017.10.21.16.33.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Oct 2017 16:33:25 -0700 (PDT) From: Noam Postavsky To: John Williams Subject: Re: bug#28803: [PATCH] Fixed compiler warnings for advised functions. References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> Date: Sat, 21 Oct 2017 19:33:23 -0400 In-Reply-To: <874lr19trw.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sat, 14 Oct 2017 19:47:15 -0400") Message-ID: <87zi8kcbzw.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control Cc: 28803@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 28803 fixed close 28803 26.1 unarchive 14860 merge 28803 14860 quit Noam Postavsky writes: > John Williams writes: > >> Oops. Is there anything that can be salvaged from my patch? Aside >> from fixing the bug, it also adds a unit test and refactors the logic >> for finding a function's argument list into a separate function >> that's not part of the help system. > > We could add the test, it seems to be passing in emacs-26. I've pushed the test. [1: 237e96bc52]: 2017-10-21 19:20:46 -0400 Test that advice doesn't trigger bytecomp warnings (Bug#28803) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=237e96bc5259e59ac5623a93a47f64abffab4e0b From unknown Fri Jun 20 07:18:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Nov 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator