GNU bug report logs - #14844
24.3.50; `line-move-1': remove unused parameter _TO-END

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14844 in the body.
You can then email your comments to 14844 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; `line-move-1': remove unused parameter _TO-END
Date: Thu, 11 Jul 2013 08:43:29 -0700 (PDT)

Occam's razor says it should not be.

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-07-01 on LEG570
Bzr revision: 113246 lekktu <at> gmail.com-20130701165437-ea20s94hqwp3ttaj
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr --enable-checking CFLAGS='-O0 -g3'
 CPPFLAGS='-DGLYPH_DEBUG=1 -I/c/usr/include''

Message #8 received at 14844 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: 14844 <at> debbugs.gnu.org
Subject: RE: bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END
Date: Thu, 11 Jul 2013 08:49:39 -0700 (PDT)

Worse.  It seems that the TO-END arg is not used *anywhere*, and should be
removed from `line-move' and `line-move-partial' as well.  Too bad these
functions do not even have doc strings to explain what was intended by the
creation of this unused parameter.

> Occam's razor says it should not be.

Message #11 received at 14844 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: 14844 <at> debbugs.gnu.org
Subject: RE: bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END
Date: Thu, 11 Jul 2013 09:12:04 -0700 (PDT)

In addition, this unused parameter was apparently introduced in Emacs 22.
And it was *never even used then*, anywhere.
Its time has clearly come and gone.

> Worse.  It seems that the TO-END arg is not used *anywhere*, and should be
> removed from `line-move' and `line-move-partial' as well.  Too bad these
> functions do not even have doc strings to explain what was intended by the
> creation of this unused parameter.
> 
> > Occam's razor says it should not be.

Message #14 received at 14844 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 14844 <at> debbugs.gnu.org
Subject: Re: bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END
Date: Fri, 29 Apr 2016 02:35:23 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

> Worse.  It seems that the TO-END arg is not used *anywhere*, and should be
> removed from `line-move' and `line-move-partial' as well.  Too bad these
> functions do not even have doc strings to explain what was intended by the
> creation of this unused parameter.

Well, it's certainly in the calls to it from simple.el:

grep --color -nH -e "line-move-1" `find . -name '*.el'`
./simple.el:5930:	  (line-move-1 arg noerror to-end)
./simple.el:5941:;; This is like line-move-1 except that it also performs
./simple.el:5955:      (line-move-1 arg noerror to-end)
./simple.el:5997:	(line-move-1 arg noerror to-end)))))
./simple.el:5999:;; Display-based alternative to line-move-1.
./simple.el:6071:(defun line-move-1 (arg &optional noerror _to-end)

I'll remove those from the calls, but I think the _to_end parameter will
have to remain in the -1 function.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #21 received at 14844 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 14844 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END
Date: Fri, 29 Apr 2016 11:30:55 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I'll remove those from the calls, but I think the _to_end parameter will
> have to remain in the -1 function.

line-move is a compiled Lisp function in ‘simple.el’.

(line-move ARG &optional NOERROR TO-END TRY-VSCROLL)

Move forward ARG lines.
If NOERROR, don’t signal an error if we can’t move ARG lines.
TO-END is unused.
^^^^^^^^^^^^^^^^

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #24 received at 14844 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 14844 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14844: 24.3.50; `line-move-1': remove unused parameter _TO-END
Date: Fri, 29 Apr 2016 14:27:27 +0200

Andreas Schwab <schwab <at> linux-m68k.org> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> I'll remove those from the calls, but I think the _to_end parameter will
>> have to remain in the -1 function.
>
> line-move is a compiled Lisp function in ‘simple.el’.
>
> (line-move ARG &optional NOERROR TO-END TRY-VSCROLL)
>
> Move forward ARG lines.
> If NOERROR, don’t signal an error if we can’t move ARG lines.
> TO-END is unused.
> ^^^^^^^^^^^^^^^^

I don't know what you're trying to express here.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.