GNU bug report logs - #14830
[PATCH] * configure.ac (HAVE_W32): Avoid nested functions

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Peter Rosin <peda <at> lysator.liu.se>
Subject: bug#14830: closed (Re: bug#14830: [PATCH] * configure.ac
 (HAVE_W32): Avoid nested functions)
Date: Tue, 09 Jul 2013 18:09:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 14830 <at> debbugs.gnu.org.

-- 
14830: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14830
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Peter Rosin <peda <at> lysator.liu.se>
Cc: schwab <at> suse.de, 14830-done <at> debbugs.gnu.org
Subject: Re: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested
 functions
Date: Tue, 09 Jul 2013 21:07:44 +0300

> Date: Tue, 09 Jul 2013 10:07:28 +0200
> From: Peter Rosin <peda <at> lysator.liu.se>
> CC: Eli Zaretskii <eliz <at> gnu.org>, 14830 <at> debbugs.gnu.org
> 
> On 2013-07-09 09:17, Andreas Schwab wrote:
> > Peter Rosin <peda <at> lysator.liu.se> writes:
> > 
> >> #include <windows.h>
> >> #include <usp10.h>
> >>
> >> int
> >> main ()
> >> {
> >>   PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);
> > 
> > You need to declare pHeader somewhere.
> 
> Big sigh. Thanks for catching...

Thanks, committed as trunk revision 113349.

[Message part 3 (message/rfc822, inline)]

From: Peter Rosin <peda <at> lysator.liu.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions
Date: Tue, 09 Jul 2013 00:49:43 +0200

diff --git a/ChangeLog b/ChangeLog
index 220cffb..03011cf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-07-09  Peter Rosin <peda <at> lysator.liu.se>  (tiny change>
+
+	* configure.ac (HAVE_W32): Avoid nested functions (the second
+	argument of AC_LANG_PROGRAM is expanded inside a function).
+
 2013-07-08  Magnus Henoch <magnus.henoch <at> gmail.com> (tiny change)

 	* configure.ac (HAVE_IMAGEMAGICK): Check on NS also (Bug#14798).
diff --git a/configure.ac b/configure.ac
index 3830ee3..1188f1b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1632,10 +1632,10 @@ fi

 if test "${opsys}" = "mingw32"; then
   AC_MSG_CHECKING([whether Windows API headers are recent enough])
-  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
+  AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
      #include <windows.h>
-     #include <usp10.h>]],
-   [[void test(PIMAGE_NT_HEADERS pHeader)
+     #include <usp10.h>
+     void test(PIMAGE_NT_HEADERS pHeader)
      {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]])],
    [emacs_cv_w32api=yes
     HAVE_W32=yes],
--
1.7.9

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.