From unknown Sun Jun 22 00:43:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions Resent-From: Peter Rosin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2013 22:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14830 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 14830@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.137332380926609 (code B ref -1); Mon, 08 Jul 2013 22:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jul 2013 22:50:09 +0000 Received: from localhost ([127.0.0.1]:40408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwKG0-0006v4-8l for submit@debbugs.gnu.org; Mon, 08 Jul 2013 18:50:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59255) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwKFw-0006uL-Bs for submit@debbugs.gnu.org; Mon, 08 Jul 2013 18:50:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwKFn-0000rE-Mx for submit@debbugs.gnu.org; Mon, 08 Jul 2013 18:49:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwKFn-0000r7-J6 for submit@debbugs.gnu.org; Mon, 08 Jul 2013 18:49:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwKFm-0005Fr-LS for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2013 18:49:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwKFl-0000pI-8t for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2013 18:49:54 -0400 Received: from mail.lysator.liu.se ([2001:6b0:17:f0a0::3]:53814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwKFl-0000o7-2B for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2013 18:49:53 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 0BBD140011 for ; Tue, 9 Jul 2013 00:49:48 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id E4C2040005 for ; Tue, 9 Jul 2013 00:49:47 +0200 (CEST) Message-ID: <51DB4207.6080204@lysator.liu.se> Date: Tue, 09 Jul 2013 00:49:43 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) diff --git a/ChangeLog b/ChangeLog index 220cffb..03011cf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2013-07-09 Peter Rosin (tiny change> + + * configure.ac (HAVE_W32): Avoid nested functions (the second + argument of AC_LANG_PROGRAM is expanded inside a function). + 2013-07-08 Magnus Henoch (tiny change) * configure.ac (HAVE_IMAGEMAGICK): Check on NS also (Bug#14798). diff --git a/configure.ac b/configure.ac index 3830ee3..1188f1b 100644 --- a/configure.ac +++ b/configure.ac @@ -1632,10 +1632,10 @@ fi if test "${opsys}" = "mingw32"; then AC_MSG_CHECKING([whether Windows API headers are recent enough]) - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ #include - #include ]], - [[void test(PIMAGE_NT_HEADERS pHeader) + #include + void test(PIMAGE_NT_HEADERS pHeader) {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]])], [emacs_cv_w32api=yes HAVE_W32=yes], -- 1.7.9 From unknown Sun Jun 22 00:43:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 02:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14830 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Peter Rosin Cc: 14830@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 14830-submit@debbugs.gnu.org id=B14830.137333770328454 (code B ref 14830); Tue, 09 Jul 2013 02:42:01 +0000 Received: (at 14830) by debbugs.gnu.org; 9 Jul 2013 02:41:43 +0000 Received: from localhost ([127.0.0.1]:40773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwNs6-0007Os-LO for submit@debbugs.gnu.org; Mon, 08 Jul 2013 22:41:42 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:49681) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwNs2-0007OM-Sv for 14830@debbugs.gnu.org; Mon, 08 Jul 2013 22:41:40 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MPN00C00DY4M700@a-mtaout21.012.net.il> for 14830@debbugs.gnu.org; Tue, 09 Jul 2013 05:41:20 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MPN00C1IE4VMM00@a-mtaout21.012.net.il>; Tue, 09 Jul 2013 05:41:20 +0300 (IDT) Date: Tue, 09 Jul 2013 05:41:07 +0300 From: Eli Zaretskii In-reply-to: <51DB4207.6080204@lysator.liu.se> X-012-Sender: halo1@inter.net.il Message-id: <83d2qswj3w.fsf@gnu.org> References: <51DB4207.6080204@lysator.liu.se> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 09 Jul 2013 00:49:43 +0200 > From: Peter Rosin > > diff --git a/ChangeLog b/ChangeLog > index 220cffb..03011cf 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2013-07-09 Peter Rosin (tiny change> > + > + * configure.ac (HAVE_W32): Avoid nested functions (the second > + argument of AC_LANG_PROGRAM is expanded inside a function). > + > 2013-07-08 Magnus Henoch (tiny change) > > * configure.ac (HAVE_IMAGEMAGICK): Check on NS also (Bug#14798). > diff --git a/configure.ac b/configure.ac > index 3830ee3..1188f1b 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1632,10 +1632,10 @@ fi > > if test "${opsys}" = "mingw32"; then > AC_MSG_CHECKING([whether Windows API headers are recent enough]) > - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ > + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ > #include > - #include ]], > - [[void test(PIMAGE_NT_HEADERS pHeader) > + #include > + void test(PIMAGE_NT_HEADERS pHeader) > {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]])], > [emacs_cv_w32api=yes > HAVE_W32=yes], Sorry, I don't follow: what is the problem with the current code? From unknown Sun Jun 22 00:43:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions Resent-From: Peter Rosin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 06:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14830 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 14830@debbugs.gnu.org Received: via spool by 14830-submit@debbugs.gnu.org id=B14830.1373351265819 (code B ref 14830); Tue, 09 Jul 2013 06:28:01 +0000 Received: (at 14830) by debbugs.gnu.org; 9 Jul 2013 06:27:45 +0000 Received: from localhost ([127.0.0.1]:41023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwROp-0000D3-Jr for submit@debbugs.gnu.org; Tue, 09 Jul 2013 02:27:45 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:41729) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwROj-0000Cb-9U for 14830@debbugs.gnu.org; Tue, 09 Jul 2013 02:27:39 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 4A33040011; Tue, 9 Jul 2013 08:27:35 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 0AD014000B; Tue, 9 Jul 2013 08:27:34 +0200 (CEST) Message-ID: <51DBAD55.3050702@lysator.liu.se> Date: Tue, 09 Jul 2013 08:27:33 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 References: <51DB4207.6080204@lysator.liu.se> <83d2qswj3w.fsf@gnu.org> In-Reply-To: <83d2qswj3w.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) On 2013-07-09 04:41, Eli Zaretskii wrote: >> Date: Tue, 09 Jul 2013 00:49:43 +0200 >> From: Peter Rosin >> >> diff --git a/ChangeLog b/ChangeLog >> index 220cffb..03011cf 100644 >> --- a/ChangeLog >> +++ b/ChangeLog >> @@ -1,3 +1,8 @@ >> +2013-07-09 Peter Rosin (tiny change> >> + >> + * configure.ac (HAVE_W32): Avoid nested functions (the second >> + argument of AC_LANG_PROGRAM is expanded inside a function). >> + >> 2013-07-08 Magnus Henoch (tiny change) >> >> * configure.ac (HAVE_IMAGEMAGICK): Check on NS also (Bug#14798). >> diff --git a/configure.ac b/configure.ac >> index 3830ee3..1188f1b 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -1632,10 +1632,10 @@ fi >> >> if test "${opsys}" = "mingw32"; then >> AC_MSG_CHECKING([whether Windows API headers are recent enough]) >> - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ >> + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ >> #include >> - #include ]], >> - [[void test(PIMAGE_NT_HEADERS pHeader) >> + #include >> + void test(PIMAGE_NT_HEADERS pHeader) >> {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]])], >> [emacs_cv_w32api=yes >> HAVE_W32=yes], > > Sorry, I don't follow: what is the problem with the current code? > AC_LANG_PROGRAM([[ #include #include ]], [[void test(PIMAGE_NT_HEADERS pHeader) {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]]) is expanded into the following program (enhanced whitespace): #include #include int main () { void test(PIMAGE_NT_HEADERS pHeader) { PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader); } ; return 0; } My fixed version with AC_LANG_SOURCE will not emit the main() function and thus avoids nested functions and instead generates this source (again with enhanced whitespace): #include #include void test(PIMAGE_NT_HEADERS pHeader) { PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader); } The background is that when trying to configure with an unsupported compiler, MSVC in this case, it errors out with "the Windows API headers are too old to support this build", which is a bogus error message. Agreed, it doesn't really change anything for supported configurations, but being able to nest functions has nothing to do with the test at hand. Cheers, Peter From unknown Sun Jun 22 00:43:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions Resent-From: Peter Rosin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 06:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14830 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 14830@debbugs.gnu.org Received: via spool by 14830-submit@debbugs.gnu.org id=B14830.13733528185139 (code B ref 14830); Tue, 09 Jul 2013 06:54:02 +0000 Received: (at 14830) by debbugs.gnu.org; 9 Jul 2013 06:53:38 +0000 Received: from localhost ([127.0.0.1]:41065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwRns-0001Kn-RV for submit@debbugs.gnu.org; Tue, 09 Jul 2013 02:53:37 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:54006) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwRno-0001Kb-IY for 14830@debbugs.gnu.org; Tue, 09 Jul 2013 02:53:34 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 9B44F40012; Tue, 9 Jul 2013 08:53:31 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 320BE40011; Tue, 9 Jul 2013 08:53:31 +0200 (CEST) Message-ID: <51DBB36A.6040305@lysator.liu.se> Date: Tue, 09 Jul 2013 08:53:30 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 References: <51DB4207.6080204@lysator.liu.se> <83d2qswj3w.fsf@gnu.org> <51DBAD55.3050702@lysator.liu.se> In-Reply-To: <51DBAD55.3050702@lysator.liu.se> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) On 2013-07-09 08:27, Peter Rosin wrote: > On 2013-07-09 04:41, Eli Zaretskii wrote: >>> Date: Tue, 09 Jul 2013 00:49:43 +0200 >>> From: Peter Rosin >>> >>> diff --git a/ChangeLog b/ChangeLog >>> index 220cffb..03011cf 100644 >>> --- a/ChangeLog >>> +++ b/ChangeLog >>> @@ -1,3 +1,8 @@ >>> +2013-07-09 Peter Rosin (tiny change> >>> + >>> + * configure.ac (HAVE_W32): Avoid nested functions (the second >>> + argument of AC_LANG_PROGRAM is expanded inside a function). >>> + >>> 2013-07-08 Magnus Henoch (tiny change) >>> >>> * configure.ac (HAVE_IMAGEMAGICK): Check on NS also (Bug#14798). >>> diff --git a/configure.ac b/configure.ac >>> index 3830ee3..1188f1b 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -1632,10 +1632,10 @@ fi >>> >>> if test "${opsys}" = "mingw32"; then >>> AC_MSG_CHECKING([whether Windows API headers are recent enough]) >>> - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ >>> + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ >>> #include >>> - #include ]], >>> - [[void test(PIMAGE_NT_HEADERS pHeader) >>> + #include >>> + void test(PIMAGE_NT_HEADERS pHeader) >>> {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]])], >>> [emacs_cv_w32api=yes >>> HAVE_W32=yes], >> >> Sorry, I don't follow: what is the problem with the current code? >> > > AC_LANG_PROGRAM([[ > #include > #include ]], > [[void test(PIMAGE_NT_HEADERS pHeader) > {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]]) > > is expanded into the following program (enhanced whitespace): > > #include > #include > > int > main () > { > void test(PIMAGE_NT_HEADERS pHeader) > { > PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader); > } > ; > return 0; > } > > My fixed version with AC_LANG_SOURCE will not emit the main() function > and thus avoids nested functions and instead generates this source (again > with enhanced whitespace): > > #include > #include > > void > test(PIMAGE_NT_HEADERS pHeader) > { > PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader); > } > > The background is that when trying to configure with an unsupported > compiler, MSVC in this case, it errors out with "the Windows API > headers are too old to support this build", which is a bogus error > message. > > Agreed, it doesn't really change anything for supported configurations, > but being able to nest functions has nothing to do with the test at > hand. Hmm, the below variant is perhaps clearer? It expands into: #include #include int main () { PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader); return 0; } Cheers, Peter diff --git a/ChangeLog b/ChangeLog index 220cffb..3ba3093 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2013-07-09 Peter Rosin (tiny change> + + * configure.ac (HAVE_W32): Avoid nested functions (the second + argument of AC_LANG_PROGRAM is already expanded inside a function). + 2013-07-08 Magnus Henoch (tiny change) * configure.ac (HAVE_IMAGEMAGICK): Check on NS also (Bug#14798). diff --git a/configure.ac b/configure.ac index 3830ee3..ddfef68 100644 --- a/configure.ac +++ b/configure.ac @@ -1635,8 +1635,7 @@ if test "${opsys}" = "mingw32"; then AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ #include #include ]], - [[void test(PIMAGE_NT_HEADERS pHeader) - {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]])], + [[PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader)]])], [emacs_cv_w32api=yes HAVE_W32=yes], emacs_cv_w32api=no) -- 1.7.9 From unknown Sun Jun 22 00:43:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 06:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14830 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Peter Rosin Cc: Eli Zaretskii , 14830@debbugs.gnu.org Received: via spool by 14830-submit@debbugs.gnu.org id=B14830.13733529815564 (code B ref 14830); Tue, 09 Jul 2013 06:57:01 +0000 Received: (at 14830) by debbugs.gnu.org; 9 Jul 2013 06:56:21 +0000 Received: from localhost ([127.0.0.1]:41071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwRqV-0001Rd-HI for submit@debbugs.gnu.org; Tue, 09 Jul 2013 02:56:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58774 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwRqR-0001RR-UW for 14830@debbugs.gnu.org; Tue, 09 Jul 2013 02:56:16 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A8DE2A51BB; Tue, 9 Jul 2013 08:56:14 +0200 (CEST) From: Andreas Schwab References: <51DB4207.6080204@lysator.liu.se> <83d2qswj3w.fsf@gnu.org> <51DBAD55.3050702@lysator.liu.se> X-Yow: It's NO USE.. I've gone to ``CLUB MED''!! Date: Tue, 09 Jul 2013 08:56:13 +0200 In-Reply-To: <51DBAD55.3050702@lysator.liu.se> (Peter Rosin's message of "Tue, 09 Jul 2013 08:27:33 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Peter Rosin writes: > My fixed version with AC_LANG_SOURCE will not emit the main() function > and thus avoids nested functions and instead generates this source (again > with enhanced whitespace): > > #include > #include > > void > test(PIMAGE_NT_HEADERS pHeader) > { > PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader); > } You should instead remove the function. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Sun Jun 22 00:43:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14830 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Peter Rosin Cc: Eli Zaretskii , 14830@debbugs.gnu.org Received: via spool by 14830-submit@debbugs.gnu.org id=B14830.137335424112480 (code B ref 14830); Tue, 09 Jul 2013 07:18:02 +0000 Received: (at 14830) by debbugs.gnu.org; 9 Jul 2013 07:17:21 +0000 Received: from localhost ([127.0.0.1]:41115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwSAp-0003FC-SK for submit@debbugs.gnu.org; Tue, 09 Jul 2013 03:17:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59346 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwSAn-0003Ew-11 for 14830@debbugs.gnu.org; Tue, 09 Jul 2013 03:17:17 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4ED3DA52BF; Tue, 9 Jul 2013 09:17:16 +0200 (CEST) From: Andreas Schwab References: <51DB4207.6080204@lysator.liu.se> <83d2qswj3w.fsf@gnu.org> <51DBAD55.3050702@lysator.liu.se> <51DBB36A.6040305@lysator.liu.se> X-Yow: Zippy's brain cells are straining to bridge synapses... Date: Tue, 09 Jul 2013 09:17:16 +0200 In-Reply-To: <51DBB36A.6040305@lysator.liu.se> (Peter Rosin's message of "Tue, 09 Jul 2013 08:53:30 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Peter Rosin writes: > #include > #include > > int > main () > { > PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader); You need to declare pHeader somewhere. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Sun Jun 22 00:43:38 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions Resent-From: Peter Rosin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 08:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14830 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andreas Schwab Cc: Eli Zaretskii , 14830@debbugs.gnu.org Received: via spool by 14830-submit@debbugs.gnu.org id=B14830.137335725820355 (code B ref 14830); Tue, 09 Jul 2013 08:08:02 +0000 Received: (at 14830) by debbugs.gnu.org; 9 Jul 2013 08:07:38 +0000 Received: from localhost ([127.0.0.1]:41141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwSxV-0005IE-PA for submit@debbugs.gnu.org; Tue, 09 Jul 2013 04:07:38 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:45731) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwSxP-0005Hs-MA for 14830@debbugs.gnu.org; Tue, 09 Jul 2013 04:07:35 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id C469B40013; Tue, 9 Jul 2013 10:07:29 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 4633940011; Tue, 9 Jul 2013 10:07:29 +0200 (CEST) Message-ID: <51DBC4C0.9090500@lysator.liu.se> Date: Tue, 09 Jul 2013 10:07:28 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 References: <51DB4207.6080204@lysator.liu.se> <83d2qswj3w.fsf@gnu.org> <51DBAD55.3050702@lysator.liu.se> <51DBB36A.6040305@lysator.liu.se> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) On 2013-07-09 09:17, Andreas Schwab wrote: > Peter Rosin writes: > >> #include >> #include >> >> int >> main () >> { >> PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader); > > You need to declare pHeader somewhere. Big sigh. Thanks for catching... Cheers, Peter diff --git a/ChangeLog b/ChangeLog index 220cffb..3ba3093 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2013-07-09 Peter Rosin (tiny change> + + * configure.ac (HAVE_W32): Avoid nested functions (the second + argument of AC_LANG_PROGRAM is already expanded inside a function). + 2013-07-08 Magnus Henoch (tiny change) * configure.ac (HAVE_IMAGEMAGICK): Check on NS also (Bug#14798). diff --git a/configure.ac b/configure.ac index 3830ee3..bb140a8 100644 --- a/configure.ac +++ b/configure.ac @@ -1635,8 +1635,8 @@ if test "${opsys}" = "mingw32"; then AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ #include #include ]], - [[void test(PIMAGE_NT_HEADERS pHeader) - {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]])], + [[PIMAGE_NT_HEADERS pHeader; + PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader)]])], [emacs_cv_w32api=yes HAVE_W32=yes], emacs_cv_w32api=no) -- 1.7.9 From unknown Sun Jun 22 00:43:38 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Peter Rosin Subject: bug#14830: closed (Re: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions) Message-ID: References: <83siznvc7j.fsf@gnu.org> <51DB4207.6080204@lysator.liu.se> X-Gnu-PR-Message: they-closed 14830 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 14830@debbugs.gnu.org Date: Tue, 09 Jul 2013 18:09:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1373393342-12917-1" This is a multi-part message in MIME format... ------------=_1373393342-12917-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 14830@debbugs.gnu.org. --=20 14830: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D14830 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1373393342-12917-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 14830-done) by debbugs.gnu.org; 9 Jul 2013 18:08:06 +0000 Received: from localhost ([127.0.0.1]:43200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwcKc-0003Ku-0T for submit@debbugs.gnu.org; Tue, 09 Jul 2013 14:08:06 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:45127) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwcKZ-0003KI-IZ for 14830-done@debbugs.gnu.org; Tue, 09 Jul 2013 14:08:04 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MPO00M00KZW8F00@a-mtaout21.012.net.il> for 14830-done@debbugs.gnu.org; Tue, 09 Jul 2013 21:07:56 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MPO00MF0L182Q80@a-mtaout21.012.net.il>; Tue, 09 Jul 2013 21:07:56 +0300 (IDT) Date: Tue, 09 Jul 2013 21:07:44 +0300 From: Eli Zaretskii Subject: Re: bug#14830: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions In-reply-to: <51DBC4C0.9090500@lysator.liu.se> X-012-Sender: halo1@inter.net.il To: Peter Rosin Message-id: <83siznvc7j.fsf@gnu.org> References: <51DB4207.6080204@lysator.liu.se> <83d2qswj3w.fsf@gnu.org> <51DBAD55.3050702@lysator.liu.se> <51DBB36A.6040305@lysator.liu.se> <51DBC4C0.9090500@lysator.liu.se> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 14830-done Cc: schwab@suse.de, 14830-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 09 Jul 2013 10:07:28 +0200 > From: Peter Rosin > CC: Eli Zaretskii , 14830@debbugs.gnu.org > > On 2013-07-09 09:17, Andreas Schwab wrote: > > Peter Rosin writes: > > > >> #include > >> #include > >> > >> int > >> main () > >> { > >> PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader); > > > > You need to declare pHeader somewhere. > > Big sigh. Thanks for catching... Thanks, committed as trunk revision 113349. ------------=_1373393342-12917-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Jul 2013 22:50:09 +0000 Received: from localhost ([127.0.0.1]:40408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwKG0-0006v4-8l for submit@debbugs.gnu.org; Mon, 08 Jul 2013 18:50:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59255) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwKFw-0006uL-Bs for submit@debbugs.gnu.org; Mon, 08 Jul 2013 18:50:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwKFn-0000rE-Mx for submit@debbugs.gnu.org; Mon, 08 Jul 2013 18:49:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwKFn-0000r7-J6 for submit@debbugs.gnu.org; Mon, 08 Jul 2013 18:49:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwKFm-0005Fr-LS for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2013 18:49:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwKFl-0000pI-8t for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2013 18:49:54 -0400 Received: from mail.lysator.liu.se ([2001:6b0:17:f0a0::3]:53814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwKFl-0000o7-2B for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2013 18:49:53 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 0BBD140011 for ; Tue, 9 Jul 2013 00:49:48 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id E4C2040005 for ; Tue, 9 Jul 2013 00:49:47 +0200 (CEST) Message-ID: <51DB4207.6080204@lysator.liu.se> Date: Tue, 09 Jul 2013 00:49:43 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: [PATCH] * configure.ac (HAVE_W32): Avoid nested functions Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) diff --git a/ChangeLog b/ChangeLog index 220cffb..03011cf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2013-07-09 Peter Rosin (tiny change> + + * configure.ac (HAVE_W32): Avoid nested functions (the second + argument of AC_LANG_PROGRAM is expanded inside a function). + 2013-07-08 Magnus Henoch (tiny change) * configure.ac (HAVE_IMAGEMAGICK): Check on NS also (Bug#14798). diff --git a/configure.ac b/configure.ac index 3830ee3..1188f1b 100644 --- a/configure.ac +++ b/configure.ac @@ -1632,10 +1632,10 @@ fi if test "${opsys}" = "mingw32"; then AC_MSG_CHECKING([whether Windows API headers are recent enough]) - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ #include - #include ]], - [[void test(PIMAGE_NT_HEADERS pHeader) + #include + void test(PIMAGE_NT_HEADERS pHeader) {PIMAGE_SECTION_HEADER pSection = IMAGE_FIRST_SECTION(pHeader);}]])], [emacs_cv_w32api=yes HAVE_W32=yes], -- 1.7.9 ------------=_1373393342-12917-1--