From unknown Sat Aug 16 23:41:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Resent-From: Richard Stallman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2013 17:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 14824@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: rms@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.137330459512403 (code B ref -1); Mon, 08 Jul 2013 17:30:03 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jul 2013 17:29:55 +0000 Received: from localhost ([127.0.0.1]:39927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwFG6-0003Dy-BO for submit@debbugs.gnu.org; Mon, 08 Jul 2013 13:29:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34024) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwFG2-0003Dh-Fv for submit@debbugs.gnu.org; Mon, 08 Jul 2013 13:29:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwFFv-0004in-K6 for submit@debbugs.gnu.org; Mon, 08 Jul 2013 13:29:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-99.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwFFv-0004ib-EG for submit@debbugs.gnu.org; Mon, 08 Jul 2013 13:29:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwFFs-0002cz-Sw for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2013 13:29:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwFFp-0004d6-M6 for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2013 13:29:40 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwFFp-0004d2-Hv for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2013 13:29:37 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UwFFo-0006nv-Sk; Mon, 08 Jul 2013 13:29:36 -0400 Date: Mon, 08 Jul 2013 13:29:36 -0400 Message-Id: Content-Type: text/plain; charset=ISO-8859-15 From: Richard Stallman X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) I type C-x m rms C-c C-s, and it sends the message. (I am using Mail mode.) The buffer is marked unmodified. I type 1, and the buffer becomes modified. I type C-x u, and it deletes the 1, but the buffer is still marked as modified. In Emacs 23.2, that undo also marks the buffer as unmodified again. Unfortunately I can't try intermediate versions; they don't remain in my machine. In GNU Emacs 24.3.50.2 (mips64el-unknown-linux-gnu, GTK+ Version 2.20.1) of 2013-05-25 on chiefs-gnewsense Bzr revision: 112729 monnier@iro.umontreal.ca-20130525030804-6onx9rhvib7pv3fc System Description: gNewSense GNU/Linux 3.0 (parkes) Configured using: `configure CFLAGS=-g -O0' Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: RMAIL Minor modes in effect: shell-dirtrack-mode: t gpm-mouse-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: o ESC > RET RET ESC , C-@ C-p C-p C-p C-w C-x C-s C-x b R TAB RET ESC , C-_ C-x o r y ESC , C-o RET I SPC a m SPC s o r r y SPC t o SPC h e a r SPC i t . SPC SPC I t SPC i s SPC a SPC g o o d SPC i d e a SPC t o SPC g e t SPC m e d i c a l SPC t r e a t m e n t RET i f SPC y o u SPC a r e SPC d e p r e s s e d . C-a C-k C-p ESC e SPC SPC C-y C-x C-x ESC c ESC f ESC f ESC f C-d C-d , ESC l ESC q C-n . C-p ESC f ESC f ESC f ESC f ESC f C-f C-o SPC a n d SPC i t SPC i s SPC n o t SPC c a u s e d RET b SPC y SPC DEL DEL DEL DEL y SPC DEL DEL b y SPC t h e SPC r e a l SPC s i t u a t i o n SPC a r o n d SPC DEL DEL DEL u d SPC y o u , SPC ESC q ESC b ESC b C-f C-f C-f C-f n ESC q C-n C-n C-x o C-x 1 C-u C-v C-u C-v C-u C-n C-u C-n C-n C-u C-v C-u C-v C-u C-v C-u C-v C-u C-v c C-c C-c C-d x x m C-x 0 ESC x r e p o r t SPC e m a c s SPC b SPC u g DEL DEL RET Recent messages: Undo! Unsent message being composed; erase it? (y or n) y Mark set Auto-saving...done Mark set Auto save file for draft message exists; consider M-x mail-recover Sending... Wrote /home/rms/outgoing/out-23 Sending...done Expunging deleted messages...done Load-path shadows: /home/rms/emacs-bzr/trunk/lisp/net/shr-color hides /home/rms/emacs-bzr/trunk/lisp/gnus/shr-color /home/rms/emacs-bzr/trunk/lisp/net/shr hides /home/rms/emacs-bzr/trunk/lisp/gnus/shr Features: (shadow emacsbug epa-mail epa derived epg epg-config ispell dired-aux parse-time vc-cvs sgml-mode quail shell pcomplete grep compile comint ansi-color rmailout dabbrev novice misearch multi-isearch etags ring help-mode rmailsum mailalias qp rmailmm message sendmail format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader mail-parse rfc2231 dired t-mouse time-date finder-inf package rmailedit rmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils paren cus-start cus-load nadvice advice help-fns tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) [ To any NSA and FBI agents reading my email: please consider [ whether defending the US Constitution against all enemies, [ foreign or domestic, requires you to follow Snowden's example. -- Dr Richard Stallman President, Free Software Foundation 51 Franklin St Boston MA 02110 USA www.fsf.org www.gnu.org Skype: No way! That's nonfree (freedom-denying) software. Use Ekiga or an ordinary phone call. From unknown Sat Aug 16 23:41:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2013 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: rms@gnu.org Cc: 14824@debbugs.gnu.org Received: via spool by 14824-submit@debbugs.gnu.org id=B14824.137330567014644 (code B ref 14824); Mon, 08 Jul 2013 17:48:02 +0000 Received: (at 14824) by debbugs.gnu.org; 8 Jul 2013 17:47:50 +0000 Received: from localhost ([127.0.0.1]:39956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwFXR-0003o8-ND for submit@debbugs.gnu.org; Mon, 08 Jul 2013 13:47:49 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:56222 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwFXP-0003o0-TS for 14824@debbugs.gnu.org; Mon, 08 Jul 2013 13:47:48 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UwFXN-00028m-RL; Mon, 08 Jul 2013 13:47:45 -0400 From: Glenn Morris References: X-Spook: AGT. AMME AVN UFO pre-emptive airframe World Trade Center X-Ran: C22z6&r{:_#":(~+_j (Richard Stallman's message of "Mon, 08 Jul 2013 13:29:36 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Richard Stallman wrote: > I type C-x m rms C-c C-s, and it sends the message. > (I am using Mail mode.) The buffer is marked unmodified. > > I type 1, and the buffer becomes modified. > I type C-x u, and it deletes the 1, > but the buffer is still marked as modified. > > In Emacs 23.2, that undo also marks the buffer as unmodified again. > > Unfortunately I can't try intermediate versions; they don't > remain in my machine. Seems to have nothing to do with Mail mode. Minimal example with current trunk: emacs -Q 1 C-x u ; buffer still marked modified Issue not present in 24.3. From unknown Sat Aug 16 23:41:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 00:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: aaron.s.hawley@gmail.com, monnier@iro.umontreal.ca Cc: 14824@debbugs.gnu.org, rms@gnu.org Received: via spool by 14824-submit@debbugs.gnu.org id=B14824.137333077012861 (code B ref 14824); Tue, 09 Jul 2013 00:47:02 +0000 Received: (at 14824) by debbugs.gnu.org; 9 Jul 2013 00:46:10 +0000 Received: from localhost ([127.0.0.1]:40546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwM4H-0003LN-QV for submit@debbugs.gnu.org; Mon, 08 Jul 2013 20:46:10 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:35289 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwM4A-0003L1-TS for 14824@debbugs.gnu.org; Mon, 08 Jul 2013 20:46:06 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UwM48-0001jM-D9; Mon, 08 Jul 2013 20:46:00 -0400 From: Glenn Morris References: X-Spook: New World Order Marxist Audiotel bce unclassified SHA X-Ran: J?.&prB<3'#vy*29G`&)$GjS?1[ (Glenn Morris's message of "Mon, 08 Jul 2013 13:47:45 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Glenn Morris wrote: > Seems to have nothing to do with Mail mode. Minimal example with current > trunk: > > emacs -Q > 1 > C-x u > ; buffer still marked modified > > > Issue not present in 24.3. Bisected to: revno: 111447 author: Aaron S. Hawley committer: Stefan Monnier branch nick: trunk timestamp: Tue 2013-01-08 14:13:31 -0500 message: * lisp/simple.el (primitive-undo): Move from undo.c. * src/undo.c (Fprimitive_undo): Move to simple.el. (syms_of_undo): Remove declaration for Sprimitive_undo. * test/automated/undo-tests.el: New file. From unknown Sat Aug 16 23:41:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: aaron.s.hawley@gmail.com Cc: Glenn Morris , 14824@debbugs.gnu.org, rms@gnu.org Received: via spool by 14824-submit@debbugs.gnu.org id=B14824.137336017729181 (code B ref 14824); Tue, 09 Jul 2013 08:57:02 +0000 Received: (at 14824) by debbugs.gnu.org; 9 Jul 2013 08:56:17 +0000 Received: from localhost ([127.0.0.1]:41262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwTia-0007ab-S9 for submit@debbugs.gnu.org; Tue, 09 Jul 2013 04:56:17 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:38439) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwTiY-0007aO-P4 for 14824@debbugs.gnu.org; Tue, 09 Jul 2013 04:56:15 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r698uBFu018433; Tue, 9 Jul 2013 04:56:12 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 07038AE330; Tue, 9 Jul 2013 04:56:10 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Tue, 09 Jul 2013 04:56:10 -0400 In-Reply-To: (Glenn Morris's message of "Mon, 08 Jul 2013 20:46:00 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4633=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4633> : streams <996704> : uri <1471683> X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) >> emacs -Q >> 1 >> C-x u >> ; buffer still marked modified > Bisected to: > revno: 111447 > author: Aaron S. Hawley > committer: Stefan Monnier > branch nick: trunk > timestamp: Tue 2013-01-08 14:13:31 -0500 > message: > * lisp/simple.el (primitive-undo): Move from undo.c. > * src/undo.c (Fprimitive_undo): Move to simple.el. > (syms_of_undo): Remove declaration for Sprimitive_undo. > * test/automated/undo-tests.el: New file. A shot in the dark: it might be due to the finer timestamps (since these were introduced fairly recently, whereas Aaron's code is actually pretty old (even tho it was installed only recently)). Aaron? Stefan From unknown Sat Aug 16 23:41:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Resent-From: "Aaron S. Hawley" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Glenn Morris , 14824@debbugs.gnu.org, rms@gnu.org Received: via spool by 14824-submit@debbugs.gnu.org id=B14824.13733796573220 (code B ref 14824); Tue, 09 Jul 2013 14:21:02 +0000 Received: (at 14824) by debbugs.gnu.org; 9 Jul 2013 14:20:57 +0000 Received: from localhost ([127.0.0.1]:42656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwYmn-0000pn-1W for submit@debbugs.gnu.org; Tue, 09 Jul 2013 10:20:57 -0400 Received: from mail-pb0-f49.google.com ([209.85.160.49]:61333) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwYmk-0000pX-OS for 14824@debbugs.gnu.org; Tue, 09 Jul 2013 10:20:55 -0400 Received: by mail-pb0-f49.google.com with SMTP id jt11so5528802pbb.36 for <14824@debbugs.gnu.org>; Tue, 09 Jul 2013 07:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Z7c/voKCVMat4PhRXFiNwoxkC76eOjx329pLudp+Tww=; b=gyWXqwA3TesbNzV/SDFDQsvH3J/WVlKuE/9MAPnHHgY9r5lHKR4opUS/unj/uXXWn6 ARlZnmP56Du2QJ+Jxo+JwSpCjo5rau5ylgGD6UpbnylEuIXb1qloidjPyycFXUGFEKFc c59Nqm4gs1vSxs0LzmNKr31KFY92JAFYC5/4/rqxFLos4MGuVafJCW6Vf4OCoVnjv+ey Du6bRuEZBwTG38xJlrTPuSkkKGotMClxmemEYBE+K5QCbTqVdmy5UKMo2rIX66zRi0m2 ReYh2Z7wjy+27maWojxNfKdf7PWfXp/aquF6KcYTwsklyT4lyEY6uxOQXH4EigyrVrxC wEsQ== MIME-Version: 1.0 X-Received: by 10.68.138.131 with SMTP id qq3mr26835159pbb.10.1373379648896; Tue, 09 Jul 2013 07:20:48 -0700 (PDT) Received: by 10.70.98.235 with HTTP; Tue, 9 Jul 2013 07:20:48 -0700 (PDT) In-Reply-To: References: Date: Tue, 9 Jul 2013 10:20:48 -0400 Message-ID: From: "Aaron S. Hawley" Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > A shot in the dark: it might be due to the finer timestamps (since > these were introduced fairly recently, whereas Aaron's code is actually > pretty old (even tho it was installed only recently)). That is a good theory. I remember studying the time precision changes by Paul Eggert from last year. I think these were them: http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/108687 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9000 The changes to time values in Emacs were a concern of mine when the new Lisp version of undo was finally merged to trunk. I don't have an Emacs trunk build at the moment, so I can't confirm. It would be this section of the new undo code, though: http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/113327/lisp/simple.el#L2132 I am a little surprised this was broken in trunk for the last 6 months, and nobody had noticed. The automated test suite could catch this by adding a line containing (should (not (buffer-modified-p))) to one of the unit tests. From unknown Sat Aug 16 23:41:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 16:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Aaron S. Hawley" Cc: 14824@debbugs.gnu.org, Stefan Monnier , rms@gnu.org Received: via spool by 14824-submit@debbugs.gnu.org id=B14824.137338560319194 (code B ref 14824); Tue, 09 Jul 2013 16:01:02 +0000 Received: (at 14824) by debbugs.gnu.org; 9 Jul 2013 16:00:03 +0000 Received: from localhost ([127.0.0.1]:42886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwaKf-0004yy-2V for submit@debbugs.gnu.org; Tue, 09 Jul 2013 12:00:01 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:56103 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwaKc-0004yo-J0 for 14824@debbugs.gnu.org; Tue, 09 Jul 2013 11:59:59 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UwaKY-0004w3-DZ; Tue, 09 Jul 2013 11:59:54 -0400 From: Glenn Morris References: X-Spook: espionage JPL arrangements FIPS140 bemd 2600 Magazine X-Ran: #Q'Fc,`dQ/|1X,<_WT0G%v4]Ku0%CG;}8PN;J7oDaeAYyD)(thPt8X"E8Tt>1%%[d=I0@j X-Hue: white X-Attribution: GM Date: Tue, 09 Jul 2013 11:59:53 -0400 In-Reply-To: (Aaron S. Hawley's message of "Tue, 9 Jul 2013 10:20:48 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.6 (----) >> A shot in the dark: it might be due to the finer timestamps (since >> these were introduced fairly recently, whereas Aaron's code is actually >> pretty old (even tho it was installed only recently)). As another data point, the problem only happens with buffers that are not visiting files. > I am a little surprised this was broken in trunk for the last 6 > months, and nobody had noticed. I'm not that surprised. > The automated test suite could catch this by adding a line containing > (should (not (buffer-modified-p))) to one of the unit tests. Yep. From unknown Sat Aug 16 23:41:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Aaron S. Hawley" Cc: 14824@debbugs.gnu.org, rms@gnu.org Received: via spool by 14824-submit@debbugs.gnu.org id=B14824.137339272011521 (code B ref 14824); Tue, 09 Jul 2013 17:59:02 +0000 Received: (at 14824) by debbugs.gnu.org; 9 Jul 2013 17:58:40 +0000 Received: from localhost ([127.0.0.1]:43193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwcBT-0002zh-TE for submit@debbugs.gnu.org; Tue, 09 Jul 2013 13:58:40 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59121 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwcBS-0002zX-15 for 14824@debbugs.gnu.org; Tue, 09 Jul 2013 13:58:38 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UwcBP-00061w-E0; Tue, 09 Jul 2013 13:58:35 -0400 From: Glenn Morris References: X-Spook: Ansar al-Islam tempest Tony Blair lynch Rule Psix X-Ran: "km2D'(wY@xF;iZ(UMd0$e2.Yk|Dlo/$j*1YN?|Mz+L2^`yR66t[/%Hbl==QQhv1wU61,O X-Hue: red X-Attribution: GM Date: Tue, 09 Jul 2013 13:58:35 -0400 In-Reply-To: (Glenn Morris's message of "Tue, 09 Jul 2013 11:59:53 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Glenn Morris wrote: > As another data point, the problem only happens with buffers that are > not visiting files. I think the issue might be: buffer-undo-list has an element of the form: (t 0 0 0 -2000) I don't know where -2000 picosecs comes from. In undo.c, the test was: EMACS_TIME_NE (mod_time, base_buffer->modtime) Now the test is: (equal time (visited-file-modtime)) But visited-file-modtime returns 0 rather than -2000 picoseconds. From unknown Sat Aug 16 23:41:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 18:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Aaron S. Hawley" Cc: 14824@debbugs.gnu.org, rms@gnu.org Received: via spool by 14824-submit@debbugs.gnu.org id=B14824.137339404814453 (code B ref 14824); Tue, 09 Jul 2013 18:21:01 +0000 Received: (at 14824) by debbugs.gnu.org; 9 Jul 2013 18:20:48 +0000 Received: from localhost ([127.0.0.1]:43208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwcWu-0003l3-E9 for submit@debbugs.gnu.org; Tue, 09 Jul 2013 14:20:48 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59489 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwcWr-0003kr-JG for 14824@debbugs.gnu.org; Tue, 09 Jul 2013 14:20:46 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UwcWo-0001U5-Vx; Tue, 09 Jul 2013 14:20:43 -0400 From: Glenn Morris References: X-Spook: SWAT Mossad ICE monarchist embassy Dick Cheney X-Ran: Hd{LKYD4)yq.@SM&eos\=D}NgV7'IsHldozxbwtho7%]vELMoih$".CT69*hI@@'*{U?{N X-Hue: green X-Attribution: GM Date: Tue, 09 Jul 2013 14:20:42 -0400 In-Reply-To: (Glenn Morris's message of "Tue, 09 Jul 2013 13:58:35 -0400") Message-ID: <7asiznwq6d.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Glenn Morris wrote: > (t 0 0 0 -2000) > > I don't know where -2000 picosecs comes from. Oh, I guess it is UNKNOWN_MODTIME_NSECS = -2. From unknown Sat Aug 16 23:41:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 18:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Aaron S. Hawley" Cc: Paul Eggert , 14824@debbugs.gnu.org, rms@gnu.org Received: via spool by 14824-submit@debbugs.gnu.org id=B14824.137339439015293 (code B ref 14824); Tue, 09 Jul 2013 18:27:02 +0000 Received: (at 14824) by debbugs.gnu.org; 9 Jul 2013 18:26:30 +0000 Received: from localhost ([127.0.0.1]:43217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwccP-0003ya-RB for submit@debbugs.gnu.org; Tue, 09 Jul 2013 14:26:30 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59615 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwccN-0003yO-Sj for 14824@debbugs.gnu.org; Tue, 09 Jul 2013 14:26:28 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UwccL-0002TF-GR; Tue, 09 Jul 2013 14:26:25 -0400 From: Glenn Morris References: <7asiznwq6d.fsf@fencepost.gnu.org> X-Spook: Forte Axis of Evil SP4 MD4 CNCIS Juiliett Class Submarine X-Ran: 5'IfA,qU.Z"ef*!N`S2()JT/uu-lh\2~`{mF8rnOj]"kATTF((Gm=Lbq@Fy-\o5GX4{^bG X-Hue: red X-Attribution: GM Date: Tue, 09 Jul 2013 14:26:25 -0400 In-Reply-To: <7asiznwq6d.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 09 Jul 2013 14:20:42 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Glenn Morris wrote: > Glenn Morris wrote: > >> (t 0 0 0 -2000) >> >> I don't know where -2000 picosecs comes from. > > Oh, I guess it is UNKNOWN_MODTIME_NSECS = -2. So I guess the actual problem is that there seems no way to replicate EMACS_TIME_NE (mod_time, base_buffer->modtime) at the Lisp level. From unknown Sat Aug 16 23:41:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2013 06:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 14824@debbugs.gnu.org, "Aaron S. Hawley" , rms@gnu.org Received: via spool by 14824-submit@debbugs.gnu.org id=B14824.137343780831586 (code B ref 14824); Wed, 10 Jul 2013 06:31:02 +0000 Received: (at 14824) by debbugs.gnu.org; 10 Jul 2013 06:30:08 +0000 Received: from localhost ([127.0.0.1]:44073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uwnue-0008Ch-4C for submit@debbugs.gnu.org; Wed, 10 Jul 2013 02:30:05 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:45965) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwnuZ-0008Ba-Ku for 14824@debbugs.gnu.org; Wed, 10 Jul 2013 02:30:00 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id E3E3DA60029; Tue, 9 Jul 2013 23:29:53 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xKZP4U-04U8X; Tue, 9 Jul 2013 23:29:53 -0700 (PDT) Received: from [192.168.1.9] (pool-71-108-49-126.lsanca.fios.verizon.net [71.108.49.126]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 716F0A60027; Tue, 9 Jul 2013 23:29:53 -0700 (PDT) Message-ID: <51DCFF5D.8080407@cs.ucla.edu> Date: Tue, 09 Jul 2013 23:29:49 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 References: <7asiznwq6d.fsf@fencepost.gnu.org> In-Reply-To: X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) I installed what I hope is a fix for the bug -- please try Emacs trunk bzr 113351 or later. It works for me, for the simple test case that Glenn gave yesterday. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 10 12:47:19 2013 Received: (at control) by debbugs.gnu.org; 10 Jul 2013 16:47:19 +0000 Received: from localhost ([127.0.0.1]:45567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwxXz-0000rt-HO for submit@debbugs.gnu.org; Wed, 10 Jul 2013 12:47:19 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59688 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwxXv-0000rd-5o for control@debbugs.gnu.org; Wed, 10 Jul 2013 12:47:16 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UwxXu-0003uA-Kp for control@debbugs.gnu.org; Wed, 10 Jul 2013 12:47:14 -0400 Date: Wed, 10 Jul 2013 12:47:14 -0400 Message-Id: Subject: control message for bug 14824 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) close 14824 24.4