GNU bug report logs - #14798
24.3.50; Enable Imagemagick for Nextstep

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#14798: closed (24.3.50; Enable Imagemagick for Nextstep)
Date: Mon, 08 Jul 2013 13:28:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 8 Jul 2013 15:26:58 +0200
with message-id <C6CEAF92-CD36-4A1F-BCCA-8F25348CF9F0 <at> swipnet.se>
and subject line Re: bug#14798: 24.3.50; Enable Imagemagick for Nextstep
has caused the debbugs.gnu.org bug report #14798,
regarding 24.3.50; Enable Imagemagick for Nextstep
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
14798: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14798
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Magnus Henoch <magnus.henoch <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Enable Imagemagick for Nextstep
Date: Fri, 05 Jul 2013 01:05:01 +0100

Severity: wishlist
Tags: patch

As I'd like to be able to resize images in Emacs on Nextstep, I had a
look at what needs to be changed to enable Imagemagick on Nextstep.  Not
very much, it turns out; see diff below.

I'm not sure what it would take to support MagickExportImagePixels.  The
code tries to pass ximg->data as a parameter, but ximg is of type
XImagePtr, and on Nextstep the types are:

  typedef Pixmap XImagePtr;
  typedef void *Pixmap;

Nevertheless, it seems to work without that part.

Regards,
Magnus

diff --git a/configure.ac b/configure.ac
index baf8aab..0333898 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2041,7 +2041,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" || test "${opsys}" =
 fi
 
 HAVE_IMAGEMAGICK=no
-if test "${HAVE_X11}" = "yes"; then
+if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
   if test "${with_imagemagick}" != "no"; then
     ## 6.2.8 is the earliest version known to work, but earlier versions
     ## might work - let us know if you find one.
diff --git a/src/image.c b/src/image.c
index a3e103f..a2328dc 100644
--- a/src/image.c
+++ b/src/image.c
@@ -8054,7 +8054,9 @@ imagemagick_load_image (struct frame *f, struct image *img,
 
   init_color_table ();
 
-#ifdef HAVE_MAGICKEXPORTIMAGEPIXELS
+  /* XXX: it might be easy to get this to work for NS as well.
+     Since ximg is void*, ximg->data is not defined. */
+#if defined(HAVE_MAGICKEXPORTIMAGEPIXELS) && !defined(HAVE_NS)
   if (imagemagick_render_type != 0)
     {
       /* Magicexportimage is normally faster than pixelpushing.  This

[Message part 3 (message/rfc822, inline)]

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Magnus Henoch <magnus.henoch <at> gmail.com>
Cc: 14798-done <at> debbugs.gnu.org
Subject: Re: bug#14798: 24.3.50; Enable Imagemagick for Nextstep
Date: Mon, 8 Jul 2013 15:26:58 +0200

Hello.

Checked in into trunk.

Thanks,

	Jan D.

5 jul 2013 kl. 02:05 skrev Magnus Henoch <magnus.henoch <at> gmail.com>:

> Severity: wishlist
> Tags: patch
> 
> As I'd like to be able to resize images in Emacs on Nextstep, I had a
> look at what needs to be changed to enable Imagemagick on Nextstep.  Not
> very much, it turns out; see diff below.
> 
> I'm not sure what it would take to support MagickExportImagePixels.  The
> code tries to pass ximg->data as a parameter, but ximg is of type
> XImagePtr, and on Nextstep the types are:
> 
>  typedef Pixmap XImagePtr;
>  typedef void *Pixmap;
> 
> Nevertheless, it seems to work without that part.
> 
> Regards,
> Magnus
> 
> diff --git a/configure.ac b/configure.ac
> index baf8aab..0333898 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2041,7 +2041,7 @@ if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes" || test "${opsys}" =
> fi
> 
> HAVE_IMAGEMAGICK=no
> -if test "${HAVE_X11}" = "yes"; then
> +if test "${HAVE_X11}" = "yes" || test "${HAVE_NS}" = "yes"; then
>   if test "${with_imagemagick}" != "no"; then
>     ## 6.2.8 is the earliest version known to work, but earlier versions
>     ## might work - let us know if you find one.
> diff --git a/src/image.c b/src/image.c
> index a3e103f..a2328dc 100644
> --- a/src/image.c
> +++ b/src/image.c
> @@ -8054,7 +8054,9 @@ imagemagick_load_image (struct frame *f, struct image *img,
> 
>   init_color_table ();
> 
> -#ifdef HAVE_MAGICKEXPORTIMAGEPIXELS
> +  /* XXX: it might be easy to get this to work for NS as well.
> +     Since ximg is void*, ximg->data is not defined. */
> +#if defined(HAVE_MAGICKEXPORTIMAGEPIXELS) && !defined(HAVE_NS)
>   if (imagemagick_render_type != 0)
>     {
>       /* Magicexportimage is normally faster than pixelpushing.  This
> 
> 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.