GNU bug report logs - #14797
24.3.50; new, undocumented menu structure using VECTORS?

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Thu, 4 Jul 2013 23:55:02 UTC

Severity: minor

Tags: fixed, patch

Found in version 24.3.50

Fixed in version 25.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log


Message #34 received at 14797 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Eli Zaretskii <eliz <at> gnu.org>, npostavs <at> users.sourceforge.net
Cc: monnier <at> iro.umontreal.ca, drew.adams <at> oracle.com, 14797 <at> debbugs.gnu.org
Subject: RE: bug#14797: 24.3.50; new, undocumented menu structure using
 VECTORS?
Date: Sat, 6 Aug 2016 09:15:07 -0700 (PDT)
> > +@item @var{vector}
> > +This kind of element is similar to a char-table: element @var{n} is
> > +the binding for the character with code @var{n}.  Since the range of
> > +characters that can be bound this way is limited by the vector size,
> > +and vector creation allocates space for all character codes from 0 up,
> > +this format should not be used except for creating menu keymaps
> > +(@pxref{Menu Keymaps}), where the bindings themselves don't matter.
> > +
> >  @item @var{string}
> >  @cindex keymap prompt string
> >  @cindex overall prompt string
> 
> LGTM, except that "the character with code N" could use some better
> wording.  How about
>   ... element whose index is @var{c} is the binding for the character
>   @var{c}.
> instead?

Both look OK to me.  And adding such doc is a definite
improvement.

It's not very clear to me from this doc what the relation
is between a key binding and a "binding for the character".
Keys and characters are different animals.  Clearly there
is a relation between them here, but it doesn't seem to
be made explicit.

But again, unless you want to try to clarify that, the
proposed doc is OK, and adding it improves things.




This bug report was last modified 8 years and 288 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.