From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 04 18:53:24 2013 Received: (at submit) by debbugs.gnu.org; 4 Jul 2013 22:53:25 +0000 Received: from localhost ([127.0.0.1]:58247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UusOx-0002La-HI for submit@debbugs.gnu.org; Thu, 04 Jul 2013 18:53:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54032) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UusOm-0002LB-WE for submit@debbugs.gnu.org; Thu, 04 Jul 2013 18:53:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UusOg-00048y-Us for submit@debbugs.gnu.org; Thu, 04 Jul 2013 18:53:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UusOg-00048q-Ro for submit@debbugs.gnu.org; Thu, 04 Jul 2013 18:53:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UusOf-00016o-Eu for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2013 18:53:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UusOd-00047e-Kx for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2013 18:53:05 -0400 Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:37926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UusOd-00047P-Eo for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2013 18:53:03 -0400 Received: by mail-ee0-f45.google.com with SMTP id c1so1016810eek.32 for ; Thu, 04 Jul 2013 15:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=T2guybR3YGkHgCMDhA9upwhPVazvatMS06UhCgI28cg=; b=JHjUVytJo1xtFZQIga9uk4Crc9pH/GgVtQoxKTcUSi9cK3LDS0JcQpccLznkCMw3e5 rKFwyWbkW/Jd3z1XYZgQSURblHLjlzEbzST5wB1rpnEu28QLPBXUtMXvvNGMIjDV4c9j SM74DHOFtrCozrWXvYTncoeosZSJr0YldiLxnEjCEy70kC5x5Ht4yoswNfCcMY906+7+ QagnhQjU3Wr3zZ5vZhwR1WrQVjp8/TOJ8w5Rct4trXQ45pzvSRGtGCgigLV7GLc9BaE8 UHUcdFXP3ykXy46WfDjCF5RDR+hlXxFDESSo+iNIrP2j0nH6KlbG7psxWbvCcdjaXXPT Tcqg== X-Received: by 10.15.25.2 with SMTP id k2mr8796023eeu.99.1372978382527; Thu, 04 Jul 2013 15:53:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.142.4 with HTTP; Thu, 4 Jul 2013 15:52:22 -0700 (PDT) From: Juanma Barranquero Date: Fri, 5 Jul 2013 00:52:22 +0200 Message-ID: Subject: height parameter inconsistent in new vs existing frames when tool-bar is enabled To: Bug-Gnu-Emacs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Package: emacs This happens since at least 22.1, and I think has been discussed before on emacs-devel, but I've been unable to find the reference. emacs -Q (let ((params '((height . 25)))) (make-frame params) ;; f1 (modify-frame-parameters (make-frame) params)) ;; f2 f1 = 28 lines f2 = 25 lines Adding (tool-bar-lines . 0) to params, both frames are 25 lines. Obviously, when creating the frame Emacs is allowing three additional lines as space for the toolbar. tool-bar-mode defaults to 3 in a newly created frame, at least once it has been displayed: (let ((f (make-frame))) (cons (frame-parameter f 'tool-bar-lines) (progn (sit-for 0) (frame-parameter f 'tool-bar-lines)))) => (1 . 3) Does that happen in all platforms? If so, shouldn't we make the meaning of the height frame parameter consistent in all its uses? From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 04 19:12:24 2013 Received: (at 14795) by debbugs.gnu.org; 4 Jul 2013 23:12:24 +0000 Received: from localhost ([127.0.0.1]:58281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UushM-0002t8-00 for submit@debbugs.gnu.org; Thu, 04 Jul 2013 19:12:24 -0400 Received: from mail-ee0-f49.google.com ([74.125.83.49]:51303) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UushJ-0002ss-CN for 14795@debbugs.gnu.org; Thu, 04 Jul 2013 19:12:22 -0400 Received: by mail-ee0-f49.google.com with SMTP id b57so1011316eek.36 for <14795@debbugs.gnu.org>; Thu, 04 Jul 2013 16:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=os9Am0C/84YuYWAi1RioJ6BR6Xrx5hGrl8iLtspH+wk=; b=MmDUbbeoLCIki9ZaoNaqoa4jT1BOVNXxaJ5vA2tHnaNBsuxFr2GTBdJoJ9kES1rxbb J7hZXgpcM/Ccjfju3qNswulL+FujdYyCVg94XIw+eZhx5xLjIpOsYPkZ3LRjSpUlcZa7 VJD/4lST5FQzM5pD7Bhe3cwvsePC2fEBpbfgyTn5g9Uq9JFNy8yKuVR0RmY/W5OIFjVC ONmp0sC+UPqqMkC4N/wL8b1zg3Jm8uURDI/FSLmtV/uK268HApHboJst9V6p7iw6hazD Oaavf31KFMSsOx0v3TrmVFcmo+Narn45hMLSJzMinkEV3ilPugf4t017pqZGRd1hpqjF hgbA== X-Received: by 10.15.76.71 with SMTP id m47mr8915061eey.70.1372979535426; Thu, 04 Jul 2013 16:12:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.142.4 with HTTP; Thu, 4 Jul 2013 16:11:35 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Fri, 5 Jul 2013 01:11:35 +0200 Message-ID: Subject: Re: bug#14795: height parameter inconsistent in new vs existing frames when tool-bar is enabled To: 14795@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14795 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Martin pointed out in emacs-devel that frame.c:x_figure_window_size() includes the following comment: /* Add the tool-bar height to the initial frame height so that the user gets a text display area of the size he specified with -g or via .Xdefaults. Later changes of the tool-bar height don't change the frame size. This is done so that users can create tall Emacs frames without having to guess how tall the tool-bar will get. */ if (toolbar_p && FRAME_TOOL_BAR_LINES (f)) I remain unconvinced. That's mixing apples and oranges. If UI commands (like -g) and UI settings (like X resources) should interpret the frame height as meaning the client area, so be it. But then we should decouple these from the `height' frame parameter, because it doesn't really make sense to say that `height' means client area height when creating a frame, but total frame height when modifying it. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 03:45:43 2013 Received: (at 14795) by debbugs.gnu.org; 5 Jul 2013 07:45:43 +0000 Received: from localhost ([127.0.0.1]:58965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uv0i7-0007no-1b for submit@debbugs.gnu.org; Fri, 05 Jul 2013 03:45:43 -0400 Received: from mout.gmx.net ([212.227.15.15]:54358) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uv0i4-0007nT-BT for 14795@debbugs.gnu.org; Fri, 05 Jul 2013 03:45:40 -0400 Received: from [62.47.47.33] ([62.47.47.33]) by mail.gmx.com (mrgmx101) with ESMTPA (Nemesis) id 0M50aI-1U0Pfk0h0o-00zGxY; Fri, 05 Jul 2013 09:45:34 +0200 Message-ID: <51D6799B.4000303@gmx.at> Date: Fri, 05 Jul 2013 09:45:31 +0200 From: martin rudalics MIME-Version: 1.0 To: Juanma Barranquero Subject: Re: bug#14795: height parameter inconsistent in new vs existing frames when tool-bar is enabled References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:FVy/8yfdtaEdKWoBK8kQNv0cvZY+RKSCE9ZFrCeXIOat1RN+ncs 86sEv6fW059VFqHpWHn7pGsBozrv7fiyKcPy6yn1R2QetMl6PMt/gpOLKrXsbttqO0qJilN XyB/2aGOOlSkzFFA+Eb6p3Cf3GZ3co44KPVC/A00ujM1oWVeQgRRAnJBWtumEA62Tsu0CCw fAEFMQKt/Pbr9s/A04GhQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14795 Cc: 14795@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > /* Add the tool-bar height to the initial frame height so that the > user gets a text display area of the size he specified with -g or > via .Xdefaults. Later changes of the tool-bar height don't > change the frame size. This is done so that users can create > tall Emacs frames without having to guess how tall the tool-bar > will get. */ > if (toolbar_p && FRAME_TOOL_BAR_LINES (f)) > > I remain unconvinced. That's mixing apples and oranges. If UI commands > (like -g) and UI settings (like X resources) should interpret the > frame height as meaning the client area, so be it. But then we should > decouple these from the `height' frame parameter, because it doesn't > really make sense to say that `height' means client area height when > creating a frame, but total frame height when modifying it. What did you expect? It's impossible to tell what a frame's height or width is :-( martin From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 05:29:11 2013 Received: (at 14795) by debbugs.gnu.org; 5 Jul 2013 09:29:11 +0000 Received: from localhost ([127.0.0.1]:59119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uv2KF-0004r3-4G for submit@debbugs.gnu.org; Fri, 05 Jul 2013 05:29:11 -0400 Received: from mailout.melmac.se ([62.20.26.67]:36971) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uv2KB-0004qT-V2 for 14795@debbugs.gnu.org; Fri, 05 Jul 2013 05:29:09 -0400 Received: from mail01.melmac.se (mail01.melmac.se [62.20.26.80]) by mailout.melmac.se (Postfix) with ESMTP id 1CCC9CB12 for <14795@debbugs.gnu.org>; Fri, 5 Jul 2013 11:29:01 +0200 (CEST) Received: (qmail 17850 invoked by uid 89); 5 Jul 2013 09:29:01 -0000 Received: from h-46-59-42-57.na.cust.bahnhof.se (HELO coolsville.localdomain) (boel.djarv@bdtv.se@46.59.42.57) by mail01.melmac.se with ESMTPA; 5 Jul 2013 09:29:01 -0000 Received: from [172.20.199.13] (unknown [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id C471B1A1B76; Fri, 5 Jul 2013 09:29:00 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: bug#14795: height parameter inconsistent in new vs existing frames when tool-bar is enabled From: =?iso-8859-1?Q?Jan_Dj=E4rv?= In-Reply-To: Date: Fri, 5 Jul 2013 11:29:04 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <63EE186A-6215-4594-86C2-87DDF23F9123@swipnet.se> References: To: Juanma Barranquero X-Mailer: Apple Mail (2.1508) X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 14795 Cc: 14795@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello. 5 jul 2013 kl. 00:52 skrev Juanma Barranquero : > Package: emacs >=20 >=20 > This happens since at least 22.1, and I think has been discussed > before on emacs-devel, but I've been unable to find the reference. >=20 > emacs -Q >=20 > (let ((params '((height . 25)))) > (make-frame params) ;; f1 > (modify-frame-parameters (make-frame) params)) ;; f2 >=20 > f1 =3D 28 lines > f2 =3D 25 lines >=20 > Adding (tool-bar-lines . 0) to params, both frames are 25 lines. >=20 > Obviously, when creating the frame Emacs is allowing three additional > lines as space for the toolbar. tool-bar-mode defaults to 3 in a newly > created frame, at least once it has been displayed: >=20 > (let ((f (make-frame))) > (cons (frame-parameter f 'tool-bar-lines) > (progn > (sit-for 0) > (frame-parameter f 'tool-bar-lines)))) >=20 > =3D> (1 . 3) >=20 > Does that happen in all platforms? If so, shouldn't we make the > meaning of the height frame parameter consistent in all its uses? It does not happen in all platforms. NS and Gtk+ does not include = toolbar or menubar, so your f1 and f2 are equal size (25). Lucid/Motif on the other hand inlcude both menubar (1 line) and tool bar = (2 lines) so you get different sizes for f1 and f2. I would expect than = X without toolkit behaves like Lucid/Motif. IMHO, frame parameter like height should not include tool bar and menu = bar. Also, we should really not be talking about lines when specifying = the height of the tool/menu bar, there is no need to. The problem to fix this is you have to have access and knowledge of all = ports, and modify them in parallel. Not an easy task. Also, this has = been kind of low priority, it does not seem to lead to many user bug = reports. Jan D. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 05:52:10 2013 Received: (at 14795) by debbugs.gnu.org; 5 Jul 2013 09:52:10 +0000 Received: from localhost ([127.0.0.1]:59169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uv2gU-0005lZ-9z for submit@debbugs.gnu.org; Fri, 05 Jul 2013 05:52:10 -0400 Received: from mail-ea0-f182.google.com ([209.85.215.182]:35854) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uv2gR-0005l6-PO for 14795@debbugs.gnu.org; Fri, 05 Jul 2013 05:52:08 -0400 Received: by mail-ea0-f182.google.com with SMTP id d10so1363834eaj.13 for <14795@debbugs.gnu.org>; Fri, 05 Jul 2013 02:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=DoDJ8Txo1IqlZJsdBMvL8RETszJoU8AaOM8/OIwmFus=; b=IOINEBwrUyFoYvIKK9kR2WjXb1Hppi9GDCDgx2b+I3qGtMMH7QOSSJXhp2xHQq0SLt EKLYr17bNFSLXh/shBne6pWbGWS9qOPxusw2LUikucyvUhzCG0TmBLCsra3B7EdEQu62 YvQMZ6St9C2bpLZJps1VwJQ9I3XF++PT2lDxyjgJWXFCGZ/J/BVSX4Dl3b1vU8zGGUyr P/OJDhZdBHaaaebn3mrT0d/75pjhEgjfEpQM36NXL7/nVXjp0at8iHQVXd+Fh8SPlDhw yCeBI//NpUliswq5mmqO/vG5nCjEStESRXPUH925Gy4MYjP2RxKsbPamjJTtJa8y+cYH lsew== X-Received: by 10.15.102.68 with SMTP id bq44mr11301280eeb.89.1373017921629; Fri, 05 Jul 2013 02:52:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.142.4 with HTTP; Fri, 5 Jul 2013 02:51:21 -0700 (PDT) In-Reply-To: <51D6799B.4000303@gmx.at> References: <51D6799B.4000303@gmx.at> From: Juanma Barranquero Date: Fri, 5 Jul 2013 11:51:21 +0200 Message-ID: Subject: Re: bug#14795: height parameter inconsistent in new vs existing frames when tool-bar is enabled To: martin rudalics Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14795 Cc: 14795@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, Jul 5, 2013 at 9:45 AM, martin rudalics wrote: > What did you expect? It's impossible to tell what a frame's height or > width is :-( I expect exactly what Jan says: > IMHO, frame parameter like height should not include tool bar and menu bar. > Also, we should really not be talking about lines when specifying the height > of the tool/menu bar, there is no need to. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 05 15:49:11 2013 Received: (at control) by debbugs.gnu.org; 5 Jul 2013 19:49:11 +0000 Received: from localhost ([127.0.0.1]:60968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UvC0F-0004MD-BN for submit@debbugs.gnu.org; Fri, 05 Jul 2013 15:49:11 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:36150 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UvC0D-0004M6-Gu for control@debbugs.gnu.org; Fri, 05 Jul 2013 15:49:09 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UvC0C-0003IT-QT for control@debbugs.gnu.org; Fri, 05 Jul 2013 15:49:08 -0400 Date: Fri, 05 Jul 2013 15:49:08 -0400 Message-Id: Subject: control message for bug 14795 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) forcemerge 25 14795 From unknown Tue Jun 17 01:44:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 Jan 2015 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator