GNU bug report logs - #14769
24.3.50; [PATCH] optimize `concat's literals

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>
Subject: bug#14769: closed (Re: bug#14769: [PATCH] optimize `concat's
 literals)
Date: Wed, 26 Jun 2019 09:45:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#14769: 24.3.50; [PATCH] optimize `concat's literals

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 14769 <at> debbugs.gnu.org.

-- 
14769: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14769
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mattias Engdegård <mattiase <at> acm.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, 14769-done <at> debbugs.gnu.org,
 shigeru.fukaya <at> gmail.com
Subject: Re: bug#14769: [PATCH] optimize `concat's literals
Date: Wed, 26 Jun 2019 11:44:21 +0200

23 juni 2019 kl. 00.17 skrev Noam Postavsky <npostavs <at> gmail.com>:
> 
> Yeah, no problem.

I take that as approval for the patch then, which has become somewhat more urgent now that the rx `literal' patch has been pushed.
The alternative would be to add this concat-simplification logic to rx instead (why ry does), but it is of general use.
Pushed to master.

[Message part 3 (message/rfc822, inline)]

From: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; [PATCH] optimize `concat's literals
Date: Wed, 03 Jul 2013 02:04:28 +0900

[Message part 4 (text/plain, inline)]

Current bytecode optimizer works only when all arguments are
constants.

With the attached small patch, adjacent successive literal arguments
of `concat' will become optimized to a string respectively.

	Make successive literals of `concat' optimized to a string.
	* byte-opt.el (byte-optimize-form-code-walker): call
	byte-optimize-concat-args for `concat'.
	(byte-optimize-concat-args): New function.

Regards,
Shigeru

[byte-opt.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.