GNU bug report logs - #14769
24.3.50; [PATCH] optimize `concat's literals

Previous Next

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> gmail.com>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>, 14769 <at> debbugs.gnu.org, shigeru.fukaya <at> gmail.com
Subject: bug#14769: [PATCH] optimize `concat's literals
Date: Sat, 22 Jun 2019 18:17:25 -0400

Mattias Engdegård <mattiase <at> acm.org> writes:

> 20 juni 2019 kl. 02.38 skrev Noam Postavsky <npostavs <at> gmail.com>:
>
>>  As a minor aesthetic nitpick, I would suggest using
>> `pop', since you're already using `push'.
>
> Not to the same variable though; it isn't a stack.

Okay, interesting.  I never considered making that stylistic
distinction, I tend to use it on lists freely.

> If it's all the same to you, I'd rather keep that part of the code as it is.

Yeah, no problem.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.