GNU bug report logs - #14769
24.3.50; [PATCH] optimize `concat's literals

Previous Next

Package: emacs;

Reported by: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>

Date: Tue, 2 Jul 2013 17:05:02 UTC

Severity: wishlist

Tags: patch

Found in version 24.3.50

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Mattias Engdegård <mattiase <at> acm.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>, 14769 <at> debbugs.gnu.org, shigeru.fukaya <at> gmail.com
Subject: bug#14769: [PATCH] optimize `concat's literals
Date: Fri, 21 Jun 2019 11:07:13 +0200

20 juni 2019 kl. 02.38 skrev Noam Postavsky <npostavs <at> gmail.com>:
> 
> Looks good to me.

Thanks for looking through the code!

>  As a minor aesthetic nitpick, I would suggest using
> `pop', since you're already using `push'.

Not to the same variable though; it isn't a stack. If it's all the same to you, I'd rather keep that part of the code as it is.
This bug report was last modified 5 years and 335 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.