GNU bug report logs - #14734
24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#14734: closed (24.3.50; REGRESSION: defadvice broken wrt doc
 strings (C-h f))
Date: Thu, 27 Jun 2013 18:16:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 27 Jun 2013 14:15:22 -0400
with message-id <jwvsj034e5b.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
has caused the debbugs.gnu.org bug report #14734,
regarding 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
14734: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14734
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
Date: Thu, 27 Jun 2013 10:08:41 -0700 (PDT)

emacs -Q

(defadvice isearch-forward (before isearch+-doc activate)
  "
Isearch Plus
============
...")

`C-h f isearch-forward' does not show this addition to the doc string
at all.  In Emacs 24.3 (and prior releases) there is no such bug.

Furthermore, in the dev snapshot, you see this from `C-h f':

 :around advice: `ad-Advice-isearch-forward'

That should NOT be shown.  That is internal, implementation info.  It is
also incorrect.  The advice is :before, not :around.

And besides missing the added doc string text, this text that introduces
it is also missing (present in Emacs 24.3 and prior, where the first
line is bright red and bold):

 This function is advised.

 Before-advice `isearch+-doc':

That is user-friendly info, and it is correct (:before, not :around).

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-06-20 on ODIEONE
Bzr revision: 113100 eliz <at> gnu.org-20130620173624-w9v620tog4yacftk
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 CFLAGS=-O0 -g3 LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 14734-done <at> debbugs.gnu.org
Subject: Re: bug#14734: 24.3.50;
 REGRESSION: defadvice broken wrt doc strings (C-h f)
Date: Thu, 27 Jun 2013 14:15:22 -0400

tags 14734 wontfix
thanks

>  :around advice: `ad-Advice-isearch-forward'
[...]
> It is also incorrect.  The advice is :before, not :around.

It is correct: the ad-Advice-isearch-forward advice is an around advice
(and it is not your advice, it's internal as you say).
If you click on it, you'll see your before advice, properly labeled.

If you don't want to see the internal thingy, then use the new
advice-add rather than the old defadvice.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.