GNU bug report logs - #14734
24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Thu, 27 Jun 2013 17:10:02 UTC

Severity: minor

Tags: notabug, wontfix

Merged with 13581, 14070

Found in version 24.3.50

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #50 received at 14734 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 14734 <at> debbugs.gnu.org,
 Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings
 (C-h f)
Date: Sat, 29 Jun 2013 22:29:13 +0200
On Sat, Jun 29, 2013 at 5:24 AM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:

> The old advice.el could be reimplemented to use nadvice more directly
> (e.g. so that each defadvice turns into a single advice-add, rather
> than bundling all defadvice into a single advice-add), which would solve
> some of your complaints, but it's a lot of work and would probably break
> more backward compatibility because it'd be difficult to preserve some
> details of advice.el's semantics.

FWIW, I like a lot the new advice system and I understand why does not
make sense to spend much time with the old advices (I'm quite happy to
see the end of ad-do-it and other clumsy macros).

But I also agree with Drew that the current doctrings for adviced
functions are horrible and a big step backwards for users.

    J




This bug report was last modified 5 years and 241 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.