GNU bug report logs - #14734
24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)

Previous Next

Full log

View this message in rfc822 format

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: 14734 <at> debbugs.gnu.org
Cc: monnier <at> iro.umontreal.ca, drew.adams <at> oracle.com
Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
Date: Sat, 29 Jun 2013 00:27:21 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> >  :around advice: `ad-Advice-isearch-forward'
> [...]
> > It is also incorrect.  The advice is :before, not :around.
>
> It is correct: the ad-Advice-isearch-forward advice is an around advice
> (and it is not your advice, it's internal as you say).
> If you click on it, you'll see your before advice, properly labeled.
>
> If you don't want to see the internal thingy, then use the new
> advice-add rather than the old defadvice.

Let me add that advice.el is not yet obsolete, and the manual still
explains the old advice.el.  We should try reach a consistent state,
i.e. C-h f should report information according to the package the user
is told to use.


Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.