GNU bug report logs - #14734
24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)

Previous Next

Full log

View this message in rfc822 format

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 14734-done <at> debbugs.gnu.org
Subject: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
Date: Thu, 27 Jun 2013 11:40:36 -0700 (PDT)

> tags 14734 wontfix
> thanks
> 
> >  :around advice: `ad-Advice-isearch-forward'
> > It is also incorrect.  The advice is :before, not :around.
> 
> It is correct: the ad-Advice-isearch-forward advice is an around advice
> (and it is not your advice, it's internal as you say).
> If you click on it, you'll see your before advice, properly labeled.
> 
> If you don't want to see the internal thingy, then use the new
> advice-add rather than the old defadvice.

How can you close this bug?  Did you read the whole report?

The addition to the doc string, which is the only point of this particular advice, is MISSING from the output of C-h f.  The added text should appear at the end of the original doc string, seamlessly.

Please read the whole report and try to control your knee jerks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.