Subject: bug#14734: closed (Re: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f))

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 27 Jun 2013 18:16:03 +0000

Your bug report

#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
14734: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14734
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#14734: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
From: Stefan Monnier <[email-masked]>
To: Drew Adams <[email-masked]>
Cc: [email-masked]
Date: Thu, 27 Jun 2013 14:15:22 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

tags 14734 wontfix
thanks

>  :around advice: `ad-Advice-isearch-forward'
[...]
> It is also incorrect.  The advice is :before, not :around.

It is correct: the ad-Advice-isearch-forward advice is an around advice
(and it is not your advice, it's internal as you say).
If you click on it, you'll see your before advice, properly labeled.

If you don't want to see the internal thingy, then use the new
advice-add rather than the old defadvice.

        Stefan

Subject: 24.3.50; REGRESSION: defadvice broken wrt doc strings (C-h f)
From: Drew Adams <[email-masked]>
To: [email-masked]
Date: Thu, 27 Jun 2013 10:08:41 -0700 (PDT)
List-Id: <debbugs-submit.debbugs.gnu.org>

emacs -Q

(defadvice isearch-forward (before isearch+-doc activate)
  "
Isearch Plus
============
...")

`C-h f isearch-forward' does not show this addition to the doc string
at all.  In Emacs 24.3 (and prior releases) there is no such bug.

Furthermore, in the dev snapshot, you see this from `C-h f':

 :around advice: `ad-Advice-isearch-forward'

That should NOT be shown.  That is internal, implementation info.  It is
also incorrect.  The advice is :before, not :around.

And besides missing the added doc string text, this text that introduces
it is also missing (present in Emacs 24.3 and prior, where the first
line is bright red and bold):

 This function is advised.

 Before-advice `isearch+-doc':

That is user-friendly info, and it is correct (:before, not :around).

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-06-20 on ODIEONE
Bzr revision: 113100 [email-masked]
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 CFLAGS=-O0 -g3 LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'