GNU bug report logs - #14732
Package dos-mode for ELPA

Previous Next

Full log

Message #20 received at 14732 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Arni Magnusson <arnima <at> hafro.is>, 14732 <at> debbugs.gnu.org
Subject: Re: bug#14732: Package dos-mode for ELPA
Date: Mon, 01 Jul 2013 19:30:31 -0400

>> (1) I would be honored to prepare a patch to improve the syntax 
>> highlighting of `bat-generic-mode'. This patch would be based on existing 
>> functionality in `dos-mode' and would provide:
>> - highlighting of more commands: at attrib color date dir doskey endlocal 
>> erase fc find mkdir more move popd pushd rmdir setlocal sort time title 
>> type xcopy
>> - highlighting of more control flow keywords: cmd defined else equ exit 
>> geq gtr in leq lss neq
>> - highlighting of called script: call foo
>> - highlighting of %%variable: for %%X in (bark meow) do echo %%X
>> - highlighting of defined variable: if defined VAR

> I think we prefer this alternative, thanks.

Actually, I don't: I really dislike define-generic-mode, so while it's
OK to extend bat-generic-mode, the better way to do it is to define it
with define-derived-mode (at which point having "generic" in the name
makes no sense).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.