From unknown Sat Sep 20 08:14:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14724 <14724@debbugs.gnu.org> To: bug#14724 <14724@debbugs.gnu.org> Subject: Status: 24.3.50; `isearch-open-necessary-overlays' handling of overlay property 'isearch-open-invisible' Reply-To: bug#14724 <14724@debbugs.gnu.org> Date: Sat, 20 Sep 2025 15:14:59 +0000 retitle 14724 24.3.50; `isearch-open-necessary-overlays' handling of overla= y property 'isearch-open-invisible' reassign 14724 emacs submitter 14724 Drew Adams severity 14724 normal tag 14724 notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 26 12:25:15 2013 Received: (at submit) by debbugs.gnu.org; 26 Jun 2013 16:25:15 +0000 Received: from localhost ([127.0.0.1]:43176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrsWv-0000vU-Tw for submit@debbugs.gnu.org; Wed, 26 Jun 2013 12:25:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59163) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrsWr-0000v8-HF for submit@debbugs.gnu.org; Wed, 26 Jun 2013 12:25:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrsWk-0005Jy-6J for submit@debbugs.gnu.org; Wed, 26 Jun 2013 12:25:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrsWk-0005J0-1E for submit@debbugs.gnu.org; Wed, 26 Jun 2013 12:25:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrsWi-0002lE-Px for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 12:25:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrsWe-000586-Hy for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 12:25:00 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:21664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrsWe-000573-Bg for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2013 12:24:56 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5QGOsRZ021632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 26 Jun 2013 16:24:55 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5QGOsrb008957 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 26 Jun 2013 16:24:54 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5QGOsZh008954 for ; Wed, 26 Jun 2013 16:24:54 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 26 Jun 2013 09:24:53 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; `isearch-open-necessary-overlays' handling of overlay property 'isearch-open-invisible' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The code would be more robust if it would gracefully handle (1) an non-functional value and perhaps also (2) a functional value where invoking the function raises an error. Here is the problematic code: (funcall (overlay-get ov 'isearch-open-invisible) ov) For (1), the code could be like this: (when (functionp (overlay-get ov 'isearch-open-invisible)) (funcall (overlay-get ov 'isearch-open-invisible) ov)) For (1+2), that could be wrapped in `ignore-errors'. Dunno whether (2) is an important case to handle or whether it is really advisable to ignore such an error. Handling (1) seems to me reasonable, and with no downside. The behavior is to just do nothing additional with the overlay - e.g., leave the text invisible. Dunno know whether similar considerations apply to `isearch-open-invisible-temporary'. I'm guessing no - its value seems to be provided only by the Isearch code (whereas code far from Isearch sets the `isearch-open-invisible' overlay property). In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-06-20 on ODIEONE Bzr revision: 113100 eliz@gnu.org-20130620173624-w9v620tog4yacftk Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs CFLAGS=3D-O0 -g3 LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include' From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 26 21:37:39 2013 Received: (at 14724) by debbugs.gnu.org; 27 Jun 2013 01:37:39 +0000 Received: from localhost ([127.0.0.1]:44077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Us19W-000385-6E for submit@debbugs.gnu.org; Wed, 26 Jun 2013 21:37:38 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:44480) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Us19U-00037q-Am for 14724@debbugs.gnu.org; Wed, 26 Jun 2013 21:37:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0BwsUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0BwsUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="17262690" Received: from 76-10-154-64.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([76.10.154.64]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Jun 2013 21:37:25 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 80C4AAE34D; Wed, 26 Jun 2013 21:37:30 -0400 (EDT) From: Stefan Monnier To: Drew Adams Subject: Re: bug#14724: 24.3.50; `isearch-open-necessary-overlays' handling of overlay property 'isearch-open-invisible' Message-ID: References: Date: Wed, 26 Jun 2013 21:37:30 -0400 In-Reply-To: (Drew Adams's message of "Wed, 26 Jun 2013 09:24:53 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 14724 Cc: 14724@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > The code would be more robust if it would gracefully handle (1) an > non-functional value and perhaps Wouldn't such a non-function non-nil value reflect an error in an Elisp package? If so, why should we silence it? > For (1+2), that could be wrapped in `ignore-errors'. I thing I disagree with ignore-errors here (at least, I don't think such errors are normal, so they shouldn't be silenced), but using with-demoted-errors could make sense if errors in this code could make isearch non-functional. Is that the case? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 26 22:38:33 2013 Received: (at 14724) by debbugs.gnu.org; 27 Jun 2013 02:38:33 +0000 Received: from localhost ([127.0.0.1]:44167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Us26S-0004je-B0 for submit@debbugs.gnu.org; Wed, 26 Jun 2013 22:38:32 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:21991) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Us26O-0004jN-8e for 14724@debbugs.gnu.org; Wed, 26 Jun 2013 22:38:28 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5R2cL8U011113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 27 Jun 2013 02:38:22 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5R2cKY8013616 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 27 Jun 2013 02:38:20 GMT Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5R2cK6G008265; Thu, 27 Jun 2013 02:38:20 GMT MIME-Version: 1.0 Message-ID: <5579ad7c-967c-4635-b9cc-758968faddb1@default> Date: Wed, 26 Jun 2013 19:38:19 -0700 (PDT) From: Drew Adams To: Stefan Monnier Subject: RE: bug#14724: 24.3.50; `isearch-open-necessary-overlays' handling of overlay property 'isearch-open-invisible' References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 14724 Cc: 14724@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > > The code would be more robust if it would gracefully handle (1) an > > non-functional value and perhaps >=20 > Wouldn't such a non-function non-nil value reflect an error in an > Elisp package? Yes, normally. In Elisp code, whether a package or not, and whether distri= buted by Emacs Dev or not. > If so, why should we silence it? It would allow 3rd-party code that might not be correct in this regard to a= t least allow Isearch to continue to function normally otherwise. The only reasonable value is a function, since we immediately invoke funcal= l with it. I'm guessing it might not be obvious to someone where the error= lies. It costs nothing for the code to protect itself from funcalling a non-funct= ion here and thus fail gracefully with a no-op. Someone trying to use this= feature will as likely dig in to figure out the problem with a non-action = as with an error, but users would at least not be impacted. Of course I agree that raising an error for incorrect code is typically TRT= . I'm not sure it is in this case. See what I said about `isearch-open-in= visible-temporary', which is different in that it is not set up in distant = code but is internal to isearch.el. > > For (1+2), that could be wrapped in `ignore-errors'. >=20 > I thing I disagree with ignore-errors here (at least, I don't think such > errors are normal, so they shouldn't be silenced), but using > with-demoted-errors could make sense if errors in this code could make > isearch non-functional. Is that the case? An error is raised; that's all - Isearch is not broken by it. Yes, `with-d= emoted-errors' makes more sense. The same considerations apply here as for= a non-function: better a no-op (a msg is OK) than an error, I think. Whatever you decide is fine with me. I'm essentially bringing it to your a= ttention. Perhaps Juri has some input on this? From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 26 23:00:43 2013 Received: (at control) by debbugs.gnu.org; 27 Jun 2013 03:00:43 +0000 Received: from localhost ([127.0.0.1]:44193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Us2Rn-0005H9-MB for submit@debbugs.gnu.org; Wed, 26 Jun 2013 23:00:37 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:47286) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Us2Rc-0005Ge-7H; Wed, 26 Jun 2013 23:00:26 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0BwsUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0BwsUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="17266033" Received: from 76-10-154-64.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([76.10.154.64]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Jun 2013 23:00:13 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 35D0FAE0BA; Wed, 26 Jun 2013 23:00:18 -0400 (EDT) From: Stefan Monnier To: Drew Adams Subject: Re: bug#14724: 24.3.50; `isearch-open-necessary-overlays' handling of overlay property 'isearch-open-invisible' Message-ID: References: <5579ad7c-967c-4635-b9cc-758968faddb1@default> Date: Wed, 26 Jun 2013 23:00:18 -0400 In-Reply-To: <5579ad7c-967c-4635-b9cc-758968faddb1@default> (Drew Adams's message of "Wed, 26 Jun 2013 19:38:19 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control Cc: 14724-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) tags 14724 notabug thanks > An error is raised; that's all - Isearch is not broken by it. Yes, Then there's no point adding a with-demoted-error. Stefan From unknown Sat Sep 20 08:14:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 25 Jul 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator