GNU bug report logs - #14714
24.3.50; `isearch-filter-predicate(s)'

Previous Next

Full log

Message #8 received at 14714 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 14714 <at> debbugs.gnu.org
Subject: Re: bug#14714: 24.3.50; `isearch-filter-predicate(s)'
Date: Tue, 25 Jun 2013 14:46:49 -0400

> 1. `isearch-filter-predicates' should not be an _alias_ for
> `isearch-filter-predicate'.  The former cannot just replace the latter.

Actually, shouldn't we revert this change and use
(add-function :before-while ...) on isearch-filter-predicate instead?
Admittedly, currently nadvice.el does not give you access to the list of
functions so you can't directly do the equivalent of

		   (mapconcat (lambda (s)
				(and (symbolp s)
				     (get s 'isearch-message-prefix)))
			      (if (consp isearch-filter-predicates)
				  isearch-filter-predicates
				(list isearch-filter-predicates))
			      "")

but that could be remedied (even using an advice's property rather than
a symbol property on the function added as advice).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.