GNU bug report logs - #14712
24.3.50; `isearch-filter-visible' obsolescence

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#14712: closed (24.3.50; `isearch-filter-visible' obsolescence)
Date: Tue, 25 Jun 2013 18:32:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 25 Jun 2013 14:31:00 -0400
with message-id <jwvhagm59ib.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#14712: 24.3.50; `isearch-filter-visible' obsolescence
has caused the debbugs.gnu.org bug report #14712,
regarding 24.3.50; `isearch-filter-visible' obsolescence
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
14712: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14712
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; `isearch-filter-visible' obsolescence
Date: Tue, 25 Jun 2013 09:49:25 -0700 (PDT)

I use `isearch-filter-visible' in my code.  Recently, you have made it
obsolete.  The `make-obsolete' sexp is not helpful/accurate, AFAICT.  It
says only that `isearch-filter-visible' is replaced by
`isearch-invisible':

(make-obsolete 'isearch-filter-visible 'isearch-invisible "24.4")

That is definitely not true.  For one thing, the former is a function
and the latter is a variable.

The proper replacement is given in the source code:

(or (eq search-invisible t)
    (not (isearch-range-invisible beg end)))

It is that information that needs to be conveyed in the obsolescence
message.





In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-06-20 on ODIEONE
Bzr revision: 113100 eliz <at> gnu.org-20130620173624-w9v620tog4yacftk
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 CFLAGS=-O0 -g3 LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 14712-done <at> debbugs.gnu.org
Subject: Re: bug#14712: 24.3.50; `isearch-filter-visible' obsolescence
Date: Tue, 25 Jun 2013 14:31:00 -0400

tags 14712 notabug
thanks

> The proper replacement is given in the source code:

> (or (eq search-invisible t)
>     (not (isearch-range-invisible beg end)))

> It is that information that needs to be conveyed in the obsolescence
> message.

No, the obsolescence message only points to the other
variable/function/feature with which you can obtain similar results.
It's generally not a drop-in replacement.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.