From unknown Fri Aug 15 15:30:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14712 <14712@debbugs.gnu.org> To: bug#14712 <14712@debbugs.gnu.org> Subject: Status: 24.3.50; `isearch-filter-visible' obsolescence Reply-To: bug#14712 <14712@debbugs.gnu.org> Date: Fri, 15 Aug 2025 22:30:15 +0000 retitle 14712 24.3.50; `isearch-filter-visible' obsolescence reassign 14712 emacs submitter 14712 Drew Adams severity 14712 minor tag 14712 notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 12:49:42 2013 Received: (at submit) by debbugs.gnu.org; 25 Jun 2013 16:49:42 +0000 Received: from localhost ([127.0.0.1]:40743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrWR3-0001hl-O7 for submit@debbugs.gnu.org; Tue, 25 Jun 2013 12:49:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55336) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrWR1-0001hZ-La for submit@debbugs.gnu.org; Tue, 25 Jun 2013 12:49:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrWQv-0002xi-72 for submit@debbugs.gnu.org; Tue, 25 Jun 2013 12:49:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrWQv-0002xc-3c for submit@debbugs.gnu.org; Tue, 25 Jun 2013 12:49:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrWQt-0007Wx-PI for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 12:49:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrWQr-0002x5-9D for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 12:49:31 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:34014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrWQr-0002wy-22 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2013 12:49:29 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5PGh854021484 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 25 Jun 2013 16:43:09 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5PGnQHJ002747 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 25 Jun 2013 16:49:27 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5PGnQVr009678 for ; Tue, 25 Jun 2013 16:49:26 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 25 Jun 2013 09:49:25 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; `isearch-filter-visible' obsolescence X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) I use `isearch-filter-visible' in my code. Recently, you have made it obsolete. The `make-obsolete' sexp is not helpful/accurate, AFAICT. It says only that `isearch-filter-visible' is replaced by `isearch-invisible': (make-obsolete 'isearch-filter-visible 'isearch-invisible "24.4") That is definitely not true. For one thing, the former is a function and the latter is a variable. The proper replacement is given in the source code: (or (eq search-invisible t) (not (isearch-range-invisible beg end))) It is that information that needs to be conveyed in the obsolescence message. In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-06-20 on ODIEONE Bzr revision: 113100 eliz@gnu.org-20130620173624-w9v620tog4yacftk Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs CFLAGS=3D-O0 -g3 LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include' From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 14:31:04 2013 Received: (at control) by debbugs.gnu.org; 25 Jun 2013 18:31:05 +0000 Received: from localhost ([127.0.0.1]:40888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrY19-0005Df-PL for submit@debbugs.gnu.org; Tue, 25 Jun 2013 14:31:04 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:51058) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrY17-0005DB-TK; Tue, 25 Jun 2013 14:31:02 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r5PIV1Lh010124; Tue, 25 Jun 2013 14:31:01 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id D64C4B4178; Tue, 25 Jun 2013 14:31:00 -0400 (EDT) From: Stefan Monnier To: Drew Adams Subject: Re: bug#14712: 24.3.50; `isearch-filter-visible' obsolescence Message-ID: References: Date: Tue, 25 Jun 2013 14:31:00 -0400 In-Reply-To: (Drew Adams's message of "Tue, 25 Jun 2013 09:49:25 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4620=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4620> : streams <988841> : uri <1458351> X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control Cc: 14712-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) tags 14712 notabug thanks > The proper replacement is given in the source code: > (or (eq search-invisible t) > (not (isearch-range-invisible beg end))) > It is that information that needs to be conveyed in the obsolescence > message. No, the obsolescence message only points to the other variable/function/feature with which you can obtain similar results. It's generally not a drop-in replacement. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 14:48:49 2013 Received: (at 14712-done) by debbugs.gnu.org; 25 Jun 2013 18:48:49 +0000 Received: from localhost ([127.0.0.1]:40930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrYIK-0006q7-H1 for submit@debbugs.gnu.org; Tue, 25 Jun 2013 14:48:48 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:23439) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrYII-0006pq-2y for 14712-done@debbugs.gnu.org; Tue, 25 Jun 2013 14:48:46 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5PIgKfA027652 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Jun 2013 18:42:21 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5PImbhX013481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 25 Jun 2013 18:48:38 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by userz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5PImbNx019799; Tue, 25 Jun 2013 18:48:37 GMT MIME-Version: 1.0 Message-ID: <64023c36-7905-47f4-8dc8-fe73d713034a@default> Date: Tue, 25 Jun 2013 11:48:36 -0700 (PDT) From: Drew Adams To: Stefan Monnier Subject: RE: bug#14712: 24.3.50; `isearch-filter-visible' obsolescence References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 14712-done Cc: 14712-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > > The proper replacement is given in the source code: >=20 > > (or (eq search-invisible t) > > (not (isearch-range-invisible beg end))) >=20 > > It is that information that needs to be conveyed in the obsolescence > > message. >=20 > No, the obsolescence message only points to the other > variable/function/feature with which you can obtain similar results. > It's generally not a drop-in replacement. No. There is a bug here - perhaps two. Either (a) the message produced, itself, is incorrect/misleading (I don't h= ave the message in hand), because it tells you to simply "replace" the one = by the other, or (b) the doc string of `make-obsolete' is wrong, because it= says that: "The warning will say that CURRENT-NAME should be used instead." It is not a simple case of using CURRENT-NAME instead of the obsolete name.= This doc string says in effect that this obsolescence operation is simply= a renaming (use this name instead of that name), but it is not. Extremely misleading at the very least. And outright incorrect, by any rea= sonable reading. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 20:14:53 2013 Received: (at 14712-done) by debbugs.gnu.org; 26 Jun 2013 00:14:54 +0000 Received: from localhost ([127.0.0.1]:41332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrdNt-0007ZS-5A for submit@debbugs.gnu.org; Tue, 25 Jun 2013 20:14:53 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:43649) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UrdNs-0007ZD-2r for 14712-done@debbugs.gnu.org; Tue, 25 Jun 2013 20:14:52 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJLEfkA6RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFFMCppA/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJLEfkA6RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="17168570" Received: from 76-10-154-64.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.64]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 25 Jun 2013 20:14:40 -0400 Received: by pastel.home (Postfix, from userid 20848) id DDDC0678F1; Tue, 25 Jun 2013 20:14:40 -0400 (EDT) From: Stefan Monnier To: Drew Adams Subject: Re: bug#14712: 24.3.50; `isearch-filter-visible' obsolescence Message-ID: References: <64023c36-7905-47f4-8dc8-fe73d713034a@default> Date: Tue, 25 Jun 2013 20:14:40 -0400 In-Reply-To: <64023c36-7905-47f4-8dc8-fe73d713034a@default> (Drew Adams's message of "Tue, 25 Jun 2013 11:48:36 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 14712-done Cc: 14712-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > "The warning will say that CURRENT-NAME should be used instead." "use dynamite instead of a fishing rod" does not mean that you can just replace your fishing rod with a stick of dynamite and do everything else as before. If it says "use foo, instead", it's pretty clear that you may need to adjust a few other things accordingly. Stefan From unknown Fri Aug 15 15:30:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 24 Jul 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator