GNU bug report logs - #14687
24.3.50; Minor problem in files.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14687 in the body.
You can then email your comments to 14687 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xue Fuqiao <xfq.free <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50; Minor problem in files.el
Date: Sat, 22 Jun 2013 11:11:17 +0800

severity minor

In files.el:
  (defcustom version-control nil
  [...]
  :group 'backup
  :group 'vc)

I don't think this variable is related to VC, so can the last `:group'
keyword be deleted?

In GNU Emacs 24.3.50.1 (x86_64-apple-darwin12.4.0, NS apple-appkit-1187.39)
 of 2013-06-22 on xfq.local
Bzr revision: 113128 dgutov <at> yandex.ru-20130621230749-qfs0a7kd6vc7338i
Configured using:
 `configure --with-ns --enable-gtk-deprecation-warnings
 --enable-checking'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

--
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/

Message #10 received at 14687 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Xue Fuqiao <xfq.free <at> gmail.com>
Cc: 14687 <at> debbugs.gnu.org
Subject: Re: bug#14687: 24.3.50; Minor problem in files.el
Date: Sat, 22 Jun 2013 16:16:03 -0400

>   :group 'vc)
>
> I don't think this variable is related to VC, so can the last `:group'
> keyword be deleted?

Fine by me.

(Could you use more descriptive subjects for your future bug reports?
Eg "incorrect custom group for version-control option".)

Message #13 received at 14687 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Glenn Morris <rgm <at> gnu.org>
Cc: Xue Fuqiao <xfq.free <at> gmail.com>, 14687 <at> debbugs.gnu.org
Subject: Re: bug#14687: 24.3.50; Minor problem in files.el
Date: Fri, 05 Aug 2016 20:28:17 -0400

tags 14687 fixed
close 14687 25.2
quit

Glenn Morris <rgm <at> gnu.org> writes:

>>   :group 'vc)
>>
>> I don't think this variable is related to VC, so can the last `:group'
>> keyword be deleted?
>
> Fine by me.

git show gnu/master
commit f50e641548672b3332d8dcbc705d7fe3962c7bb2
Author: Noam Postavsky <npostavs <at> gmail.com>
Date:   Fri Aug 5 20:04:17 2016 -0400

    * lisp/files.el (version-control): Drop :group vc (Bug #14687)

diff --git a/lisp/files.el b/lisp/files.el
index 55a7afe..4d27ef1 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -277,8 +277,7 @@ version-control
   :type '(choice (const :tag "Never" never)
 		 (const :tag "If existing" nil)
 		 (other :tag "Always" t))
-  :group 'backup
-  :group 'vc)
+  :group 'backup)
 (put 'version-control 'safe-local-variable
      (lambda (x) (or (booleanp x) (equal x 'never))))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.