From unknown Fri Jun 13 10:38:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2013 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 14676@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: michael_heerdegen@web.de Received: via spool by submit@debbugs.gnu.org id=B.137175181023989 (code B ref -1); Thu, 20 Jun 2013 18:11:01 +0000 Received: (at submit) by debbugs.gnu.org; 20 Jun 2013 18:10:10 +0000 Received: from localhost ([127.0.0.1]:59055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UpjJB-0006Em-6F for submit@debbugs.gnu.org; Thu, 20 Jun 2013 14:10:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37248) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UpjJ6-0006EB-SR for submit@debbugs.gnu.org; Thu, 20 Jun 2013 14:10:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpjJ0-0002Sc-Ft for submit@debbugs.gnu.org; Thu, 20 Jun 2013 14:09:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpjJ0-0002SY-Cj for submit@debbugs.gnu.org; Thu, 20 Jun 2013 14:09:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpjIz-0001Vq-AA for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2013 14:09:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpjIy-0002S7-8o for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2013 14:09:57 -0400 Received: from mout.web.de ([212.227.15.4]:61359) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpjIy-0002Rw-0A for bug-gnu-emacs@gnu.org; Thu, 20 Jun 2013 14:09:56 -0400 Received: from drachen.dragon ([2.201.137.250]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0Lir9R-1UJhLL0NTh-00cvtf for ; Thu, 20 Jun 2013 20:09:54 +0200 From: Michael Heerdegen Date: Thu, 20 Jun 2013 20:09:21 +0200 Message-ID: <87k3lo4pta.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:xOK43UwMLxj5BEVefF6UjPT75k1jst5kgUwt3ZOVouhhCZ0LNN/ qZ8n8NfuFr9SoJ3N52BFtty3L7OSNRkYH53C5dNZnHWsdAcpVEHLWqz9UM95pua4XXUpgp5 D+8NsK2lsyvge3wB6qJ9P7ahlw1A9AhiQzo+zIMVXdSbdqwadDZWcxij4weN0XjMSGcNvaa ttcA0N5qypBuEYboqOwyw== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello, I have `winner-mode' turned on. >From e.g. an image viewer I want to open a dired buffer for the directory containing the images. So, from the image viewer, I run emacsclient file and in Emacs, I immediately hit C-^ (which I bound to `dired-jump') in the popped up window, to get the parent dir. The problem: the buffer showing the file was not recorded in the winner history - `winner-undo' can't get it. Note: this only happens if I hit C-^ immediately after opening the file. Else, you trigger `post-command-hook' which DTRT. Evaluating (add-hook 'server-switch-hook 'winner-save-old-configurations) fixes the problem for me. Should we do something like that in the definition of `winner-mode'? Regards, Michael. In GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.8.2) of 2013-06-18 on dex, modified by Debian (emacs-snapshot package, version 2:20130618-1) Windowing system distributor `The X.Org Foundation', version 11.0.11204000 System Description: Debian GNU/Linux testing (jessie) Configured using: `configure --build x86_64-linux-gnu --host x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.3.50/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3.50/site-lisp:/usr/share/emacs/site-lisp --without-compress-info --with-crt-dir=/usr/lib/x86_64-linux-gnu/ --with-x=yes --with-x-toolkit=gtk3 --with-imagemagick=yes CFLAGS='-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' CPPFLAGS='-D_FORTIFY_SOURCE=2' LDFLAGS='-g -Wl,--as-needed -znocombreloc'' From unknown Fri Jun 13 10:38:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2013 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: 14676@debbugs.gnu.org Received: via spool by 14676-submit@debbugs.gnu.org id=B14676.13717603287676 (code B ref 14676); Thu, 20 Jun 2013 20:33:02 +0000 Received: (at 14676) by debbugs.gnu.org; 20 Jun 2013 20:32:08 +0000 Received: from localhost ([127.0.0.1]:59271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UplWZ-0001zj-K0 for submit@debbugs.gnu.org; Thu, 20 Jun 2013 16:32:08 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:11980) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UplWX-0001z7-Ce for 14676@debbugs.gnu.org; Thu, 20 Jun 2013 16:32:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: At8KABK/CFFFpZVy/2dsb2JhbABEuzWCWAQCexdzgh8BBVYjEAs0EhQYDSQuh3bBLZEKA59lAoUTgV6DEw X-IPAS-Result: At8KABK/CFFFpZVy/2dsb2JhbABEuzWCWAQCexdzgh8BBVYjEAs0EhQYDSQuh3bBLZEKA59lAoUTgV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="16827262" Received: from 69-165-149-114.dsl.teksavvy.com (HELO pastel.home) ([69.165.149.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Jun 2013 16:31:54 -0400 Received: by pastel.home (Postfix, from userid 20848) id 0B353630ED; Thu, 20 Jun 2013 16:31:59 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87k3lo4pta.fsf@web.de> Date: Thu, 20 Jun 2013 16:31:58 -0400 In-Reply-To: <87k3lo4pta.fsf@web.de> (Michael Heerdegen's message of "Thu, 20 Jun 2013 20:09:21 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > (add-hook 'server-switch-hook 'winner-save-old-configurations) > fixes the problem for me. Should we do something like that in the > definition of `winner-mode'? I don't much like this solution. Stefan From unknown Fri Jun 13 10:38:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2013 21:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: 14676@debbugs.gnu.org Received: via spool by 14676-submit@debbugs.gnu.org id=B14676.137176206010893 (code B ref 14676); Thu, 20 Jun 2013 21:01:02 +0000 Received: (at 14676) by debbugs.gnu.org; 20 Jun 2013 21:01:00 +0000 Received: from localhost ([127.0.0.1]:59328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UplyU-0002pa-9g for submit@debbugs.gnu.org; Thu, 20 Jun 2013 17:00:58 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:10381) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UplyP-0002pL-7t for 14676@debbugs.gnu.org; Thu, 20 Jun 2013 17:00:54 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZVy/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSQuh3bBLZEKA59lAoUTgV6DEw X-IPAS-Result: Av8EABK/CFFFpZVy/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSQuh3bBLZEKA59lAoUTgV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="16829167" Received: from 69-165-149-114.dsl.teksavvy.com (HELO pastel.home) ([69.165.149.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Jun 2013 17:00:42 -0400 Received: by pastel.home (Postfix, from userid 20848) id 17586630ED; Thu, 20 Jun 2013 17:00:47 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87k3lo4pta.fsf@web.de> Date: Thu, 20 Jun 2013 17:00:47 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 20 Jun 2013 16:31:58 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> (add-hook 'server-switch-hook 'winner-save-old-configurations) >> fixes the problem for me. Should we do something like that in the >> definition of `winner-mode'? > I don't much like this solution. I think the better solution is to move the (run-hooks 'post-command-hook) in server.el. Currently it's run at the end of server-visit-files which I think is simply too early. It should be run at the end of server-execute instead. And that should fix your problem as well since winner-mode hooks itself on post-command-hook. Stefan From unknown Fri Jun 13 10:38:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Jun 2013 21:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 14676@debbugs.gnu.org Received: via spool by 14676-submit@debbugs.gnu.org id=B14676.137176528316585 (code B ref 14676); Thu, 20 Jun 2013 21:55:02 +0000 Received: (at 14676) by debbugs.gnu.org; 20 Jun 2013 21:54:43 +0000 Received: from localhost ([127.0.0.1]:59398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UpmoV-0004JQ-Da for submit@debbugs.gnu.org; Thu, 20 Jun 2013 17:54:43 -0400 Received: from mout.web.de ([212.227.15.4]:60176) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UpmoS-0004JC-Rk for 14676@debbugs.gnu.org; Thu, 20 Jun 2013 17:54:41 -0400 Received: from drachen.dragon ([90.186.122.149]) by smtp.web.de (mrweb003) with ESMTPSA (Nemesis) id 0MAMkU-1V0Bsj2WiI-00BZbr; Thu, 20 Jun 2013 23:54:32 +0200 From: Michael Heerdegen References: <87k3lo4pta.fsf@web.de> Date: Thu, 20 Jun 2013 23:54:25 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 20 Jun 2013 17:00:47 -0400") Message-ID: <871u7we9da.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:+rPWo89J5bvbOr1aj4oNOuggomq7Lw5sLHHb5Ia/dMdsKGb/UmV u6bQqDnKcvwr3Ak0f2rpUS9yXR4U8RfDi8d+B0BRGKasIJMzNj+r3S9P9nzLDGsaF6/IRVw PCFvPg9UEwQt2iA9dtnHA7MKltEPAQ2qdc4hdBALVrxWugJVGzp7kTXGVpQWIOPDaRpGYJi no5EG4onpyLKmEH52uTwQ== X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Stefan Monnier writes: > >> (add-hook 'server-switch-hook 'winner-save-old-configurations) > >> fixes the problem for me. Should we do something like that in the > >> definition of `winner-mode'? > > I don't much like this solution. > > I think the better solution is to move the (run-hooks > 'post-command-hook) in server.el. Currently it's run at the end of > server-visit-files which I think is simply too early. It should be run > at the end of server-execute instead. And that should fix your problem > as well since winner-mode hooks itself on post-command-hook. That sounds reasonable. I tested your approach quickly, and it worked. Michael. From unknown Fri Jun 13 10:38:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jun 2013 14:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: 14676@debbugs.gnu.org Received: via spool by 14676-submit@debbugs.gnu.org id=B14676.137182553922126 (code B ref 14676); Fri, 21 Jun 2013 14:39:02 +0000 Received: (at 14676) by debbugs.gnu.org; 21 Jun 2013 14:38:59 +0000 Received: from localhost ([127.0.0.1]:32855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uq2UN-0005ko-Ap for submit@debbugs.gnu.org; Fri, 21 Jun 2013 10:38:59 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:36901) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uq2UK-0005ka-7H for 14676@debbugs.gnu.org; Fri, 21 Jun 2013 10:38:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZVy/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA59lAoUTgV6DEw X-IPAS-Result: Av8EABK/CFFFpZVy/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA59lAoUTgV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="16874010" Received: from 69-165-149-114.dsl.teksavvy.com (HELO pastel.home) ([69.165.149.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 21 Jun 2013 10:38:45 -0400 Received: by pastel.home (Postfix, from userid 20848) id 30DC262CFF; Fri, 21 Jun 2013 10:38:50 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87k3lo4pta.fsf@web.de> <871u7we9da.fsf@web.de> Date: Fri, 21 Jun 2013 10:38:50 -0400 In-Reply-To: <871u7we9da.fsf@web.de> (Michael Heerdegen's message of "Thu, 20 Jun 2013 23:54:25 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > That sounds reasonable. I tested your approach quickly, and it worked. Can you show me the patch you tested? Stefan From unknown Fri Jun 13 10:38:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2013 22:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 14676@debbugs.gnu.org Received: via spool by 14676-submit@debbugs.gnu.org id=B14676.137194107227021 (code B ref 14676); Sat, 22 Jun 2013 22:45:01 +0000 Received: (at 14676) by debbugs.gnu.org; 22 Jun 2013 22:44:32 +0000 Received: from localhost ([127.0.0.1]:35317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UqWXn-00071k-OA for submit@debbugs.gnu.org; Sat, 22 Jun 2013 18:44:32 -0400 Received: from mout.web.de ([212.227.15.3]:61603) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UqWXj-00071R-SQ for 14676@debbugs.gnu.org; Sat, 22 Jun 2013 18:44:29 -0400 Received: from drachen.dragon ([90.186.79.33]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0Ls91n-1U9WPd2Eut-013xg4; Sun, 23 Jun 2013 00:44:19 +0200 From: Michael Heerdegen References: <87k3lo4pta.fsf@web.de> <871u7we9da.fsf@web.de> Date: Sun, 23 Jun 2013 00:44:13 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 21 Jun 2013 10:38:50 -0400") Message-ID: <87ehbtojeq.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:4TRNg1oovWxPoDppURHw8Un6HPrMqFTLNcuuj+HSEkHB3p22okT EIJAJuxqZ/DQtKarM5jFWzeLNtl8RnnJ2ogFApGHKe2OReZ5eIte5lV0Kx3zkua9hTN9+Q+ 2A1YQU2QrPkIbOIsImxM+mhqctVB6nJ1xQe64tHiEsiAOll4N6aVHLInlVx/IXrUnE9+Jkl xZRTbcPZKjW0lLikmnpDg== X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) --=-=-= Content-Type: text/plain Stefan Monnier writes: > Can you show me the patch you tested? I tested this: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=server.patch *** /home/micha/today/server.el 2013-06-23 00:21:58.737341216 +0200 --- /home/micha/today/server-new.el 2013-06-23 00:27:31.470493560 +0200 *************** *** 1292,1298 **** (message "%s" (substitute-command-keys "When done with a buffer, type \\[server-edit]"))))) (when (and frame (null tty-name)) ! (server-unselect-display frame))) ((quit error) (when (eq (car err) 'quit) (message "Quit emacsclient request")) --- 1292,1299 ---- (message "%s" (substitute-command-keys "When done with a buffer, type \\[server-edit]"))))) (when (and frame (null tty-name)) ! (server-unselect-display frame)) ! (run-hooks 'post-command-hook)) ((quit error) (when (eq (car err) 'quit) (message "Quit emacsclient request")) *************** *** 1360,1368 **** (unless server-buffer-clients (setq server-existing-buffer t))) (server-goto-line-column (cdr file)) ! (run-hooks 'server-visit-hook) ! ;; hooks may be specific to current buffer: ! (run-hooks 'post-command-hook)) (unless nowait ;; When the buffer is killed, inform the clients. (add-hook 'kill-buffer-hook 'server-kill-buffer nil t) --- 1361,1367 ---- (unless server-buffer-clients (setq server-existing-buffer t))) (server-goto-line-column (cdr file)) ! (run-hooks 'server-visit-hook)) (unless nowait ;; When the buffer is killed, inform the clients. (add-hook 'kill-buffer-hook 'server-kill-buffer nil t) --=-=-= Content-Type: text/plain Note that I don't know anything about server.el, I just did what you proposed. Anyway, it fixes the problem - with my setup as well as for -Q. BTW, I didn't know what was meant with this comment: | ;; hooks may be specific to current buffer: so I just removed it. Michael. --=-=-=-- From unknown Fri Jun 13 10:38:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Sep 2020 13:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: 14676@debbugs.gnu.org, Stefan Monnier Received: via spool by 14676-submit@debbugs.gnu.org id=B14676.159965888114908 (code B ref 14676); Wed, 09 Sep 2020 13:42:01 +0000 Received: (at 14676) by debbugs.gnu.org; 9 Sep 2020 13:41:21 +0000 Received: from localhost ([127.0.0.1]:57969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG0Lg-0003sO-SA for submit@debbugs.gnu.org; Wed, 09 Sep 2020 09:41:21 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kG0Ld-0003sA-SO for 14676@debbugs.gnu.org; Wed, 09 Sep 2020 09:41:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mn1xyi9pCxdB8DSp7btg31x5OUchTkN2fa+d8Kvlm7g=; b=NLcbNxcKMOISpL+rKPzBk5Tvww 3k9KEixz0mXUuLOkGZdzo35mm0zP7DA28m3M1ETA9m9NK2G+UWDaL7L0DthG+xABisw2VHhw3hOhH KDfBpy87Bg41n5LJvdPTtS1noQIsj4/K69AXJfjPgDxNPIg7s/AA+TkZ67NK+jJTzBDk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG0LT-00034q-C6; Wed, 09 Sep 2020 15:41:10 +0200 From: Lars Ingebrigtsen References: <87k3lo4pta.fsf@web.de> <871u7we9da.fsf@web.de> <87ehbtojeq.fsf@web.de> X-Now-Playing: Drew Daniel, John Wiese's _Continuous Hole_: "Sleek Disorder" Date: Wed, 09 Sep 2020 15:41:06 +0200 In-Reply-To: <87ehbtojeq.fsf@web.de> (Michael Heerdegen's message of "Sun, 23 Jun 2013 00:44:13 +0200") Message-ID: <878sdj9ifh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen writes: >> Can you show me the patch you tested? > > I tested this: This was the final message in this seven year old thread. Miraculously, the patch still applies: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: >> Can you show me the patch you tested? > > I tested this: This was the final message in this seven year old thread. Miraculously, the patch still applies: > (message "%s" (substitute-command-keys > "When done with a buffer, type \\[server-edit]"))))) > (when (and frame (null tty-name)) > ! (server-unselect-display frame))) > ((quit error) > (when (eq (car err) 'quit) > (message "Quit emacsclient request")) > --- 1292,1299 ---- > (message "%s" (substitute-command-keys > "When done with a buffer, type \\[server-edit]"))))) > (when (and frame (null tty-name)) > ! (server-unselect-display frame)) > ! (run-hooks 'post-command-hook)) > ((quit error) > (when (eq (car err) 'quit) > (message "Quit emacsclient request")) [...] > Note that I don't know anything about server.el, I just did what you > proposed. > > Anyway, it fixes the problem - with my setup as well as for -Q. I'm not very familiar with server.el myself... this just changes it to run post-command-hook slightly later? I guess that could have unforeseen consequences, but if it fixes this bug, then perhaps we should give it a go? Or did the problem fix itself through other means over the years? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Jun 13 10:38:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Sep 2020 23:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 14676@debbugs.gnu.org, Stefan Monnier Received: via spool by 14676-submit@debbugs.gnu.org id=B14676.160029990329311 (code B ref 14676); Wed, 16 Sep 2020 23:46:02 +0000 Received: (at 14676) by debbugs.gnu.org; 16 Sep 2020 23:45:03 +0000 Received: from localhost ([127.0.0.1]:36895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIh6k-0007cg-UV for submit@debbugs.gnu.org; Wed, 16 Sep 2020 19:45:03 -0400 Received: from mout.web.de ([212.227.15.4]:46657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIh6i-0007bu-Ms for 14676@debbugs.gnu.org; Wed, 16 Sep 2020 19:45:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1600299890; bh=4oMCnJlQs6emLEWK8yGxVzNtx08KHaABxtASMXDdFHE=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=B1PUk18YKs6dLl7LFRjjoCRILahgq232i/jM4tinh81j7GPD5jd2lE2lr5+eQaJjF ZQ4PAZlL7VcCxYsNL+gN6+/yci3MhQrTc1HDWVEycPZfNmnuG3qlzqu5kacpw56rm0 dhan7ROfqsjAC+0mrtKInfb1TzjK0jlzOppYY+xk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.220.78]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MQvxm-1jv5fo2D1C-00UMwI; Thu, 17 Sep 2020 01:44:50 +0200 From: Michael Heerdegen References: <87k3lo4pta.fsf@web.de> <871u7we9da.fsf@web.de> <87ehbtojeq.fsf@web.de> <878sdj9ifh.fsf@gnus.org> Date: Thu, 17 Sep 2020 01:44:49 +0200 In-Reply-To: <878sdj9ifh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 09 Sep 2020 15:41:06 +0200") Message-ID: <87a6xpffri.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:PMPqaWi4epe+9tMVx3bTeHjDIu0xuUVYBytTac/bJ2i/G+qr8bX kdl2J9UtmCkMx3r2NupKowsdhntvL2zm7+evdcsgO48q47zCecRx+HwaVjGfyCTnPGwZPsg x1zd9bxybdX06SVXJuNFDJigb747KK1bowgvFBsg8uhN6b/AJWHyKNQpLCIBjbFK/esJGE/ Nsw887Fse2UHBP+e15I2Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/FmpqtXe3FU=:UEmLobSc1So0u2VX1aWCy5 a7mpqx6skVSY+9Sao4KCbN7XwzIUuP7SjwMLX/ABU3eudL8k3+l4/w0ZJxIP9G2b//Cg59WFG 6qy6n8s/2Q36W47fWe/kKl6KCqHcdzXjOzEp4tB4ELzPh4O1PbJGKsE1oXHEVV9d/0UNBGdto 44Xr1YNYN8szSnzbX1tUoEEFQzYFpHFzcVVKQLigaHuyjaisyfb+m1Me+b8lCDK0EsW/WkakR mtzyAR0WNoQUzt4sycW8BDXCDdaDojTMwEL+lSeZl+M0WTQ+HLtKgiSXarfxkIASbn1gdWDIc oUfAcCe/tfBkaGRd8t9Zxx+HBwImAnf3FXyHZu2rwW8uRum78vDYVvR74f9Q0urjkbmIFijJD IWUJPrVWDCi7yQ9QohL67Z/8t8dzCvBRYJhkePGM3x47ABx3rtkg/JES2hxWYk6Eqcp3D6ALC lNDxtzsDs5jTSqRFIT4iTYwiqqJbOFAEXm3U1DkA+X8ArDXBS18Mx0WySvtreSAT2rjAwupid 1YHc2LfhJBrQwrwUnjG7atVhDy5zAgF+a5ffhV4z6o6pvgFVru5Gy76jVFW/3sEC0Gn9iWPCW E/kxqOpG554yfjwshRCsAcpOzWWrf+W59NP7ysPsFwtBVrf8gnw5i4VWxutM3j6jGFolyu3Nf 7kier6xcVKYighuPLArbwe2//PR76H+BnBp9J8MyViRlw4eVKLUK+l83vd2SdI7Ivuy+E4Lqz pZbvtFyEA3NL0AYyhGVxx7gQCVKSVB4Oq3mPMaMylB76+0gg3Pe/zjKgGFiowT51w6nsJIWZZ RE9EI9WNRa+4+RE0U2AnZK0BVSec+4TkFpIt+LRgqa5shER7u92RCWKevHYQwguwDGKFEPHJU rffaFexitcz5D22O166jffkPOhnZbDk1aEBU3pu4wG2C0z2Lack4aGTJYE6GjXIgx/b3uTiRY C0p1KLDCnF/4VLOpIlxxG5Bd7CNr/QY4C5JIDWKpw4c0eBexSnaJLiMsBdQBnQwcpBqVwibv2 TbGeLPCh9oe7JBtK7BVzlIJ8L9/Q8z1Shr8RGsRA3PXsJrtJBYDr8xu/HkwHeOZnkeujUiOH4 xlbhpDzHE7m/CKuOXUiA/69DO1MH8EmlUM/0cCV1V1dKdUhWOqhS/NHeR+P+2WOQ8hzfXV7+4 bJhEvEoc970CG4wSmbSoArGG9CiJ/opPXgu89F4eU4oJBQ9DpvENhmRUfaDLPappaWsBo58Fr w7Xku9lpltDctTu51Co1n5AT9RkhFz3kF8VVTPg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > Or did the problem fix itself through other means over the years? No, it didn't. The "patch" is just the change Stefan suggested, done in a more or less random way AFAIR, since I don't know server.el, too. I would still give it a try. But AFAIU the change I had posted and you quoted doesn't fulfill what the current code says, namely that `post-command-hook' should be run in each buffer individually. Maybe that's the reason why Stefan had ignored it ;-) Michael. From unknown Fri Jun 13 10:38:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14676: 24.3.50; winner doesn't immediately notice windows created by server Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 03:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: Lars Ingebrigtsen , 14676@debbugs.gnu.org Received: via spool by 14676-submit@debbugs.gnu.org id=B14676.160031278517091 (code B ref 14676); Thu, 17 Sep 2020 03:20:02 +0000 Received: (at 14676) by debbugs.gnu.org; 17 Sep 2020 03:19:45 +0000 Received: from localhost ([127.0.0.1]:37001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIkSX-0004Rb-H8 for submit@debbugs.gnu.org; Wed, 16 Sep 2020 23:19:45 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIkSV-0004RL-LW for 14676@debbugs.gnu.org; Wed, 16 Sep 2020 23:19:44 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1B71910025B; Wed, 16 Sep 2020 23:19:38 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 79080100234; Wed, 16 Sep 2020 23:19:29 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600312769; bh=rGDJiLYniB6ZC90F9o3LVxX6msjcns6kVK2gv3BNz1E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WFLWOm21OE1vExhar/Y+KZZkrbQUkEs1FDuO2ImFLe1DeBMmoHS+A4u1y7Xl0/z9K Lmcj801FJYVPT1h/2aAWhPQHhMgIbeAEb21QK6qhEqHw4n2aW9YyiACo+eufa/Eifw jq4escGa6pgkhx7utYzTBUfb6W9jZq19cg037b92trh16mGrSRuT2c/iZJ8ZxNnmYM zCKVyJ+MPk6QP9Y9mMzZKlkGgv8INCRi9YBoxj3RI2gJogAGxyOLsnw8dVa5HzlSlU /GzRri//hCkymBaBs12JZynm/9yftmZbpCO4O5Es9mJtL6p6jWJI01+43tCAbR/h3b p6G0ul+VSFPDA== Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2DBD31202F3; Wed, 16 Sep 2020 23:19:29 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87k3lo4pta.fsf@web.de> <871u7we9da.fsf@web.de> <87ehbtojeq.fsf@web.de> <878sdj9ifh.fsf@gnus.org> <87a6xpffri.fsf@web.de> Date: Wed, 16 Sep 2020 23:19:28 -0400 In-Reply-To: <87a6xpffri.fsf@web.de> (Michael Heerdegen's message of "Thu, 17 Sep 2020 01:44:49 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Or did the problem fix itself through other means over the years? > No, it didn't. > The "patch" is just the change Stefan suggested, done in a more or less > random way AFAIR, since I don't know server.el, too. I would still give > it a try. But AFAIU the change I had posted and you quoted doesn't > fulfill what the current code says, namely that `post-command-hook' > should be run in each buffer individually. Maybe that's the reason why > Stefan had ignored it ;-) BTW, runnning `post-command-hook` in there is arguably wrong (we didn't technically run a command, or at least we didn't go through the usual "protocol" of running a command, so some `post-command-hook` functions may misbehave, e.g. because of interaction with things like `this-command` or `last-command`). Maybe the right way to fix this is to try and make `server.el` simulate more carefully a command-loop running a command. Or even *really* make it run a command. E.g. instead of having `server.el` immediately run within the process filter the code requested by the client, it could just push some ad-hoc event onto `unread-command-events` which is then bound to a command. Stefan