GNU bug report logs - #14670
Highlight visited links

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Highlight visited links
Date: Thu, 20 Jun 2013 01:28:48 +0300

Severity: wishlist
Tags: patch

Visiting a URL link from Info doesn't highlight it as visited.

I'm afraid that adding a visited URL to the existing variable
`Info-history' might break other functions that expect it containing
only visited Info nodes in the format `(FILENAME NODENAME BUFFERPOS)'.
So I created a new variable `Info-url-history':

=== modified file 'lisp/info.el'
--- lisp/info.el	2013-06-17 23:57:07 +0000
+++ lisp/info.el	2013-06-19 22:28:22 +0000
@@ -50,6 +50,9 @@ (defvar Info-history-list nil
   "List of all Info nodes user has visited.
 Each element of the list is a list (FILENAME NODENAME).")
 
+(defvar Info-url-history nil
+  "List of all URLs user has visited.")
+
 (defcustom Info-history-skip-intermediate-nodes t
   "Non-nil means don't record intermediate Info nodes to the history.
 Intermediate Info nodes are nodes visited by Info internally in the process of
@@ -3882,6 +3885,9 @@ (defun Info-try-follow-nearest-node (&op
     (cond
      ((setq node (Info-get-token (point) "[hf]t?tps?://"
 				 "\\([hf]t?tps?://[^ \t\n\"`({<>})']+\\)"))
+      (when Info-fontify-visited-nodes
+	(setq Info-url-history (cons node (remove node Info-url-history)))
+	(Info-fontify-node))
       (browse-url node)
       (setq node t))
      ((setq node (Info-get-token (point) "\\*note[ \n\t]+"
@@ -4972,11 +4978,16 @@ (defun Info-fontify-node ()
 
       ;; Fontify http and ftp references
       (goto-char (point-min))
-      (when not-fontified-p
+      (when (or not-fontified-p fontify-visited-p)
         (while (re-search-forward "\\(https?\\|ftp\\)://[^ \t\n\"`({<>})']+"
                                   nil t)
           (add-text-properties (match-beginning 0) (match-end 0)
-                               '(font-lock-face info-xref
+                               `(font-lock-face
+				 ,(if (and Info-fontify-visited-nodes
+					   (member (buffer-substring-no-properties
+						    (match-beginning 0) (match-end 0))
+						   Info-url-history))
+				      'info-xref-visited 'info-xref)
                                  mouse-face highlight
                                  help-echo "mouse-2: go to this URL"))))
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.