GNU bug report logs - #14655
24.3; (looking-at comment-start-skip) in newcomment.el

Previous Next

Full log

View this message in rfc822 format

From: Thorsten Jolitz <tjolitz <at> googlemail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 14655 <at> debbugs.gnu.org
Subject: bug#14655: 24.3; (looking-at comment-start-skip) in newcomment.el
Date: Tue, 18 Jun 2013 20:37:34 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

>> From the commentary of newcomment.el:
>> 
>> ;; Prior to calling any `comment-*' function, you should ensure that
>> ;; `comment-normalize-vars' is first called to set up the appropriate
>> ;; variables; except for the `comment-*' commands, which call
>> ;; `comment-normalize-vars' automatically as a subroutine.
>
> Yes.  I'm not sure what the "solution" is, but this seems to be a
> common gotcha.  Yes, someone coding with functions from the library
> should presumably read the file Commentary.  Still, we can perhaps do
> better, to try to get this info across.
>
> Mentioning it in doc string might help.  But perhaps there is a better
> idea.

I find it a bit strange that the library itself does not check the
variables before acting on them. Would something like this be too much
effort or too costly?

,-----------------------------------
| (if comment-start-skip
|    (looking-at comment-start-skip)
|   (comment-normalize-vars)
|   (looking-at comment-start-skip))
`-----------------------------------

Why pass the burden to the users, that then frequently pass it back to
the maintainers because they did not read the docstring. 

-- 
cheers,
Thorsten

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.