From unknown Tue Jun 17 20:21:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14645 <14645@debbugs.gnu.org> To: bug#14645 <14645@debbugs.gnu.org> Subject: Status: Keep highlighting face foreground Reply-To: bug#14645 <14645@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:21:19 +0000 retitle 14645 Keep highlighting face foreground reassign 14645 emacs submitter 14645 Juri Linkov severity 14645 wishlist tag 14645 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 17 19:07:31 2013 Received: (at submit) by debbugs.gnu.org; 17 Jun 2013 23:07:31 +0000 Received: from localhost ([127.0.0.1]:51604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UoiWI-0004MM-Sn for submit@debbugs.gnu.org; Mon, 17 Jun 2013 19:07:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37107) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UoiWH-0004M9-8d for submit@debbugs.gnu.org; Mon, 17 Jun 2013 19:07:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoiWB-0008G8-E2 for submit@debbugs.gnu.org; Mon, 17 Jun 2013 19:07:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:56751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoiWB-0008G4-B5 for submit@debbugs.gnu.org; Mon, 17 Jun 2013 19:07:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoiWA-0007hU-8i for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2013 19:07:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoiW9-0008Ff-AM for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2013 19:07:22 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:34105 helo=ps18281.dreamhostps.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoiW9-0008FT-5D for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2013 19:07:21 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 4E328258B9E915 for ; Mon, 17 Jun 2013 16:07:19 -0700 (PDT) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Keep highlighting face foreground Organization: JURTA Date: Tue, 18 Jun 2013 01:55:12 +0300 Message-ID: <87ehc0mjhy.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Now that we have a new function `add-face-text-property' it would be very useful for features that add faces with a different background to highlight matches. For instance, `occur' uses `add-text-properties' to add the `match' face, but currently it removes foreground colors from the text copied from the fontified buffer. `add-face-text-property' can help to keep the original foreground colors in the text copied from fontified buffers. And if someone still wants to always use the black foreground, this is easy to do by customizing the `match' face and explicitly selecting a foreground color. === modified file 'lisp/replace.el' --- lisp/replace.el 2013-06-13 22:08:45 +0000 +++ lisp/replace.el 2013-06-17 22:51:03 +0000 @@ -1442,13 +1460,12 @@ (defun occur-engine (regexp buffers out- (setq matches (1+ matches)) (add-text-properties (match-beginning 0) (match-end 0) - (append - `(occur-match t) - (when match-face - ;; Use `face' rather than `font-lock-face' here - ;; so as to override faces copied from the buffer. - `(face ,match-face))) - curstring) + '(occur-match t) curstring) + (when match-face + ;; Add `match-face' to faces copied from the buffer. + (add-face-text-property + (match-beginning 0) (match-end 0) + match-face nil curstring)) (setq start (match-end 0)))) ;; Generate the string to insert for this match (let* ((match-prefix From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 18 20:16:09 2013 Received: (at 14645) by debbugs.gnu.org; 19 Jun 2013 00:16:09 +0000 Received: from localhost ([127.0.0.1]:54132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Up64G-0001Yg-Oz for submit@debbugs.gnu.org; Tue, 18 Jun 2013 20:16:09 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:53270 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Up64C-0001YE-B8 for 14645@debbugs.gnu.org; Tue, 18 Jun 2013 20:16:05 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id CBF9D258B9E915 for <14645@debbugs.gnu.org>; Tue, 18 Jun 2013 17:16:02 -0700 (PDT) From: Juri Linkov To: 14645@debbugs.gnu.org Subject: Re: bug#14645: Keep highlighting face foreground Organization: JURTA References: <87ehc0mjhy.fsf@mail.jurta.org> Date: Wed, 19 Jun 2013 02:31:43 +0300 In-Reply-To: <87ehc0mjhy.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 18 Jun 2013 01:55:12 +0300") Message-ID: <87mwqn9g6g.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14645 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Another place where `add-face-text-property' could help is for the recently added face `info-index-match'. Currently it looks very ugly when the `info-index-match' face is added in the middle of a link that breaks its continuity. A test case is: `C-h r I match RET'. This is because `Info-index' adds the `info-index-match' face to the strings of the found index entries. Later `Info-virtual-index-find-node' inserts strings to the Info buffer. And finally `Info-fontify-node' puts the `font-lock-face' property with `info-xref' on links. The `face info-index-match' takes precedence over `font-lock-face info-xref'. This patch uses `add-face-text-property' to merge the `info-index-match' face with the `info-xref' face. I think it's not a problem that it will use the text property `face' instead of `font-lock-face' since more strategically advantageous direction of the development for the Info reader would be to move from font-lock-mode to more browser-like design like in eww. However, the problem is that usually a highlighting feature puts a highlighting face on the already fontified string, but this code reverses the order and first it highlights matches and later puts more regular text properties on it (so this reversal requires the non-nil APPEND arg of `add-face-text-property'). Unfortunately, I have no better idea. === modified file 'lisp/info.el' --- lisp/info.el 2013-05-27 22:42:11 +0000 +++ lisp/info.el 2013-06-18 22:57:07 +0000 @@ -4874,9 +4894,8 @@ (defun Info-fontify-node () "mouse-2: go to this node") 'mouse-face 'highlight))) (when (or not-fontified-p fontify-visited-p) - (put-text-property + (add-face-text-property (match-beginning 1) (match-end 1) - 'font-lock-face ;; Display visited menu items in a different face (if (and Info-fontify-visited-nodes (save-match-data @@ -4905,7 +4924,7 @@ (defun Info-fontify-node () (caar hl)))) (setq res (car hl) hl nil) (setq hl (cdr hl)))) - res))) 'info-xref-visited 'info-xref))) + res))) 'info-xref-visited 'info-xref) 'append)) (when (and not-fontified-p (memq Info-hide-note-references '(t hide)) (not (Info-index-node))) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 19 19:19:12 2013 Received: (at 14645) by debbugs.gnu.org; 19 Jun 2013 23:19:12 +0000 Received: from localhost ([127.0.0.1]:56742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UpRei-0003x9-54 for submit@debbugs.gnu.org; Wed, 19 Jun 2013 19:19:12 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:55924 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UpRef-0003ws-GO for 14645@debbugs.gnu.org; Wed, 19 Jun 2013 19:19:10 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 749D6258B9E915 for <14645@debbugs.gnu.org>; Wed, 19 Jun 2013 16:19:07 -0700 (PDT) From: Juri Linkov To: 14645@debbugs.gnu.org Subject: Re: bug#14645: Keep highlighting face foreground Organization: JURTA References: <87ehc0mjhy.fsf@mail.jurta.org> <87mwqn9g6g.fsf@mail.jurta.org> Date: Thu, 20 Jun 2013 02:14:18 +0300 In-Reply-To: <87mwqn9g6g.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 19 Jun 2013 02:31:43 +0300") Message-ID: <87sj0dzoad.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14645 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) I was going to propose a similar change to use `add-face-text-property' in hi-lock, but it turned out to be much simpler because hi-lock is based on font-lock that already has `font-lock-prepend-text-property' that does the same: === modified file 'lisp/hi-lock.el' --- lisp/hi-lock.el 2013-06-03 08:51:50 +0000 +++ lisp/hi-lock.el 2013-06-19 23:12:05 +0000 @@ -715,7 +690,7 @@ (defun hi-lock-set-pattern (regexp face) "Highlight REGEXP with face FACE." ;; Hashcons the regexp, so it can be passed to remove-overlays later. (setq regexp (hi-lock--hashcons regexp)) - (let ((pattern (list regexp (list 0 (list 'quote face) t)))) + (let ((pattern (list regexp (list 0 (list 'quote face) 'prepend)))) ;; Refuse to highlight a text that is already highlighted. (unless (assoc regexp hi-lock-interactive-patterns) (push pattern hi-lock-interactive-patterns) From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 20 19:09:08 2013 Received: (at 14645) by debbugs.gnu.org; 20 Jun 2013 23:09:08 +0000 Received: from localhost ([127.0.0.1]:59486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UpnyU-0006Jj-NA for submit@debbugs.gnu.org; Thu, 20 Jun 2013 19:09:07 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:44123 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UpnyQ-0006JE-2U for 14645@debbugs.gnu.org; Thu, 20 Jun 2013 19:09:03 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 8B69C258B9E91C for <14645@debbugs.gnu.org>; Thu, 20 Jun 2013 16:09:00 -0700 (PDT) From: Juri Linkov To: 14645@debbugs.gnu.org Subject: Re: bug#14645: Keep highlighting face foreground Organization: JURTA References: <87ehc0mjhy.fsf@mail.jurta.org> <87mwqn9g6g.fsf@mail.jurta.org> Date: Fri, 21 Jun 2013 02:03:17 +0300 In-Reply-To: <87mwqn9g6g.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 19 Jun 2013 02:31:43 +0300") Message-ID: <87d2rgwfka.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14645 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > This patch uses `add-face-text-property' to merge the `info-index-match' > face with the `info-xref' face. Using the text property `face' instead of `font-lock-face' might break something, so a better patch below removes the text properties `face info-index-match' from the Info buffer and replaces them with `font-lock-face info-index-match' in `Info-virtual-index-find-node'. And `Info-fontify-node' merges them with its `font-lock-face' text properties using `font-lock-prepend-text-property'. Here is a summary: 1. `Info-index' puts `info-index-match face' on index strings. 2. `Info-virtual-index-find-node' inserts them into the Info buffer. 3. It also converts text properties `face info-index-match' to `font-lock-face info-index-match' in the Info buffer. 4. `Info-fontify-node' prepends `font-lock-face info-xref' to links. === modified file 'lisp/info.el' --- lisp/info.el 2013-05-27 22:42:11 +0000 +++ lisp/info.el 2013-06-20 22:59:01 +0000 @@ -3417,7 +3439,19 @@ (defun Info-virtual-index-find-node (fil (nth 1 entry) (if (nth 3 entry) (format " (line %s)" (nth 3 entry)) - "")))))) + "")))) + ;; Convert text properties `face info-index-match' to + ;; `font-lock-face info-index-match'. + (save-excursion + (let ((beg (text-property-any (point-min) (point-max) 'face 'info-index-match)) + (end nil) + (inhibit-read-only t)) + (while beg + (goto-char beg) + (when (setq end (next-single-property-change beg 'face)) + (font-lock-prepend-text-property beg end 'font-lock-face 'info-index-match) + (remove-text-properties beg end '(face info-index-match))) + (setq beg (text-property-any end (point-max) 'face 'info-index-match))))))) ;; Else, Generate a list of previous search results (let ((nodes (reverse Info-virtual-index-nodes))) (insert (format "\n\^_\nFile: %s, Node: %s, Up: Top\n\n" @@ -3532,7 +3567,19 @@ (defun Info-apropos-find-node (_filename (nth 2 entry) (if (nth 3 entry) (format " (line %s)" (nth 3 entry)) - ""))))))))) + "")))) + ;; Convert text properties `face info-index-match' to + ;; `font-lock-face info-index-match'. + (save-excursion + (let ((beg (text-property-any (point-min) (point-max) 'face 'info-index-match)) + (end nil) + (inhibit-read-only t)) + (while beg + (goto-char beg) + (when (setq end (next-single-property-change beg 'face)) + (font-lock-prepend-text-property beg end 'font-lock-face 'info-index-match) + (remove-text-properties beg end '(face info-index-match))) + (setq beg (text-property-any end (point-max) 'face 'info-index-match)))))))))) (defun Info-apropos-matches (string) "Collect STRING matches from all known Info files on your system. @@ -4755,7 +4811,7 @@ (defun Info-fontify-node () (when (or not-fontified-p fontify-visited-p) (setq rbeg (match-beginning 2) rend (match-end 2)) - (put-text-property + (font-lock-prepend-text-property rbeg rend 'font-lock-face ;; Display visited nodes in a different face @@ -4874,7 +4930,7 @@ (defun Info-fontify-node () "mouse-2: go to this node") 'mouse-face 'highlight))) (when (or not-fontified-p fontify-visited-p) - (put-text-property + (font-lock-prepend-text-property (match-beginning 1) (match-end 1) 'font-lock-face ;; Display visited menu items in a different face From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 19:01:03 2020 Received: (at control) by debbugs.gnu.org; 12 Aug 2020 23:01:03 +0000 Received: from localhost ([127.0.0.1]:45907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5zjy-00055J-Um for submit@debbugs.gnu.org; Wed, 12 Aug 2020 19:01:03 -0400 Received: from mail-yb1-f181.google.com ([209.85.219.181]:33777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5zjw-0004xx-I8 for control@debbugs.gnu.org; Wed, 12 Aug 2020 19:01:01 -0400 Received: by mail-yb1-f181.google.com with SMTP id p191so2281042ybg.0 for ; Wed, 12 Aug 2020 16:01:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=tsL38m1XhJ1WzzquUwSLJYGyujZ8E4FYDUgN4kZfkGo=; b=FBG3muXSoVTDFIkAohA1M1waCzT+Qk0gckBOKsO2u4Vn9n0CjMuKWNK9QYDCA+pVE1 UR2ZNwIADdfYnnFGVVp27nriUFIPtcv+i1QE8NMIxM2tO00v912rypJAUIIdl3LC2D2l 3UXeEftr0q5ii6Vp8N+Xux4QnAvGVzoU8d79YbWRPnRSqMrIvD95kncin9chD2BD3zO9 2amoaJaeNzzb0aDZjaCOXI+I6wDgwCEctdRoHuSrID/6Jehdo22kR/0nIFFPtC+iSlOM fPWSME5+is4ebq413nD6UiDK88IMdI59e/Rj3/rAzWxIGrFqO5dhvKctTIztfu+Ofy15 WGDw== X-Gm-Message-State: AOAM533zV1RW6KFc/pe2/iOkWq/o9WGev8AVn5GOAjskM/6QoSEfUvKw yIc5Ryn1ApB5iwAw+S5u7/xUmhh7lde0PYwT5fjQ5dAIYIYZlw== X-Google-Smtp-Source: ABdhPJw2Vdh6yMc8O9sU5U/rlF0z+FWuMQHMUc3t2cnPVyNOApjSwP+1sU2+JLAY9Sg+apGzvQB60js023FaV8ffFpE= X-Received: by 2002:a5b:508:: with SMTP id o8mr2744733ybp.43.1597273254858; Wed, 12 Aug 2020 16:00:54 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Thu, 13 Aug 2020 01:00:43 +0200 Message-ID: Subject: To: control Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 14645 + patch thanks Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.181 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.181 listed in wl.mailspike.net] 1.0 PDS_TONAME_EQ_TOLOCAL_VSHORT Very short body and From looks like 2 different emails 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 14645 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.181 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.181 listed in list.dnswl.org] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.0 PDS_TONAME_EQ_TOLOCAL_VSHORT Very short body and From looks like 2 different emails 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager tags 14645 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 07:27:42 2020 Received: (at 14645) by debbugs.gnu.org; 13 Aug 2020 11:27:42 +0000 Received: from localhost ([127.0.0.1]:47208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6BOY-000113-AW for submit@debbugs.gnu.org; Thu, 13 Aug 2020 07:27:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6BOW-00010q-EV for 14645@debbugs.gnu.org; Thu, 13 Aug 2020 07:27:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=afpePEAw5ENhEda2cygyJ4t/zqAWoE3F7o3ZUht4IZc=; b=e6t6b0ylT/jFDsouSBq1Dp/l/Z TaIeipsF2+Yfop7otF5iRKwmG679LXV/T57HoRd+PapzDfaI5s565cJFaz5nCGNgz4R+GAZgbWn6o CDH0V/ozNxsC9z1qGLgn0t3Oz0QUFY9HQpJw//UxQ3D894v+02FV9CDRPpuALXADQ714=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6BON-0005Wf-RC; Thu, 13 Aug 2020 13:27:34 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#14645: Keep highlighting face foreground References: <87ehc0mjhy.fsf@mail.jurta.org> Date: Thu, 13 Aug 2020 13:27:30 +0200 In-Reply-To: <87ehc0mjhy.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 18 Jun 2013 01:55:12 +0300") Message-ID: <87v9hmdbvh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > Now that we have a new function `add-face-text-property' it would be > very useful for features that add faces with a different background > to highlight matches. For instance, `occur' uses `add-tex [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14645 Cc: 14645@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Now that we have a new function `add-face-text-property' it would be > very useful for features that add faces with a different background > to highlight matches. For instance, `occur' uses `add-text-properties' > to add the `match' face, but currently it removes foreground colors > from the text copied from the fontified buffer. [...] > + '(occur-match t) curstring) > + (when match-face > + ;; Add `match-face' to faces copied from the buffer. > + (add-face-text-property > + (match-beginning 0) (match-end 0) > + match-face nil curstring)) Looks like a variation of this has been applied already. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 07:32:42 2020 Received: (at 14645) by debbugs.gnu.org; 13 Aug 2020 11:32:42 +0000 Received: from localhost ([127.0.0.1]:47214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6BTN-0003FQ-SL for submit@debbugs.gnu.org; Thu, 13 Aug 2020 07:32:42 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6BTL-00039a-Do for 14645@debbugs.gnu.org; Thu, 13 Aug 2020 07:32:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pHPX9uKZn8GlNiqJbIK7Y/U90KncSwjrERKYP2hAykU=; b=bOee2vT2lyWUlFxolgobHo3E5e E7chMiUo6gChhTC6tPPO7Plk8xHArkCj0uH0OY3Ty4z5ufvu7IyO/xrf9kemm2NZ3i4k0fRu9LUUl 2e0nW+L9H9rH85KEAB55HfFVabFr3aZlZpE5OAzkPtZM339VEoKhiD3LESQz+jm1/JmA=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6BTD-0005a7-5L; Thu, 13 Aug 2020 13:32:33 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#14645: Keep highlighting face foreground References: <87ehc0mjhy.fsf@mail.jurta.org> <87mwqn9g6g.fsf@mail.jurta.org> Date: Thu, 13 Aug 2020 13:32:29 +0200 In-Reply-To: <87mwqn9g6g.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 19 Jun 2013 02:31:43 +0300") Message-ID: <87r1sadbn6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > Another place where `add-face-text-property' could help is for the > recently added face `info-index-match'. Currently it looks very ugly > when the `info-index-match' face is added in the middle of [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14645 Cc: 14645@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Another place where `add-face-text-property' could help is for the > recently added face `info-index-match'. Currently it looks very ugly > when the `info-index-match' face is added in the middle of a link > that breaks its continuity. A test case is: `C-h r I match RET'. > > This is because `Info-index' adds the `info-index-match' face to the > strings of the found index entries. Later `Info-virtual-index-find-node' > inserts strings to the Info buffer. And finally `Info-fontify-node' > puts the `font-lock-face' property with `info-xref' on links. > The `face info-index-match' takes precedence over `font-lock-face info-xref'. This hadn't been fixed, so I applied your patch to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 07:35:25 2020 Received: (at 14645) by debbugs.gnu.org; 13 Aug 2020 11:35:25 +0000 Received: from localhost ([127.0.0.1]:47247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6BW1-0003S3-56 for submit@debbugs.gnu.org; Thu, 13 Aug 2020 07:35:25 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6BVz-0003Rp-HW for 14645@debbugs.gnu.org; Thu, 13 Aug 2020 07:35:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aBB/A4dlZPE+wH2v2h/Qp0TGw7s+u6mAkF3qyZwxWGI=; b=unQRyxY2RX0NwHzZYT3DGCw3f3 TuRc1cSegXSfHg761958evBXJVZy+KsXfJfky22WjGe3UKhAmQF6bWN2NNQlcpDXSeMWJnpjPhXsY dENs9KdYSRP3G3YJ5HA9sNTKqyaQxbBZJCJOiGcIzGYCF113gud8YvSoCkYwXliNaaOk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6BVq-0005ct-Pi; Thu, 13 Aug 2020 13:35:17 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#14645: Keep highlighting face foreground References: <87ehc0mjhy.fsf@mail.jurta.org> <87mwqn9g6g.fsf@mail.jurta.org> <87sj0dzoad.fsf@mail.jurta.org> Date: Thu, 13 Aug 2020 13:35:13 +0200 In-Reply-To: <87sj0dzoad.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 20 Jun 2013 02:14:18 +0300") Message-ID: <87mu2ydbim.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > I was going to propose a similar change to use `add-face-text-property' > in hi-lock, but it turned out to be much simpler because hi-lock > is based on font-lock that already has `font-lock-prepend [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14645 Cc: 14645@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > I was going to propose a similar change to use `add-face-text-property' > in hi-lock, but it turned out to be much simpler because hi-lock > is based on font-lock that already has `font-lock-prepend-text-property' > that does the same: > > === modified file 'lisp/hi-lock.el' > --- lisp/hi-lock.el 2013-06-03 08:51:50 +0000 > +++ lisp/hi-lock.el 2013-06-19 23:12:05 +0000 > @@ -715,7 +690,7 @@ (defun hi-lock-set-pattern (regexp face) > "Highlight REGEXP with face FACE." > ;; Hashcons the regexp, so it can be passed to remove-overlays later. > (setq regexp (hi-lock--hashcons regexp)) > - (let ((pattern (list regexp (list 0 (list 'quote face) t)))) > + (let ((pattern (list regexp (list 0 (list 'quote face) 'prepend)))) If I'm reading this correctly, something similar has been added in the intervening years: (let ((pattern (list (lambda (limit) (let ((case-fold-search case-fold) (search-spaces-regexp spaces-regexp)) (re-search-forward regexp limit t))) (list subexp (list 'quote face) 'prepend))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 07:35:30 2020 Received: (at control) by debbugs.gnu.org; 13 Aug 2020 11:35:30 +0000 Received: from localhost ([127.0.0.1]:47250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6BW6-0003SK-Df for submit@debbugs.gnu.org; Thu, 13 Aug 2020 07:35:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6BW5-0003S1-B4 for control@debbugs.gnu.org; Thu, 13 Aug 2020 07:35:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=p886YDj1xkSWl/7csmyAtgd8qfk/YLO88l0dlPCG7iI=; b=dCxhlA4wRlvzSRXVo/WYMTyolc mJL1GyyCB/SQ3zX9wk5UlnmVb0M/33LVjjC8pZthwqJYprEOawD+CeYTtrcPXtwxYPq8PjFhq3p1B 3uIwcLFXonJ8QIMd05oCMTy+WAcLO8GLBMtAaWMuzYZcRIZPVzAYeLCNoNEbbsO/hU6c=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6BVx-0005dB-I6 for control@debbugs.gnu.org; Thu, 13 Aug 2020 13:35:23 +0200 Date: Thu, 13 Aug 2020 13:35:20 +0200 Message-Id: <87lfiidbif.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #14645 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 14645 fixed close 14645 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 14645 fixed close 14645 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 20:52:56 2020 Received: (at 14645) by debbugs.gnu.org; 14 Aug 2020 00:52:56 +0000 Received: from localhost ([127.0.0.1]:51421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Nxo-0006Wm-37 for submit@debbugs.gnu.org; Thu, 13 Aug 2020 20:52:56 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:40809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Nxk-0006WX-BP for 14645@debbugs.gnu.org; Thu, 13 Aug 2020 20:52:55 -0400 X-Originating-IP: 91.129.102.47 Received: from mail.gandi.net (m91-129-102-47.cust.tele2.ee [91.129.102.47]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D3192E0002; Fri, 14 Aug 2020 00:52:44 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#14645: Keep highlighting face foreground Organization: LINKOV.NET References: <87ehc0mjhy.fsf@mail.jurta.org> <87mwqn9g6g.fsf@mail.jurta.org> <87r1sadbn6.fsf@gnus.org> Date: Fri, 14 Aug 2020 02:44:43 +0300 In-Reply-To: <87r1sadbn6.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 13 Aug 2020 13:32:29 +0200") Message-ID: <87pn7um4sw.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14645 Cc: 14645@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Another place where `add-face-text-property' could help is for the >> recently added face `info-index-match'. Currently it looks very ugly >> when the `info-index-match' face is added in the middle of a link >> that breaks its continuity. A test case is: `C-h r I match RET'. >> >> This is because `Info-index' adds the `info-index-match' face to the >> strings of the found index entries. Later `Info-virtual-index-find-node' >> inserts strings to the Info buffer. And finally `Info-fontify-node' >> puts the `font-lock-face' property with `info-xref' on links. >> The `face info-index-match' takes precedence over `font-lock-face info-xref'. > > This hadn't been fixed, so I applied your patch to Emacs 28. This patch breaks Info fontification, please revert it. Here is what I said in the message sent later with another patch at https://debbugs.gnu.org/14645#14 Using the text property `face' instead of `font-lock-face' might break something, so a better patch below removes the text properties `face info-index-match' from the Info buffer This is why I posted a better patch. But please give me more time to test the second better patch, I'm not yet sure how well it works now. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 02:20:54 2020 Received: (at 14645) by debbugs.gnu.org; 14 Aug 2020 06:20:54 +0000 Received: from localhost ([127.0.0.1]:51624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6T5C-00006u-8b for submit@debbugs.gnu.org; Fri, 14 Aug 2020 02:20:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6T58-00006d-Ih for 14645@debbugs.gnu.org; Fri, 14 Aug 2020 02:20:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40620) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6T52-0007cH-8X; Fri, 14 Aug 2020 02:20:44 -0400 Received: from [176.228.60.248] (port=4742 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6T50-00070A-V5; Fri, 14 Aug 2020 02:20:44 -0400 Date: Fri, 14 Aug 2020 09:20:36 +0300 Message-Id: <83r1s9lpe3.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87pn7um4sw.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 14 Aug 2020 02:44:43 +0300) Subject: Re: bug#14645: Keep highlighting face foreground References: <87ehc0mjhy.fsf@mail.jurta.org> <87mwqn9g6g.fsf@mail.jurta.org> <87r1sadbn6.fsf@gnus.org> <87pn7um4sw.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 14645 Cc: larsi@gnus.org, 14645@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Fri, 14 Aug 2020 02:44:43 +0300 > Cc: 14645@debbugs.gnu.org > > > This hadn't been fixed, so I applied your patch to Emacs 28. > > This patch breaks Info fontification, please revert it. > Here is what I said in the message sent later with another patch at > https://debbugs.gnu.org/14645#14 > > Using the text property `face' instead of `font-lock-face' > might break something, so a better patch below removes > the text properties `face info-index-match' from the Info buffer Thanks for alerting us to the breakage, but would it be possible to have a test which would make sure the fontification functionality in Info is not broken, so that we don't have to rely on the memory and attention of those who are experts on that? From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 05:50:34 2020 Received: (at 14645) by debbugs.gnu.org; 14 Aug 2020 09:50:34 +0000 Received: from localhost ([127.0.0.1]:51854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6WM6-0003Ot-K4 for submit@debbugs.gnu.org; Fri, 14 Aug 2020 05:50:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6WM4-0003Og-Db for 14645@debbugs.gnu.org; Fri, 14 Aug 2020 05:50:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=P21hpCKanllcvOgIXAzacDoC+lX74LyASf/4qp5giKo=; b=UH6W6Z9ab5wrQvLPv+4bgITDlx UtFC2UI1/nYLXDDytjJOi9V1chXcs+NMn8AUX1tnk4NMThIfbDfPkxaOgja/UptjzIU4JHVgy1kPk FF/UfLtbyIOzhaeQ296q+5QDRPCGnFCk7tkmlwaTQnuu8fjMfkv79qAM5QzvR0Z/dwmk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6WLs-0000Tj-0P; Fri, 14 Aug 2020 11:50:25 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#14645: Keep highlighting face foreground References: <87ehc0mjhy.fsf@mail.jurta.org> <87mwqn9g6g.fsf@mail.jurta.org> <87r1sadbn6.fsf@gnus.org> <87pn7um4sw.fsf@mail.linkov.net> Date: Fri, 14 Aug 2020 11:50:18 +0200 In-Reply-To: <87pn7um4sw.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 14 Aug 2020 02:44:43 +0300") Message-ID: <87ft8pblph.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > This patch breaks Info fontification, please revert it. OK, reverted. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14645 Cc: 14645@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > This patch breaks Info fontification, please revert it. OK, reverted. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Jun 17 20:21:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 11 Sep 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator