GNU bug report logs - #14637
recent viper-mode regression

Previous Next

Package: emacs;

Reported by: Jim Meyering <jim <at> meyering.net>

Date: Sun, 16 Jun 2013 23:01:02 UTC

Severity: normal

Done: Juri Linkov <juri <at> jurta.org>

Bug is archived. No further changes may be made.

Full log

Message #19 received at 14637 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 14637 <at> debbugs.gnu.org
Subject: Re: bug#14637: recent viper-mode regression
Date: Wed, 19 Jun 2013 23:53:07 +0300

>> Grepping for `shell-command-on-region' revealed the exhaustive list
>> of the callers that are fixed now with this patch to set both args
>> OUTPUT-BUFFER and REPLACE to the same value in unison:
>
> Do all the callers need to be fixed?  Most of them?  A minority only?
> If it's not just a minority, then maybe the better fix is to revert
> revno:112695 (or at least change it) so that existing code doesn't need
> to be changed.

I fixed all the callers that missed the required REPLACE arg:
5 were in vi mode, and 1 in mh-e.  They are just a minority
out of total 25 occurrences of `shell-command-on-region'.
This bug report was last modified 12 years and 33 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.