GNU bug report logs - #14635
24.3.50; Regression in Customize: no revert changes

Previous Next

Full log

Message #27 received at 14635 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 14635 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14635: 24.3.50; Regression in Customize: no revert changes
Date: Fri, 30 Oct 2020 11:23:51 -0300

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Mauro Aranda <maurooaranda <at> gmail.com>
>> Date: Fri, 30 Oct 2020 11:03:39 -0300
>> Cc: Drew Adams <drew.adams <at> oracle.com>, 14635 <at> debbugs.gnu.org
>>
>> > Doesn't customizing a face record the original value in some property
>> > of the face symbol?  If so, reverting the customizations should use
>> > those recorded values, I think.
>>
>> AFAICT, it doesn't right now.  I followed the recipe I gave, and then:
>> (symbol-plist 'default)
>> The relevant properties I see are:
>> * face-defface-spec ==> ((t nil))
>> which won't take us anywhere.
>> * theme-face, which has the customized value for the user theme, and
>> * customized-face, which again, has the customized value.
>>
>> But I see no immediate reason why we shouldn't start doing it, if you
>> think it is OK to use that to solve this issue.  My only questions are
>> if it would be best to do it in Customize or in faces.el, and if we
>> should only special case the default face.
>
> I'd begin with doing this in Customize, since it is the only user of
> this property.

I'll try to do it.  Thank you.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.