From unknown Sun Aug 17 22:13:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jun 2013 09:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 14635@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.137137433023918 (code B ref -1); Sun, 16 Jun 2013 09:19:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jun 2013 09:18:50 +0000 Received: from localhost ([127.0.0.1]:47629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uo96n-0006Di-FO for submit@debbugs.gnu.org; Sun, 16 Jun 2013 05:18:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48051) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uo96l-0006DG-Cv for submit@debbugs.gnu.org; Sun, 16 Jun 2013 05:18:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uo96f-0004Jp-DG for submit@debbugs.gnu.org; Sun, 16 Jun 2013 05:18:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo96f-0004Jj-9z for submit@debbugs.gnu.org; Sun, 16 Jun 2013 05:18:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo96d-00069a-TA for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 05:18:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uo96a-0004IB-Qe for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 05:18:39 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:39823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo96a-0004I6-J9 for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 05:18:36 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r5G9IX5Q003798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 16 Jun 2013 09:18:33 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5G9IZU6018332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 16 Jun 2013 09:18:35 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r5G9IYZX008616 for ; Sun, 16 Jun 2013 09:18:34 GMT MIME-Version: 1.0 Message-ID: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> Date: Sun, 16 Jun 2013 02:18:36 -0700 (PDT) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -Q M-x customize-face default Make some changes. Then choose Set for current session from the State button. Then try to revert your changes using button `Revert...' > `Revert this session's customizations'. There is no effect: no change in the appearance of the buffer. And trying to revert or undo edits using the State button is also impossible: `Revert this session's customizations' is now dimmed out. This is with emacs -Q. The change of state to revert to no changes seems completely broken (a regression). In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-06-13 on ODIEONE Bzr revision: 112978 xfq.free@gmail.com-20130613224333-3yfl8navh3c1vmxy Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs CFLAGS=3D'-O0 -g3' CPPFLAGS=3D'-Ic:/Devel/emacs/include' LDFLAGS=3D'-Lc:/Devel/emacs/lib'' From unknown Sun Aug 17 22:13:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jun 2013 10:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 14635@debbugs.gnu.org Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.13713786573892 (code B ref 14635); Sun, 16 Jun 2013 10:31:01 +0000 Received: (at 14635) by debbugs.gnu.org; 16 Jun 2013 10:30:57 +0000 Received: from localhost ([127.0.0.1]:47716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UoAEa-00010g-Do for submit@debbugs.gnu.org; Sun, 16 Jun 2013 06:30:56 -0400 Received: from mail-ea0-f176.google.com ([209.85.215.176]:38555) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UoAEX-00010P-QY for 14635@debbugs.gnu.org; Sun, 16 Jun 2013 06:30:54 -0400 Received: by mail-ea0-f176.google.com with SMTP id z15so1179420ead.21 for <14635@debbugs.gnu.org>; Sun, 16 Jun 2013 03:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=EbQwgWK+C43Y3Ma6t4pQONNF1ufOb3RkgzV4Zx3Tbqw=; b=gVpfQ/D7jYkDbBTmLwB2x649v6xmUOiO1z3wwss+EgL7njUUPO1jcqaMTA3hA49Zw8 cI0CIzk9bfC1N/fj5CaEa16LkemBMoOEo+JB5J2A6OWi28mbwoiEHn4y6arCzCAvKB4h XO6z0tAb+BExGhk1QXBPiKQ4rW3OU1f/7jyBwEYvcjr97KA3BuBmg00rjmZ5eFYBwcf7 f78uqi9fJS4REjxFM/zC+HYd4zXn52I7v1su5gNUOjC41Y3ntYDroCC0M4fwB7h0sVM0 8+XjHHzsHKxhUyxVoSETg3czB7igsru8nJARuoy1NwWhkhS0zOpXmNdAqkrkq3LVXM3w VEjg== X-Received: by 10.15.21.78 with SMTP id c54mr11504849eeu.14.1371378648120; Sun, 16 Jun 2013 03:30:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.14.142.4 with HTTP; Sun, 16 Jun 2013 03:30:07 -0700 (PDT) In-Reply-To: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> From: Juanma Barranquero Date: Sun, 16 Jun 2013 12:30:07 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Jun 16, 2013 at 11:18 AM, Drew Adams wrote: > emacs -Q > M-x customize-face default > > Make some changes. Then choose Set for current session from the State > button. > > Then try to revert your changes using button `Revert...' > `Revert this > session's customizations'. There is no effect: no change in the > appearance of the buffer. Some things can be reverted (underline, etc.) and some not (font family, slant...). Weird. Juanma From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 19:32:57 2016 Received: (at control) by debbugs.gnu.org; 5 Aug 2016 23:32:57 +0000 Received: from localhost ([127.0.0.1]:56937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVobp-0002Fh-52 for submit@debbugs.gnu.org; Fri, 05 Aug 2016 19:32:57 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:33856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVobn-0002FU-5k for control@debbugs.gnu.org; Fri, 05 Aug 2016 19:32:55 -0400 Received: by mail-io0-f176.google.com with SMTP id q83so313900018iod.1 for ; Fri, 05 Aug 2016 16:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4GE4ffrNnIKl4V3h5oDc8bENUYEVO1jyJL70eSnJnfQ=; b=nOUYnMi0Ie429FTSRYbo2pniy5JVeNG3xlWEHXoX3bgV9aMofqxVRAPZ4Uri9w0Hew 4pEJmtuv/nr/ecq8YZlh0/ZT09Ytc/XlEqBY6m5b+HjQ4JEqCh5qW8wRKKnYCfeE3Ncc 2DcGeDrymkrTiPpbs7MM1ar/cI+Yc72yrUuYdT+i2EBjIDu8IDDejqUu/E+rYMvyzVxx sJo6hv6LncO9VWgWPem4Ri662UFVl/E4YKo5XJAUZWE+kGaWzPFacNuX1m75PVqJ3EZa Bsa5MxXumU8GIbrG8bwo55f2eeC2V2yXfgQ1Ukc7B6W3DPM3rSEKx6U0DzfVbFp1yjNc B9BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=4GE4ffrNnIKl4V3h5oDc8bENUYEVO1jyJL70eSnJnfQ=; b=XbQ4JaJS+dQlYkspPFWZAOcQLEymq1eRHdYMzxzINg0zhwfuTkDhpu03wmw7fcZG3G rTlY9xvIUK6uNHb7iIVdrN9fk332KEYdw3BqnHlsXDkNP01YfCgWwaaO3O6qx9gYtDee YZv/Xd/j5SXtVvuW1LOO6uo1utmvgtenh2FVALtm1QjRm1xPb5OrPFb3DEnPsY9lXGdK z3gsYTb3XxNfoE0DIsk8YccvA/S6m/s1sKVEV/pxzwWdele4AuzIWcIQpsEupsrW+Aax 8fgQNzc6sAy6EcdhRXEVGu16ePkcN3GhEAJEQpc/YAsuIeaRPSxmSxuxxbtnMzeo0CV5 Bzhg== X-Gm-Message-State: AEkooustXk6MhJR8CT/FeosXC6oQ0QHjm4iIsQYjB7Eh8sxchvou+ja2v4+IDKY5EaN6cQ== X-Received: by 10.107.164.201 with SMTP id d70mr84297337ioj.80.1470439969524; Fri, 05 Aug 2016 16:32:49 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id b20sm4842843itb.22.2016.08.05.16.32.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Aug 2016 16:32:48 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: Re: bug#14635: 24.3.50; Regression in Customize: no revert changes References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> Date: Fri, 05 Aug 2016 19:32:57 -0400 In-Reply-To: (Juanma Barranquero's message of "Sun, 16 Jun 2013 12:30:07 +0200") Message-ID: <87bn1694gm.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 14635 confirmed found 14635 25.1 quit Juanma Barranquero writes: > On Sun, Jun 16, 2013 at 11:18 AM, Drew Adams wrote: > >> emacs -Q >> M-x customize-face default >> >> Make some changes. Then choose Set for current session from the State >> button. >> >> Then try to revert your changes using button `Revert...' > `Revert this >> session's customizations'. There is no effect: no change in the >> appearance of the buffer. > > Some things can be reverted (underline, etc.) and some not (font > family, slant...). Weird. From unknown Sun Aug 17 22:13:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> In-Reply-To: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 13:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed To: Drew Adams Cc: 14635@debbugs.gnu.org Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.160406495330946 (code B ref 14635); Fri, 30 Oct 2020 13:36:01 +0000 Received: (at 14635) by debbugs.gnu.org; 30 Oct 2020 13:35:53 +0000 Received: from localhost ([127.0.0.1]:56687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUZM-000833-LH for submit@debbugs.gnu.org; Fri, 30 Oct 2020 09:35:52 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:44926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUZL-00082r-9n for 14635@debbugs.gnu.org; Fri, 30 Oct 2020 09:35:51 -0400 Received: by mail-wr1-f52.google.com with SMTP id b3so578887wrx.11 for <14635@debbugs.gnu.org>; Fri, 30 Oct 2020 06:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=bKesBNlIjpeMM4anEID59oxeEMX6l/wNGrErSC22GRw=; b=G5pRjY03RlvUjY09v2qM94T4drhi1N3VoC0GbvDDvwVWLLEdML4BNAHBb/Q5ik1t42 pT8MIECNoGSH2jsVDs1SzY9ay+e0P7En7f3OrYRp/dyF3qYzP38yTQ1r6U+Fjj1Mbp3G G5nYMIDEb1TuZk6CFSsTJArUDOm2wHl5wcOc9qc64OoU3cCsR5qbsWqe4CgqO7os+cbc 39hG3OD7oigJegeFmm8GLX70E3WB0WUGNIcPQaoCvFkxqXT2JALVnzL2dl43LpBnlwPV +JGjWgqVG9iJFV3hW/lSy/hbNX0eCkdq95qxwKsKk0mXSecBOylfroLxEfS6xo5wgMbI Fq1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=bKesBNlIjpeMM4anEID59oxeEMX6l/wNGrErSC22GRw=; b=t76M0knjma1qxg8QI2iBHTjUyvJXvEct7StiY0p8y/Tg89jd57tcPd5h7wDgIFX+A/ q7ppTDcawBsmMjXjnW7jnVU8Y+oyaEiwFzBKwo1FIsVCgOZq+n5liTTuyCuG4knHlVSx n6ybR00ZokACpVc0jDb3VC9QQuKIrhxQ/2RQqcZCvJ4u3uqDP131FEu/Zhx19xU0S6Np kYbRklbjJ/3U6XcFcr3bfCSULa2QXOpGXcpTD6tLqNLQsHsFKEgk3IJVL3gJni2yT0w5 9QuQfUSN6BvupFBf/Uq7ni8l8oiwvraLW1GwMOEu+t7C024M/UNstE1qWmIef6m4Dece tyqQ== X-Gm-Message-State: AOAM532b2RTX5X82t43feRX4rWutm759oCO7ldjJWTpnMWmJ4oZAO0Nm 72hlugM5CX6f+KeB4S20KfNoOiMoQWietD9KNEc= X-Google-Smtp-Source: ABdhPJxIkLijlDywBIkxw+fLOrhZoC78griTuFWyfABR/vcXuwUwFyvqL6uowc3W6pB4a2lDig74afp0dhNEJDzZqEo= X-Received: by 2002:a5d:69d1:: with SMTP id s17mr2002790wrw.77.1604064945484; Fri, 30 Oct 2020 06:35:45 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Fri, 30 Oct 2020 10:35:33 -0300 Message-ID: Content-Type: multipart/alternative; boundary="00000000000045ba4e05b2e379dd" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000045ba4e05b2e379dd Content-Type: text/plain; charset="UTF-8" Drew Adams writes: > emacs -Q > M-x customize-face default > > Make some changes. Then choose Set for current session from the State > button. > > Then try to revert your changes using button `Revert...' > `Revert this > session's customizations'. There is no effect: no change in the > appearance of the buffer. And trying to revert or undo edits using the > State button is also impossible: `Revert this session's customizations' > is now dimmed out. This is with emacs -Q. > > The change of state to revert to no changes seems completely broken (a > regression). > I can reproduce this issue on master. IIUC, this bug is very similar, if not a duplicate, to Bug#13476. But here, we are dealing with the default face, so perhaps it is trickier. For the default face, face-spec-reset-face only sets all attributes to default values if (display-graphic-p frame) returns nil. So on a graphical display, it never resets :family, :foundry, :width, :height, :weight, :slant, :foreground and :background. So, if customizing the foreground color: M-x customize-face RET default Move to Foreground and change it to green C-c C-c to set it for the session Click State and select: Revert this session's customizations The default face is still green. And: (face-attribute 'default :foreground) ==> "green" On a TTY the above recipe works just fine, because we do pass default values here. What would be the right way for face-spec-reset-face to reset all the attributes of the default face to the default values, in a graphic display? --00000000000045ba4e05b2e379dd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Drew Adams <dr= ew.adams@oracle.com> writes:

> emacs -Q
> M-x custom= ize-face default
>
> Make some changes.=C2=A0 Then choose Set f= or current session from the State
> button.
>
> Then try = to revert your changes using button `Revert...' > `Revert this
&g= t; session's customizations'.=C2=A0 There is no effect: no change i= n the
> appearance of the buffer.=C2=A0 And trying to revert or undo = edits using the
> State button is also impossible: `Revert this sessi= on's customizations'
> is now dimmed out.=C2=A0 This is with = emacs -Q.
>
> The change of state to revert to no changes seems= completely broken (a
> regression).
>

I can reproduce t= his issue on master.

IIUC, this bug is very similar, if not a duplic= ate, to Bug#13476.=C2=A0 But
here, we are dealing with the default face,= so perhaps it is trickier.

For the default face, face-spec-reset-fa= ce only sets all attributes to
default values if (display-graphic-p fram= e) returns nil.=C2=A0 So on a
graphical display, it never resets :family= , :foundry, :width, :height,
:weight, :slant, :foreground and :backgroun= d.

So, if customizing the foreground color:
M-x customize-face RE= T default
Move to Foreground and change it to green
C-c C-c to set it= for the session
Click State and select: Revert this session's custo= mizations

The default face is still green.=C2=A0 And:
(face-attri= bute 'default :foreground) =3D=3D> "green"

On a TTY= the above recipe works just fine, because we do pass default
values her= e.


What would be the right way for face-spec-reset-face to reset= all the
attributes of the default face to the default values, in a grap= hic
display?
--00000000000045ba4e05b2e379dd-- From unknown Sun Aug 17 22:13:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 13:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed To: Mauro Aranda Cc: 14635@debbugs.gnu.org, drew.adams@oracle.com Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.160406542731756 (code B ref 14635); Fri, 30 Oct 2020 13:44:01 +0000 Received: (at 14635) by debbugs.gnu.org; 30 Oct 2020 13:43:47 +0000 Received: from localhost ([127.0.0.1]:56709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUh1-0008G8-AP for submit@debbugs.gnu.org; Fri, 30 Oct 2020 09:43:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUgz-0008Fv-Vf for 14635@debbugs.gnu.org; Fri, 30 Oct 2020 09:43:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44515) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYUgu-0003dW-4A; Fri, 30 Oct 2020 09:43:40 -0400 Received: from [176.228.60.248] (port=2828 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYUgt-0004hU-DT; Fri, 30 Oct 2020 09:43:39 -0400 Date: Fri, 30 Oct 2020 15:43:22 +0200 Message-Id: <83o8kjakxx.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Mauro Aranda on Fri, 30 Oct 2020 10:35:33 -0300) References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mauro Aranda > Date: Fri, 30 Oct 2020 10:35:33 -0300 > Cc: 14635@debbugs.gnu.org > > For the default face, face-spec-reset-face only sets all attributes to > default values if (display-graphic-p frame) returns nil. So on a > graphical display, it never resets :family, :foundry, :width, :height, > :weight, :slant, :foreground and :background. That's because on GUI frames there's no real default for these attributes (unlike on a TTY where we inherit the colors of the terminal). So we simply _cannot_ reset the attributes like that, because there's nothing to reset to. E.g., unspecified-fg only has meaning on a TTY frame. > What would be the right way for face-spec-reset-face to reset all the > attributes of the default face to the default values, in a graphic > display? Doesn't customizing a face record the original value in some property of the face symbol? If so, reverting the customizations should use those recorded values, I think. From unknown Sun Aug 17 22:13:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 14:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed To: Eli Zaretskii Cc: 14635@debbugs.gnu.org, Drew Adams Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.16040666403674 (code B ref 14635); Fri, 30 Oct 2020 14:04:01 +0000 Received: (at 14635) by debbugs.gnu.org; 30 Oct 2020 14:04:00 +0000 Received: from localhost ([127.0.0.1]:59132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYV0a-0000xC-6j for submit@debbugs.gnu.org; Fri, 30 Oct 2020 10:04:00 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:34914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYV0Y-0000wy-4F for 14635@debbugs.gnu.org; Fri, 30 Oct 2020 10:03:59 -0400 Received: by mail-wr1-f50.google.com with SMTP id n15so6625494wrq.2 for <14635@debbugs.gnu.org>; Fri, 30 Oct 2020 07:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v6hYfk3jNac5CebhsnUXAvw1V0/6MBQbcnmL3ntDsk0=; b=hNvcNWX8iciAf92b/T/GD6Kyoy0WtwWDtqwoHpXS+eiGL+un4afjDx4zfU+KKDaNv2 uD39MKSX/k7hwZLvsc1yy17fLJccJ2xBlEFbEJqoZb9zs+XZBCndqGZtUNC67F5jj0gz ap5dKFikHOgiE9gvU7TVO31gCae4L1GR6TPMdtWfy5G+uf9tCwKgh9wOVx8hPNPRYB4V 87rlvrBq+O6TdoacDpV2OYyzwb4nSeDi25glqn0yfilqY/+cGPdSSQO9cKrXslFbI/C2 wN+6ot/yZeYwBaVQczyiopE39bJ7seBcfGZYNTt645CGcI3NKbQuVJ5fUnQLkee3MF6N wfeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v6hYfk3jNac5CebhsnUXAvw1V0/6MBQbcnmL3ntDsk0=; b=sS6hG3x0WP/oe3KEB+oy3io8/D7mVPduxyYDECihDKtuwKIKOBVrD8WR2P9+SDQo9e XDmaU+LbWiaRnLg6DSGW+APb/1UcyMmbN34Ju00sQScpgo1B3zkRFJ14V1hs5x2zzwpZ BpIJJBUoa7Zpwzei75BFLW2vUWLMmCHJmQehuXOzGfZ95yx7f5g5XZgAqu6Rk5r1SDPp z2C51UaV7km/fnFzoNAy93pPo+H8ioYqww5OahKckIv1e8h7hSn7iwcq6lWAFzE7DI7T lXwjqpjX54tzD03NaY/cVfYOUgjxMFQKLEUl50UGiYipOFYNSc+qJnxwChEJ44023gpx cBsg== X-Gm-Message-State: AOAM531s6uI+jN+Y8WXzVb0pp5o8G8rkvfZ1g69Ir70ENaFb38mzSHrR lw6j+eD/b9gb6Yd1kzRXdk4KZqgjg+QpIeUZ3Cs= X-Google-Smtp-Source: ABdhPJz7n6wpLXcrA8FNPuZSwu+iq1YKN1iNmPD4gRal+NoUetIQnpfRROx93kX+HSY3h86EcyMKW6d3CoTc1RAE+FU= X-Received: by 2002:a5d:69d1:: with SMTP id s17mr2166379wrw.77.1604066631504; Fri, 30 Oct 2020 07:03:51 -0700 (PDT) MIME-Version: 1.0 References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> <83o8kjakxx.fsf@gnu.org> In-Reply-To: <83o8kjakxx.fsf@gnu.org> From: Mauro Aranda Date: Fri, 30 Oct 2020 11:03:39 -0300 Message-ID: Content-Type: multipart/alternative; boundary="000000000000c457cc05b2e3ddad" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c457cc05b2e3ddad Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> From: Mauro Aranda >> Date: Fri, 30 Oct 2020 10:35:33 -0300 >> Cc: 14635@debbugs.gnu.org >> >> For the default face, face-spec-reset-face only sets all attributes to >> default values if (display-graphic-p frame) returns nil. So on a >> graphical display, it never resets :family, :foundry, :width, :height, >> :weight, :slant, :foreground and :background. > > That's because on GUI frames there's no real default for these > attributes (unlike on a TTY where we inherit the colors of the > terminal). So we simply _cannot_ reset the attributes like that, > because there's nothing to reset to. E.g., unspecified-fg only has > meaning on a TTY frame. I see, thanks. >> What would be the right way for face-spec-reset-face to reset all the >> attributes of the default face to the default values, in a graphic >> display? > > Doesn't customizing a face record the original value in some property > of the face symbol? If so, reverting the customizations should use > those recorded values, I think. AFAICT, it doesn't right now. I followed the recipe I gave, and then: (symbol-plist 'default) The relevant properties I see are: * face-defface-spec ==> ((t nil)) which won't take us anywhere. * theme-face, which has the customized value for the user theme, and * customized-face, which again, has the customized value. But I see no immediate reason why we shouldn't start doing it, if you think it is OK to use that to solve this issue. My only questions are if it would be best to do it in Customize or in faces.el, and if we should only special case the default face. --000000000000c457cc05b2e3ddad Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> From: Mauro Aranda <maurooaranda@gmail.com>
>> Date:= Fri, 30 Oct 2020 10:35:33 -0300
>> Cc: 14635@debbugs.gnu.org
>>
>> For the d= efault face, face-spec-reset-face only sets all attributes to
>> d= efault values if (display-graphic-p frame) returns nil.=C2=A0 So on a
&g= t;> graphical display, it never resets :family, :foundry, :width, :heigh= t,
>> :weight, :slant, :foreground and :background.
>
>= ; That's because on GUI frames there's no real default for these> attributes (unlike on a TTY where we inherit the colors of the
>= ; terminal).=C2=A0 So we simply _cannot_ reset the attributes like that,> because there's nothing to reset to.=C2=A0 E.g., unspecified-fg o= nly has
> meaning on a TTY frame.

I see, thanks.

>&g= t; What would be the right way for face-spec-reset-face to reset all the>> attributes of the default face to the default values, in a graphi= c
>> display?
>
> Doesn't customizing a face recor= d the original value in some property
> of the face symbol?=C2=A0 If = so, reverting the customizations should use
> those recorded values, = I think.

AFAICT, it doesn't right now.=C2=A0 I followed the reci= pe I gave, and then:
(symbol-plist 'default)
The relevant propert= ies I see are:
* face-defface-spec =3D=3D> ((t nil))
which won'= ;t take us anywhere.
* theme-face, which has the customized value for th= e user theme, and
* customized-face, which again, has the customized val= ue.

But I see no immediate reason why we shouldn't start doing i= t, if you
think it is OK to use that to solve this issue.=C2=A0 My only = questions are
if it would be best to do it in Customize or in faces.el, = and if we
should only special case the default face.
--000000000000c457cc05b2e3ddad-- From unknown Sun Aug 17 22:13:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed To: Mauro Aranda Cc: 14635@debbugs.gnu.org, drew.adams@oracle.com Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.16040674124903 (code B ref 14635); Fri, 30 Oct 2020 14:17:02 +0000 Received: (at 14635) by debbugs.gnu.org; 30 Oct 2020 14:16:52 +0000 Received: from localhost ([127.0.0.1]:59138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYVD2-0001H1-FS for submit@debbugs.gnu.org; Fri, 30 Oct 2020 10:16:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYVD0-0001Gj-VG for 14635@debbugs.gnu.org; Fri, 30 Oct 2020 10:16:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45152) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYVCv-0007si-LP; Fri, 30 Oct 2020 10:16:45 -0400 Received: from [176.228.60.248] (port=4841 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYVCu-0001pK-Ou; Fri, 30 Oct 2020 10:16:45 -0400 Date: Fri, 30 Oct 2020 16:16:27 +0200 Message-Id: <83lffnajes.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Mauro Aranda on Fri, 30 Oct 2020 11:03:39 -0300) References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> <83o8kjakxx.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mauro Aranda > Date: Fri, 30 Oct 2020 11:03:39 -0300 > Cc: Drew Adams , 14635@debbugs.gnu.org > > > Doesn't customizing a face record the original value in some property > > of the face symbol? If so, reverting the customizations should use > > those recorded values, I think. > > AFAICT, it doesn't right now. I followed the recipe I gave, and then: > (symbol-plist 'default) > The relevant properties I see are: > * face-defface-spec ==> ((t nil)) > which won't take us anywhere. > * theme-face, which has the customized value for the user theme, and > * customized-face, which again, has the customized value. > > But I see no immediate reason why we shouldn't start doing it, if you > think it is OK to use that to solve this issue. My only questions are > if it would be best to do it in Customize or in faces.el, and if we > should only special case the default face. I'd begin with doing this in Customize, since it is the only user of this property. From unknown Sun Aug 17 22:13:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 14:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed To: Eli Zaretskii Cc: 14635@debbugs.gnu.org, Drew Adams Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.16040678515714 (code B ref 14635); Fri, 30 Oct 2020 14:25:01 +0000 Received: (at 14635) by debbugs.gnu.org; 30 Oct 2020 14:24:11 +0000 Received: from localhost ([127.0.0.1]:59155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYVK7-0001U5-3t for submit@debbugs.gnu.org; Fri, 30 Oct 2020 10:24:11 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:55840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYVK5-0001Tr-Iy for 14635@debbugs.gnu.org; Fri, 30 Oct 2020 10:24:09 -0400 Received: by mail-wm1-f50.google.com with SMTP id c9so1476234wml.5 for <14635@debbugs.gnu.org>; Fri, 30 Oct 2020 07:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4ItccC530PkvKRAutMOK7ZEfzTV3mCc7JXsz8tUi8eg=; b=OLCQCB9LfZ+homzpOVdFRLr70ThAVhDQqwtmawblgV+NqJg6QTt/lIjcxMraWtc6Ff r/kCWVi3ob9MJjLRds31WoynP2R1uSnnRtiB0eEfrwfLaaI03flXi3L4HfcbLD+DFNiT D7ohom2h3+q3O4VlM5ceZUM/GaQAlCDDs9SCqCKLR0Zro6ZNpinMP94HSkh+88+/iaD7 fqQ/WUVR4XXoX67Uk8p8cAzwCNbkvOzNrFs5SC/IcVQvqfbhxnH53yaaeajA25nUyG8/ qm+LjEem8qSrbK4HIL8tqsDk6ZgpetykfAuQb8mt4U32PPiG6iBXDcFcJ3/UbmLiL+pQ YAiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4ItccC530PkvKRAutMOK7ZEfzTV3mCc7JXsz8tUi8eg=; b=gE0J+ggoo91w21wSENGqvmn2Dzrkg8tPCNAgEMc2Ogc3EkRgNPin7JayAFYBRxN1Mm g3a8+kOcRFwGnof700mcrP640PHS2UyrdVqTJcYdCqRiLMkilFHbi8rZE9rzAwmGKIkk z6mBzXmQ4Dxhkk/EnOcYvK1qj2+5x1MFIyio0a2D+OhG1uainZksbGP1OOuAUWRV8tqh 2azzacW0tYg78BwOPzXttfoZgZRAkGD/QjNrGdUFf2ddeJTi8Fz1vOw2+DgL62ti0e80 clPTkBMNp1+0Q+tow01frT7gfYylMpXSs4pL7c9ECUZIhidMzYffAfwr7vI0p8/c3SFx F8zQ== X-Gm-Message-State: AOAM531OVGNtobsQzNjpxgqJDoY8eFVaa3Bvv3R5M2domdHxIN+3O6Zi uf0k7hMzBjHyk6xV1RWqWcrH2VfAX576zj3jq2o= X-Google-Smtp-Source: ABdhPJwCg2v9bbGKQTY3dNVaZfDRS5gbbvpiG8syDMIIqXpVB5CJtzHEvudOZb0fIeGuSwvrClwnW0N7Qvg4N/mDx+Q= X-Received: by 2002:a1c:f311:: with SMTP id q17mr2910524wmq.28.1604067843823; Fri, 30 Oct 2020 07:24:03 -0700 (PDT) MIME-Version: 1.0 References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> <83o8kjakxx.fsf@gnu.org> <83lffnajes.fsf@gnu.org> In-Reply-To: <83lffnajes.fsf@gnu.org> From: Mauro Aranda Date: Fri, 30 Oct 2020 11:23:51 -0300 Message-ID: Content-Type: multipart/alternative; boundary="00000000000006dce705b2e42677" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000006dce705b2e42677 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> From: Mauro Aranda >> Date: Fri, 30 Oct 2020 11:03:39 -0300 >> Cc: Drew Adams , 14635@debbugs.gnu.org >> >> > Doesn't customizing a face record the original value in some property >> > of the face symbol? If so, reverting the customizations should use >> > those recorded values, I think. >> >> AFAICT, it doesn't right now. I followed the recipe I gave, and then: >> (symbol-plist 'default) >> The relevant properties I see are: >> * face-defface-spec ==> ((t nil)) >> which won't take us anywhere. >> * theme-face, which has the customized value for the user theme, and >> * customized-face, which again, has the customized value. >> >> But I see no immediate reason why we shouldn't start doing it, if you >> think it is OK to use that to solve this issue. My only questions are >> if it would be best to do it in Customize or in faces.el, and if we >> should only special case the default face. > > I'd begin with doing this in Customize, since it is the only user of > this property. I'll try to do it. Thank you. --00000000000006dce705b2e42677 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> From: Mauro Aranda <maurooaranda@gmail.com>
>> Date:= Fri, 30 Oct 2020 11:03:39 -0300
>> Cc: Drew Adams <drew.adams@oracle.com>, 14635@debbugs.gnu.org
>>
>&g= t; > Doesn't customizing a face record the original value in some pr= operty
>> > of the face symbol?=C2=A0 If so, reverting the cust= omizations should use
>> > those recorded values, I think.
&= gt;>
>> AFAICT, it doesn't right now.=C2=A0 I followed the= recipe I gave, and then:
>> (symbol-plist 'default)
>&g= t; The relevant properties I see are:
>> * face-defface-spec =3D= =3D> ((t nil))
>> which won't take us anywhere.
>>= * theme-face, which has the customized value for the user theme, and
&g= t;> * customized-face, which again, has the customized value.
>>= ;
>> But I see no immediate reason why we shouldn't start doi= ng it, if you
>> think it is OK to use that to solve this issue.= =C2=A0 My only questions are
>> if it would be best to do it in Cu= stomize or in faces.el, and if we
>> should only special case the = default face.
>
> I'd begin with doing this in Customize, s= ince it is the only user of
> this property.

I'll try to d= o it.=C2=A0 Thank you.
--00000000000006dce705b2e42677-- From unknown Sun Aug 17 22:13:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Oct 2020 14:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed To: Eli Zaretskii Cc: 14635@debbugs.gnu.org, Drew Adams Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.160415624129952 (code B ref 14635); Sat, 31 Oct 2020 14:58:02 +0000 Received: (at 14635) by debbugs.gnu.org; 31 Oct 2020 14:57:21 +0000 Received: from localhost ([127.0.0.1]:34260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYsJl-0007n2-2W for submit@debbugs.gnu.org; Sat, 31 Oct 2020 10:57:21 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:55775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYsJh-0007mo-UO for 14635@debbugs.gnu.org; Sat, 31 Oct 2020 10:57:20 -0400 Received: by mail-wm1-f51.google.com with SMTP id c9so3817000wml.5 for <14635@debbugs.gnu.org>; Sat, 31 Oct 2020 07:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1VQTCbEDJoC9cUCT9b1hX97yja2Eon2My1yIZN3YKL4=; b=daMbmhRtrOS9daB88uvbJOD6TxUkcnIaahHDIKdG2Vo2aJCbohTMnQPF/XH/R03TMq Ki/mN4QnHGjvmVIvnkldU5i/9FXy7O269gQEjZHG1u9v2Ssa1FmIWiW5tfTOnw7Fzkm2 hpYAo8tBQ4mEwzPSQdq+pTYYvn9ZnC9xgMi28H+eXfr0D7vBN6kheoCfC6hiWWpJIOUl lK8jTMLhmQbviRr99Ci5mjj3TlYTrZpvCxNB1TjDfrAysFmFVp+etpA04Acru5aQRT97 87vblg0rFr/ELRHZIyGX37BksLIxl67aUQWan/mfYOSzCnqh0p1PTby6RDRR6Y+DJask IriA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1VQTCbEDJoC9cUCT9b1hX97yja2Eon2My1yIZN3YKL4=; b=aHTGspuQH7xhg7dUQeAQE+tD34qVTjTqNYE0D55kv9+pdOKHIjf6ViPyI+FRjcb2Ze fa1Vl55IKasy124M2rMJWRFXx5b6QaZWQRn7+9QbRURABlyGqwCSk3g4OFeMwQf3pT2e ZEWc6+LjlonFeHuIUS6TfLV2U8M73N9tCZhnN+gX+bpVIDTaDVylSD0meiPKaS+tmkB5 22/wuzKrWQtW1xp0gZSphZJVOPr1lsONBBQ8ke/A0FBYy4C3Z3+vRAc8A+KfmiWup3yX ciRwybY0h8BVs7426ykAliCTRf8d3nju0QWzHk3LrrA0MMPwgWtRzJKHl2Q1HahKc7u+ hVww== X-Gm-Message-State: AOAM531l/FCVUYYgMPYYxolDNWCHNSRsSRuZ+lRO9FfvTniH258se9Xo jSYK/fMP5CMBWt9SDJqIzR3/kwOs9yXg0rUKJhE= X-Google-Smtp-Source: ABdhPJxpB292EG+omyTeNyXD4KudBo7+D7QcuMJkGjrF+TEcbbN40X1F1Kes9e0CT0ZNE961q7RRlL2Nj2zTRaviKk8= X-Received: by 2002:a1c:bac1:: with SMTP id k184mr2827496wmf.76.1604156231915; Sat, 31 Oct 2020 07:57:11 -0700 (PDT) MIME-Version: 1.0 References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> <83o8kjakxx.fsf@gnu.org> <83lffnajes.fsf@gnu.org> In-Reply-To: From: Mauro Aranda Date: Sat, 31 Oct 2020 11:56:59 -0300 Message-ID: Content-Type: multipart/mixed; boundary="0000000000005e350405b2f8ba3a" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005e350405b2f8ba3a Content-Type: multipart/alternative; boundary="0000000000005e350205b2f8ba38" --0000000000005e350205b2f8ba38 Content-Type: text/plain; charset="UTF-8" Mauro Aranda writes: > Eli Zaretskii writes: > >>> From: Mauro Aranda >>> Date: Fri, 30 Oct 2020 11:03:39 -0300 >>> Cc: Drew Adams , 14635@debbugs.gnu.org >>> >>> > Doesn't customizing a face record the original value in some property >>> > of the face symbol? If so, reverting the customizations should use >>> > those recorded values, I think. >>> >>> AFAICT, it doesn't right now. I followed the recipe I gave, and then: >>> (symbol-plist 'default) >>> The relevant properties I see are: >>> * face-defface-spec ==> ((t nil)) >>> which won't take us anywhere. >>> * theme-face, which has the customized value for the user theme, and >>> * customized-face, which again, has the customized value. >>> >>> But I see no immediate reason why we shouldn't start doing it, if you >>> think it is OK to use that to solve this issue. My only questions are >>> if it would be best to do it in Customize or in faces.el, and if we >>> should only special case the default face. >> >> I'd begin with doing this in Customize, since it is the only user of >> this property. > > I'll try to do it. Thank you. I attach a patch that makes Customize store the original value of the default face if the user ever changes it, and then uses it when reverting. Basically, Customize tell faces.el the exactly spec to set, by putting a fake entry under the user theme (and later removing it). --0000000000005e350205b2f8ba38 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Mauro Aranda <maurooaranda@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>= > From: Mauro Aranda <mauro= oaranda@gmail.com>
>>> Date: Fri, 30 Oct 2020 11:03:39 -= 0300
>>> Cc: Drew Adams <drew.adams@oracle.com>, 14635@debbugs.gnu.org
>>>
>>> > Doesn= 9;t customizing a face record the original value in some property
>&g= t;> > of the face symbol?=C2=A0 If so, reverting the customizations s= hould use
>>> > those recorded values, I think.
>>&= gt;
>>> AFAICT, it doesn't right now.=C2=A0 I followed the= recipe I gave, and then:
>>> (symbol-plist 'default)
&g= t;>> The relevant properties I see are:
>>> * face-deffac= e-spec =3D=3D> ((t nil))
>>> which won't take us anywher= e.
>>> * theme-face, which has the customized value for the use= r theme, and
>>> * customized-face, which again, has the custom= ized value.
>>>
>>> But I see no immediate reason = why we shouldn't start doing it, if you
>>> think it is OK = to use that to solve this issue.=C2=A0 My only questions are
>>>= ; if it would be best to do it in Customize or in faces.el, and if we
&g= t;>> should only special case the default face.
>>
>&g= t; I'd begin with doing this in Customize, since it is the only user of=
>> this property.
>
> I'll try to do it.=C2=A0 Th= ank you.

I attach a patch that makes Customize store the original va= lue of the
default face if the user ever changes it, and then uses it wh= en
reverting.

Basically, Customize tell faces.el the exactly spec= to set, by putting a
fake entry under the user theme (and later removin= g it).
--0000000000005e350205b2f8ba38-- --0000000000005e350405b2f8ba3a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-reverting-the-default-face-to-standard-themed-st.patch" Content-Disposition: attachment; filename="0001-Fix-reverting-the-default-face-to-standard-themed-st.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kgxt608b0 RnJvbSA4OGJjZjU0YTQxMzhhY2Q2NzgyYzcwYWM4ZmZlOWRiNWUwOTg5NTZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFNhdCwgMzEgT2N0IDIwMjAgMTA6Mzk6MzEgLTAzMDAKU3ViamVjdDogW1BBVENIXSBG aXggcmV2ZXJ0aW5nIHRoZSBkZWZhdWx0IGZhY2UgdG8gc3RhbmRhcmQvdGhlbWVkIHN0YXRlIGlu CiBHVUlzCgoqIGxpc3AvY3VzLWVkaXQuZWwgKGN1c3RvbS1mYWNlLXNldCwgY3VzdG9tLWZhY2Ut bWFyay10by1zYXZlKQooY3VzdG9tLWZhY2Utc2F2ZSk6IFJlY29yZCB0aGUgZGVmYXVsdCAoc3Rh bmRhcmQgb3IgdGhlbWVkKSBhdHRyaWJ1dGVzCm9mIHRoZSBkZWZhdWx0IGZhY2UgaW4gYSBzeW1i b2wgcHJvcGVydHkuCihjdXN0b20tZmFjZS1yZXNldC1zYXZlZCwgY3VzdG9tLWZhY2UtbWFyay10 by1yZXNldC1zdGFuZGFyZCk6IFdoZW4KcmV2ZXJ0aW5nIHRoZSBkZWZhdWx0IGZhY2UgdG8gdGhl IHN0YW5kYXJkIG9yIHRoZW1lZCBzdGF0ZSwgdXNlIHRoZQpkZWZhdWx0IGF0dHJpYnV0ZXMgd2Ug cmVjb3JkZWQsIGluc3RlYWQgb2YgcmVseWluZyBpbiB0aGUgZGVmZmFjZSBzcGVjCm9mIHRoZSBk ZWZhdWx0IGZhY2UsIHNpbmNlIHRoYXQgZG9lc24ndCBnaXZlIGVub3VnaCBpbmZvcm1hdGlvbiB0 bwpyZXNldCBhbGwgYXR0cmlidXRlcywgbGlrZSBmb3JlZ3JvdW5kLCBmYW1pbHksIGV0Yy4gIChC dWcjMTQ2MzUpCi0tLQogbGlzcC9jdXMtZWRpdC5lbCB8IDUwICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQ2IGluc2VydGlv bnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9jdXMtZWRpdC5lbCBiL2xp c3AvY3VzLWVkaXQuZWwKaW5kZXggNzY5YTY5YTUwZi4uZGI3NDhjMTA5NiAxMDA2NDQKLS0tIGEv bGlzcC9jdXMtZWRpdC5lbAorKysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC0zODk1LDYgKzM4OTUs MTggQEAgY3VzdG9tLWZhY2Utc2V0CiAgICAgICAoc2V0cSBjb21tZW50IG5pbCkKICAgICAgIDs7 IE1ha2UgdGhlIGNvbW1lbnQgaW52aXNpYmxlIGJ5IGhhbmQgaWYgaXQncyBlbXB0eQogICAgICAg KGN1c3RvbS1jb21tZW50LWhpZGUgY29tbWVudC13aWRnZXQpKQorICAgIDs7IFdoZW4gbW9kaWZ5 aW5nIHRoZSBkZWZhdWx0IGZhY2UsIHdlIG5lZWQgdG8gc2F2ZSB0aGUgc3RhbmRhcmQgb3IgdGhl bWVkCisgICAgOzsgYXR0cnMsIGluIGNhc2UgdGhlIHVzZXIgYXNrcyB0byByZXZlcnQgdG8gdGhl bSBpbiB0aGUgZnV0dXJlLgorICAgIDs7IEluIEdVSXMsIHdoZW4gcmVzZXR0aW5nIHRoZSBhdHRy aWJ1dGVzIG9mIHRoZSBkZWZhdWx0IGZhY2UsIHRoZSBmcmFtZQorICAgIDs7IHBhcmFtZXRlcnMg YXNzb2NpYXRlZCB3aXRoIHRoaXMgZmFjZSB3b24ndCBjaGFuZ2UsIHVubGVzcyBleHBsaWNpdGx5 CisgICAgOzsgcGFzc2VkIGEgdmFsdWUuICBTdG9yaW5nIHRoaXMga25vd24gYXR0cnMgYWxsb3dz IHVzIHRvIHRlbGwgZmFjZXMuZWwgdG8KKyAgICA7OyBzZXQgdGhvc2UgYXR0cmlidXRlcyB0byBz cGVjaWZpZWQgdmFsdWVzLCBtYWtpbmcgdGhlIHJlbGV2YW50IGZyYW1lCisgICAgOzsgcGFyYW1l dGVycyBzdGF5IGluIHN5bmMgd2l0aCB0aGUgZGVmYXVsdCBmYWNlLgorICAgICh3aGVuIChhbmQg KGVxIHN5bWJvbCAnZGVmYXVsdCkKKyAgICAgICAgICAgICAgIChub3QgKGdldCBzeW1ib2wgJ2N1 c3RvbS1mYWNlLWRlZmF1bHQtYXR0cnMpKQorICAgICAgICAgICAgICAgKG1lbXEgKGN1c3RvbS1m YWNlLXN0YXRlIHN5bWJvbCkgJyhzdGFuZGFyZCB0aGVtZWQpKSkKKyAgICAgIChwdXQgc3ltYm9s ICdjdXN0b20tZmFjZS1kZWZhdWx0LWF0dHJzCisgICAgICAgICAgIChjdXN0b20tZmFjZS1nZXQt Y3VycmVudC1zcGVjIHN5bWJvbCkpKQogICAgIChjdXN0b20tcHVzaC10aGVtZSAndGhlbWUtZmFj ZSBzeW1ib2wgJ3VzZXIgJ3NldCB2YWx1ZSkKICAgICAoZmFjZS1zcGVjLXNldCBzeW1ib2wgdmFs dWUgJ2N1c3RvbWl6ZWQtZmFjZSkKICAgICAocHV0IHN5bWJvbCAnZmFjZS1jb21tZW50IGNvbW1l bnQpCkBAIC0zOTEzLDYgKzM5MjUsMTIgQEAgY3VzdG9tLWZhY2UtbWFyay10by1zYXZlCiAgICAg ICAoc2V0cSBjb21tZW50IG5pbCkKICAgICAgIDs7IE1ha2UgdGhlIGNvbW1lbnQgaW52aXNpYmxl IGJ5IGhhbmQgaWYgaXQncyBlbXB0eQogICAgICAgKGN1c3RvbS1jb21tZW50LWhpZGUgY29tbWVu dC13aWRnZXQpKQorICAgIDs7IFNlZSB0aGUgY29tbWVudHMgaW4gYGN1c3RvbS1mYWNlLXNldCcu CisgICAgKHdoZW4gKGFuZCAoZXEgc3ltYm9sICdkZWZhdWx0KQorICAgICAgICAgICAgICAgKG5v dCAoZ2V0IHN5bWJvbCAnY3VzdG9tLWZhY2UtZGVmYXVsdC1hdHRycykpCisgICAgICAgICAgICAg ICAobWVtcSAoY3VzdG9tLWZhY2Utc3RhdGUgc3ltYm9sKSAnKHN0YW5kYXJkIHRoZW1lZCkpKQor ICAgICAgKHB1dCBzeW1ib2wgJ2N1c3RvbS1mYWNlLWRlZmF1bHQtYXR0cnMKKyAgICAgICAgICAg KGN1c3RvbS1mYWNlLWdldC1jdXJyZW50LXNwZWMgc3ltYm9sKSkpCiAgICAgKGN1c3RvbS1wdXNo LXRoZW1lICd0aGVtZS1mYWNlIHN5bWJvbCAndXNlciAnc2V0IHZhbHVlKQogICAgIChmYWNlLXNw ZWMtc2V0IHN5bWJvbCB2YWx1ZSAoaWYgc3RhbmRhcmQgJ3Jlc2V0ICdzYXZlZC1mYWNlKSkKICAg ICAocHV0IHN5bWJvbCAnZmFjZS1jb21tZW50IGNvbW1lbnQpCkBAIC0zOTI2LDcgKzM5NDQsMTQg QEAgY3VzdG9tLWZhY2Utc3RhdGUtc2V0LWFuZC1yZWRyYXcKIAogKGRlZnVuIGN1c3RvbS1mYWNl LXNhdmUgKHdpZGdldCkKICAgIlNhdmUgdGhlIGZhY2UgZWRpdGVkIGJ5IFdJREdFVC4iCi0gIChs ZXQgKChmb3JtICh3aWRnZXQtZ2V0IHdpZGdldCA6Y3VzdG9tLWZvcm0pKSkKKyAgKGxldCAoKGZv cm0gKHdpZGdldC1nZXQgd2lkZ2V0IDpjdXN0b20tZm9ybSkpCisgICAgICAgIChzeW1ib2wgKHdp ZGdldC12YWx1ZSB3aWRnZXQpKSkKKyAgICA7OyBTZWUgdGhlIGNvbW1lbnRzIGluIGBjdXN0b20t ZmFjZS1zZXQnLgorICAgICh3aGVuIChhbmQgKGVxIHN5bWJvbCAnZGVmYXVsdCkKKyAgICAgICAg ICAgICAgIChub3QgKGdldCBzeW1ib2wgJ2N1c3RvbS1mYWNlLWRlZmF1bHQtYXR0cnMpKQorICAg ICAgICAgICAgICAgKG1lbXEgKGN1c3RvbS1mYWNlLXN0YXRlIHN5bWJvbCkgJyhzdGFuZGFyZCB0 aGVtZWQpKSkKKyAgICAgIChwdXQgc3ltYm9sICdjdXN0b20tZmFjZS1kZWZhdWx0LWF0dHJzCisg ICAgICAgICAgIChjdXN0b20tZmFjZS1nZXQtY3VycmVudC1zcGVjIHN5bWJvbCkpKQogICAgIChp ZiAobWVtcSBmb3JtICcoYWxsIGxpc3ApKQogICAgICAgICAoY3VzdG9tLWZhY2UtbWFyay10by1z YXZlIHdpZGdldCkKICAgICAgIDs7IFRoZSB1c2VyIGlzIHdvcmtpbmcgb24gb25seSBhIHNlbGVj dGVkIHRlcm1pbmFsIHR5cGU7CkBAIC0zOTQ5LDEwICszOTc0LDIwIEBAIGN1c3RvbS1mYWNlLXJl c2V0LXNhdmVkCiAJIChzYXZlZC1mYWNlIChnZXQgZmFjZSAnc2F2ZWQtZmFjZSkpCiAJIChjb21t ZW50IChnZXQgZmFjZSAnc2F2ZWQtZmFjZS1jb21tZW50KSkKIAkgKGNvbW1lbnQtd2lkZ2V0ICh3 aWRnZXQtZ2V0IHdpZGdldCA6Y29tbWVudC13aWRnZXQpKSkKKyAgICA7OyBJZiByZXNldHRpbmcg dGhlIGRlZmF1bHQgZmFjZSBhbmQgdGhlcmUgaXNuJ3QgYSBzYXZlZCB2YWx1ZSwKKyAgICA7OyBw dXNoIGEgZmFrZSB1c2VyIHNldHRpbmcsIHNvIHRoYXQgcmV2ZXJ0aW5nIHRvIHRoZSBkZWZhdWx0 CisgICAgOzsgYXR0cmlidXRlcyB3b3Jrcy4KICAgICAoY3VzdG9tLXB1c2gtdGhlbWUgJ3RoZW1l LWZhY2UgZmFjZSAndXNlcgotCQkgICAgICAgKGlmIHNhdmVkLWZhY2UgJ3NldCAncmVzZXQpCi0J CSAgICAgICBzYXZlZC1mYWNlKQorICAgICAgICAgICAgICAgICAgICAgICAoaWYgKG9yIHNhdmVk LWZhY2UgKGVxIGZhY2UgJ2RlZmF1bHQpKSAnc2V0ICdyZXNldCkKKyAgICAgICAgICAgICAgICAg ICAgICAgKG9yIHNhdmVkLWZhY2UKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IElmIHRo aXMgaXMgdCwgdGhlbiBNT0RFIGlzICdyZXNldCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg IDs7IGFuZCBgY3VzdG9tLXB1c2gtdGhlbWUnIGlnbm9yZXMgdGhpcyBhcmd1bWVudC4KKyAgICAg ICAgICAgICAgICAgICAgICAgICAgIChub3QgKGVxIGZhY2UgJ2RlZmF1bHQpKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgKGdldCBmYWNlICdjdXN0b20tZmFjZS1kZWZhdWx0LWF0dHJzKSkp CiAgICAgKGZhY2Utc3BlYy1zZXQgZmFjZSBzYXZlZC1mYWNlICdzYXZlZC1mYWNlKQorICAgICh3 aGVuIChhbmQgKG5vdCBzYXZlZC1mYWNlKSAoZXEgZmFjZSAnZGVmYXVsdCkpCisgICAgICA7OyBS ZW1vdmUgdGhlIGZha2UgdXNlciBzZXR0aW5nLgorICAgICAgKGN1c3RvbS1wdXNoLXRoZW1lICd0 aGVtZS1mYWNlIGZhY2UgJ3VzZXIgJ3Jlc2V0KSkKICAgICAocHV0IGZhY2UgJ2ZhY2UtY29tbWVu dCBjb21tZW50KQogICAgIChwdXQgZmFjZSAnY3VzdG9taXplZC1mYWNlLWNvbW1lbnQgbmlsKQog ICAgICh3aWRnZXQtdmFsdWUtc2V0IGNoaWxkIHNhdmVkLWZhY2UpCkBAIC0zOTc0LDggKzQwMDks MTUgQEAgY3VzdG9tLWZhY2UtbWFyay10by1yZXNldC1zdGFuZGFyZAogCSAoY29tbWVudC13aWRn ZXQgKHdpZGdldC1nZXQgd2lkZ2V0IDpjb21tZW50LXdpZGdldCkpKQogICAgICh1bmxlc3MgdmFs dWUKICAgICAgICh1c2VyLWVycm9yICJObyBzdGFuZGFyZCBzZXR0aW5nIGZvciB0aGlzIGZhY2Ui KSkKLSAgICAoY3VzdG9tLXB1c2gtdGhlbWUgJ3RoZW1lLWZhY2Ugc3ltYm9sICd1c2VyICdyZXNl dCkKKyAgICA7OyBJZiBlcmFzaW5nIGN1c3RvbWl6YXRpb25zIGZvciB0aGUgZGVmYXVsdCBmYWNl LCBwdXNoIGEgZmFrZSB1c2VyIHNldHRpbmcsCisgICAgOzsgc28gdGhhdCByZXZlcnRpbmcgdG8g dGhlIGRlZmF1bHQgYXR0cmlidXRlcyB3b3Jrcy4KKyAgICAoY3VzdG9tLXB1c2gtdGhlbWUgJ3Ro ZW1lLWZhY2Ugc3ltYm9sICd1c2VyCisgICAgICAgICAgICAgICAgICAgICAgIChpZiAoZXEgc3lt Ym9sICdkZWZhdWx0KSAnc2V0ICdyZXNldCkKKyAgICAgICAgICAgICAgICAgICAgICAgKG9yIChu b3QgKGVxIHN5bWJvbCAnZGVmYXVsdCkpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAoZ2V0 IHN5bWJvbCAnY3VzdG9tLWZhY2UtZGVmYXVsdC1hdHRycykpKQogICAgIChmYWNlLXNwZWMtc2V0 IHN5bWJvbCB2YWx1ZSAncmVzZXQpCisgICAgOzsgUmVtb3ZlIHRoZSBmYWtlIHVzZXIgc2V0dGlu Zy4KKyAgICAoY3VzdG9tLXB1c2gtdGhlbWUgJ3RoZW1lLWZhY2Ugc3ltYm9sICd1c2VyICdyZXNl dCkKICAgICAocHV0IHN5bWJvbCAnZmFjZS1jb21tZW50IG5pbCkKICAgICAocHV0IHN5bWJvbCAn Y3VzdG9taXplZC1mYWNlLWNvbW1lbnQgbmlsKQogICAgIChpZiAoYW5kIGN1c3RvbS1yZXNldC1z dGFuZGFyZC1mYWNlcy1saXN0Ci0tIAoyLjI5LjAKCg== --0000000000005e350405b2f8ba3a-- From unknown Sun Aug 17 22:13:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14635: 24.3.50; Regression in Customize: no revert changes Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Feb 2022 23:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed To: Mauro Aranda Cc: Eli Zaretskii , 14635@debbugs.gnu.org, Drew Adams Received: via spool by 14635-submit@debbugs.gnu.org id=B14635.164410435629423 (code B ref 14635); Sat, 05 Feb 2022 23:40:01 +0000 Received: (at 14635) by debbugs.gnu.org; 5 Feb 2022 23:39:16 +0000 Received: from localhost ([127.0.0.1]:35901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGUeC-0007eV-Mq for submit@debbugs.gnu.org; Sat, 05 Feb 2022 18:39:16 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGUeB-0007eG-4p for 14635@debbugs.gnu.org; Sat, 05 Feb 2022 18:39:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=spcj/sw9cpU7Ro8ARFN6m3jCnW1PFuOXIiaKe876Roc=; b=LV7mIiIT/BPiIcDyzzMzKypZNg C2H4o+M0ovQExaBEgPOXmxSMgJ5lTKgJJ86nNeRTnO1iXTYXsrOyi9UNldPI6ysk4rd8aM4/86mEx 4MdeElR7BNhPrMRI0CXNFnVJy+BlpM+0BUdv6C5ekN0VRvHxOM+EchtmxxaSZCmcygVc=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGUe1-000576-OS; Sun, 06 Feb 2022 00:39:08 +0100 From: Lars Ingebrigtsen References: <329c5dbd-dfc7-406e-9957-71f3b94409b0@default> <83o8kjakxx.fsf@gnu.org> <83lffnajes.fsf@gnu.org> X-Now-Playing: Brian Eno's _Another Green World_: "St. Elmo's Fire" Date: Sun, 06 Feb 2022 00:39:05 +0100 In-Reply-To: (Mauro Aranda's message of "Sat, 31 Oct 2020 11:56:59 -0300") Message-ID: <87y22o9946.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > I attach a patch that makes Customize store the original value of the > default face if the user ever changes it, and then uses it when > reverting. > > Basically, Customize tell faces.el the exactl [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mauro Aranda writes: > I attach a patch that makes Customize store the original value of the > default face if the user ever changes it, and then uses it when > reverting. > > Basically, Customize tell faces.el the exactly spec to set, by putting a > fake entry under the user theme (and later removing it). Looks like this patch was forgotten, so I've now pushed it to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 05 18:39:22 2022 Received: (at control) by debbugs.gnu.org; 5 Feb 2022 23:39:22 +0000 Received: from localhost ([127.0.0.1]:35904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGUeH-0007eo-TU for submit@debbugs.gnu.org; Sat, 05 Feb 2022 18:39:22 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGUeG-0007eN-F3 for control@debbugs.gnu.org; Sat, 05 Feb 2022 18:39:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0aJmitxN2VO8uU/T7g8JkpX+047j0RxlMVcVmMrvX0g=; b=fNNFznFlAScvnetijFOmDB4bGO AuyZoKCptt1Jt9GNbaaYMrqduHiwqVXdCJhUO9eyg5UPt9wTx0ILETe2B3EIcw13WsG7yUdyvpjhc zkcZS0joULaZlroNfbAjx9QV3WihoQ+uTK4F4cxK4N3lfwoZB5HdWoHjy3uzuNJ7oOVk=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGUe8-00057G-EW for control@debbugs.gnu.org; Sun, 06 Feb 2022 00:39:14 +0100 Date: Sun, 06 Feb 2022 00:39:11 +0100 Message-Id: <87wni89940.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #14635 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 14635 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 14635 29.1 quit