GNU bug report logs - #14611
Suggest warning: forward-sexp not from program

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14611 in the body.
You can then email your comments to 14611 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Suggest warning: forward-sexp not from program
Date: Thu, 13 Jun 2013 18:14:54 +0200

Hi,

as `forward-sexp-function' might be set by users, `forward-sexp' is susceptible to fail when built into a program - which executes then set new binding.
Just came across that mistake.

Suggest a warning in it's docstring, saying something like: "Don't use..."
While pointing at core-function `scan-sexp' resp. `forward-sexp-function'.

Thanks,

Andreas

Message #10 received at 14611-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 14611-done <at> debbugs.gnu.org
Subject: Re: bug#14611: Suggest warning: forward-sexp not from program
Date: Thu, 13 Jun 2013 12:41:18 -0400

Andreas Röhler wrote:

> as `forward-sexp-function' might be set by users, `forward-sexp' is
> susceptible to fail when built into a program - which executes then
> set new binding. Just came across that mistake.

So let-bind forward-sexp-function around any calls where you think that
might happen.
forward-sexp is user in 100s of places in lisp/.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.