GNU bug report logs - #14548
24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays

Previous Next

Full log

View this message in rfc822 format

From: E Sabof <esabof <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Glenn Morris <rgm <at> gnu.org>, 14548 <at> debbugs.gnu.org
Subject: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays
Date: Thu, 13 Jun 2013 15:39:49 +0100

[Message part 1 (text/plain, inline)]

On Thu, Jun 13, 2013 at 3:18 PM, Stefan Monnier <monnier <at> iro.umontreal.ca>wrote:

> >> !        (let* ((cur-ovs (overlays-in (point) (1+ (point))))
> >> !               (thumb-ov (car (cl-remove-if-not
> >> !                               (lambda (ov) (overlay-get ov
> 'thumb-file))
> >> !                               cur-ovs))))
> >> !          (if thumb-ov
> >> !              (delete-overlay thumb-ov)
>
> BTW, now that I actually look at the code, I twonder why it doesn't use
> remove-overlays.
>
>
>         Stefan
>

It's a toggler. It will remove the overlay if present, or create one. And
remove-overlays always returns nil.

Evgeni

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.