From unknown Tue Jun 17 20:15:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14548 <14548@debbugs.gnu.org> To: bug#14548 <14548@debbugs.gnu.org> Subject: Status: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays Reply-To: bug#14548 <14548@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:15:05 +0000 retitle 14548 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs confli= cts with other modes using overlays reassign 14548 emacs submitter 14548 E Sabof severity 14548 normal tag 14548 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 09:30:57 2013 Received: (at submit) by debbugs.gnu.org; 3 Jun 2013 13:30:57 +0000 Received: from localhost ([127.0.0.1]:48851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjUqb-0006MW-D4 for submit@debbugs.gnu.org; Mon, 03 Jun 2013 09:30:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39245) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjUqS-0006M0-M2 for submit@debbugs.gnu.org; Mon, 03 Jun 2013 09:30:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjUoW-0000Re-26 for submit@debbugs.gnu.org; Mon, 03 Jun 2013 09:28:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjUoV-0000Ra-WC for submit@debbugs.gnu.org; Mon, 03 Jun 2013 09:28:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjUoO-000558-2C for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2013 09:28:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjUoH-0000PA-Ib for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2013 09:28:35 -0400 Received: from mail-qe0-f47.google.com ([209.85.128.47]:58546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjUoH-0000P6-E0 for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2013 09:28:29 -0400 Received: by mail-qe0-f47.google.com with SMTP id 1so362948qec.6 for ; Mon, 03 Jun 2013 06:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=C/ijOHizEst1eBFVXbqDk18u3xsJhNsEMLhr4BP+cy0=; b=hh8+YnWjo9pil4+xTQN+tyAIe62IusaZFNtvm/C39LjYsjPtChXjNExQo4at19kEth VajjP4wu0wnMawWr2IhCvJL4+P4MZIuSmH6uSY76Mwr0J1IqqBzL2VMKQZzvhm7wt680 fW0X0/eF1vO3EYTabHlydA6aMaDJOlb+gNAPi1jktOHF4sVZTtZYfYGxpNiRhX1zDAyY cBOVkgvYbZ8DKFz+BrCv2DPe5th7c7ixIZhBdfWgsfZ/dMYgZYbdZhxLuphwr3Ld+/nM t1HeDl8YXUW7byEKz4FSkcXaKXmjwpEmOMPVbLD1TeovIM3Y8kw2ELW96rA+Mxdz8g9G EGPw== MIME-Version: 1.0 X-Received: by 10.229.136.213 with SMTP id s21mr7903880qct.9.1370266108944; Mon, 03 Jun 2013 06:28:28 -0700 (PDT) Received: by 10.49.18.162 with HTTP; Mon, 3 Jun 2013 06:28:28 -0700 (PDT) Date: Mon, 3 Jun 2013 14:28:28 +0100 Message-ID: Subject: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays From: E Sabof To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=002354790f1cabf1f404de3ff002 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) --002354790f1cabf1f404de3ff002 Content-Type: text/plain; charset=ISO-8859-1 One such mode is stripe-buffer, which can be fonud here: https://github.com/sabof/stripe-buffer the definition below fixes the problem. Evgeni (ad-unadvise 'image-dired-dired-toggle-marked-thumbs) ; stripe-buffer monkey-patches the function. (defun image-dired-dired-toggle-marked-thumbs (&optional arg) "Toggle thumbnails in front of file names in the dired buffer. If no marked file could be found, insert or hide thumbnails on the current line. ARG, if non-nil, specifies the files to use instead of the marked files. If ARG is an integer, use the next ARG (or previous -ARG, if ARG<0) files." (interactive "P") (dired-map-over-marks (let* ((image-pos (dired-move-to-filename)) (image-file (dired-get-filename nil t)) thumb-file overlay) (when (and image-file (string-match-p (image-file-name-regexp) image-file)) (setq thumb-file (image-dired-get-thumbnail-image image-file)) ;; If image is not already added, then add it. (let* (( cur-ovs (overlays-in (point) (1+ (point)))) ( thumb-ov (car (cl-remove-if-not (lambda (ov) (overlay-get ov 'thumb-file)) cur-ovs)))) (if thumb-ov (delete-overlay thumb-ov) (progn (put-image thumb-file image-pos) (setq overlay (cl-loop for o in (overlays-in (point) (1+ (point))) when (overlay-get o 'put-image) collect o into ov finally return (car ov))) (overlay-put overlay 'image-file image-file) (overlay-put overlay 'thumb-file thumb-file)))))) arg ; Show or hide image on ARG next files. 'show-progress) ; Update dired display after each image is updated. (add-hook 'dired-after-readin-hook 'image-dired-dired-after-readin-hook nil t)) --002354790f1cabf1f404de3ff002 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
One such mode is stripe-buffer, which can be fonud here:

the defin= ition below fixes the problem.

Evgeni

(ad-unadvise 'image= -dired-dired-toggle-marked-thumbs) ; stripe-buffer monkey-patches the funct= ion.

=A0(defun image-dired-dired-toggle-m= arked-thumbs (&optional arg)
=A0 =A0 "Toggle thumbnails in front of file names in the dired bu= ffer.
If no marked file could be found, insert or hide thumbnails= on the
current line. =A0ARG, if non-nil, specifies the files to = use instead
of the marked files. =A0If ARG is an integer, use the next ARG (or
previous -ARG, if ARG<0) files."
=A0 =A0 (interact= ive "P")
=A0 =A0 (dired-map-over-marks
=A0 = =A0 =A0(let* ((image-pos =A0(dired-move-to-filename))
=A0 =A0 =A0 =A0 =A0 =A0 (image-file (dired-get-filename nil t))
<= div>=A0 =A0 =A0 =A0 =A0 =A0 thumb-file
=A0 =A0 =A0 =A0 =A0 =A0 ov= erlay)
=A0 =A0 =A0 =A0(when (and image-file
=A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 (string-match-p (image-file-name-regexp) image-fil= e))
=A0 =A0 =A0 =A0 =A0(setq thumb-file (image-dired-get-thumbnail-image i= mage-file))
=A0 =A0 =A0 =A0 =A0;; If image is not already added, = then add it.
=A0 =A0 =A0 =A0 =A0(let* (( cur-ovs (overlays-in (po= int) (1+ (point))))
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ( thumb-ov (car (cl-remove-if-not
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(lambda= (ov) (overlay-get ov 'thumb-file))
=A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0cur-ovs))))
=A0 =A0 = =A0 =A0 =A0 =A0(if thumb-ov
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(delete-overlay thumb-ov)
=A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0(progn
=A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0(put-image thumb-file image-pos)
=A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0(setq overlay
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0(cl-loop for o in (overlays-in (point) (1+ (point)))
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 when (= overlay-get o 'put-image) collect o into ov
=A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 finally return (car ov)))
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(overlay-put overlay 'image= -file image-file)
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(overlay-put overlay 'thumb-fil= e thumb-file))))))
=A0 =A0 =A0arg =A0 =A0 =A0 =A0 =A0 =A0 ; Show = or hide image on ARG next files.
=A0 =A0 =A0'show-progress) ;= Update dired display after each image is updated.
=A0 =A0 (add-hook 'dired-after-readin-hook
=A0 =A0 =A0 = =A0 =A0 =A0 =A0 'image-dired-dired-after-readin-hook nil t))
--002354790f1cabf1f404de3ff002-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 15:09:06 2013 Received: (at 14548) by debbugs.gnu.org; 11 Jun 2013 19:09:06 +0000 Received: from localhost ([127.0.0.1]:56941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmTwI-0001wf-DI for submit@debbugs.gnu.org; Tue, 11 Jun 2013 15:09:06 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37716 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmTwG-0001wX-3i for 14548@debbugs.gnu.org; Tue, 11 Jun 2013 15:09:04 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UmTvy-0007xh-Rh; Tue, 11 Jun 2013 15:08:46 -0400 From: Glenn Morris To: E Sabof Subject: Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays References: X-Spook: Axis of Evil Islam Abduganievich Karimov Juiliett Class X-Ran: k5\(dIKqq)4IIE$5~4U\BZXWt!fD"yasYh,[-]'u3 X-Hue: blue X-Attribution: GM Date: Tue, 11 Jun 2013 15:08:46 -0400 In-Reply-To: (E. Sabof's message of "Mon, 3 Jun 2013 14:28:28 +0100") Message-ID: <1qr4g8lb29.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: 14548 Cc: 14548@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) E Sabof wrote: > One such mode is stripe-buffer, which can be fonud here: > > https://github.com/sabof/stripe-buffer > > the definition below fixes the problem. Things are much, much more likely to be applied if they come as diffs with an explanation of what the change is going, rather than "here's a new version of the function with no explanation". IIUC, the issue is that image-dired-dired-toggle-marked-thumbs can remove overlays from other packages, and you suggest a fix like the following? The idea seems fine, but as written it won't work without requiring cl-lib at run-time. *** lisp/image-dired.el 2013-02-17 00:45:53 +0000 --- lisp/image-dired.el 2013-06-11 19:00:18 +0000 *************** *** 657,665 **** (string-match-p (image-file-name-regexp) image-file)) (setq thumb-file (image-dired-get-thumbnail-image image-file)) ;; If image is not already added, then add it. ! (let ((cur-ov (overlays-in (point) (1+ (point))))) ! (if cur-ov ! (delete-overlay (car cur-ov)) (put-image thumb-file image-pos) (setq overlay (cl-loop for o in (overlays-in (point) (1+ (point))) --- 657,668 ---- (string-match-p (image-file-name-regexp) image-file)) (setq thumb-file (image-dired-get-thumbnail-image image-file)) ;; If image is not already added, then add it. ! (let* ((cur-ovs (overlays-in (point) (1+ (point)))) ! (thumb-ov (car (cl-remove-if-not ! (lambda (ov) (overlay-get ov 'thumb-file)) ! cur-ovs)))) ! (if thumb-ov ! (delete-overlay thumb-ov) (put-image thumb-file image-pos) (setq overlay (cl-loop for o in (overlays-in (point) (1+ (point))) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 17:56:44 2013 Received: (at 14548) by debbugs.gnu.org; 11 Jun 2013 21:56:45 +0000 Received: from localhost ([127.0.0.1]:57168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmWYV-00086V-LL for submit@debbugs.gnu.org; Tue, 11 Jun 2013 17:56:44 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:46280) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmWYT-000868-Pd for 14548@debbugs.gnu.org; Tue, 11 Jun 2013 17:56:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpYtM/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYHCxQYDSSIHgaxH5AOkQoDpHqBXoMT X-IPAS-Result: Av4EABK/CFFFpYtM/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYHCxQYDSSIHgaxH5AOkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="16172809" Received: from 69-165-139-76.dsl.teksavvy.com (HELO pastel.home) ([69.165.139.76]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 Jun 2013 17:56:14 -0400 Received: by pastel.home (Postfix, from userid 20848) id 1AFAF6797E; Tue, 11 Jun 2013 17:56:19 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays Message-ID: References: <1qr4g8lb29.fsf@fencepost.gnu.org> Date: Tue, 11 Jun 2013 17:56:19 -0400 In-Reply-To: <1qr4g8lb29.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 11 Jun 2013 15:08:46 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 14548 Cc: 14548@debbugs.gnu.org, E Sabof X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > The idea seems fine, but as written it won't work without requiring > cl-lib at run-time. That's fine for non-preloaded packages. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 18:12:36 2013 Received: (at 14548) by debbugs.gnu.org; 11 Jun 2013 22:12:36 +0000 Received: from localhost ([127.0.0.1]:57227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmWns-0000EV-Hu for submit@debbugs.gnu.org; Tue, 11 Jun 2013 18:12:36 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:40948 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmWnq-0000EJ-Kc for 14548@debbugs.gnu.org; Tue, 11 Jun 2013 18:12:35 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UmWnY-00061J-LG; Tue, 11 Jun 2013 18:12:16 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays References: <1qr4g8lb29.fsf@fencepost.gnu.org> X-Spook: national information infrastructure Ruby Ridge secure X-Ran: R8Ppy/2=bQ/=DN=l%eb>x<}CnMTjbDqo8M.X91NyI;1v@rM+:`DM/t2x7Y<:lop~RRxU^d X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 11 Jun 2013 18:12:16 -0400 In-Reply-To: (Stefan Monnier's message of "Tue, 11 Jun 2013 17:56:19 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: 14548 Cc: 14548@debbugs.gnu.org, E Sabof X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) Stefan Monnier wrote: >> The idea seems fine, but as written it won't work without requiring >> cl-lib at run-time. > > That's fine for non-preloaded packages. I meant that image-dired does not presently require cl-lib at runtime, so to be a complete solution the patch should have included that change too. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 19:01:17 2013 Received: (at 14548) by debbugs.gnu.org; 11 Jun 2013 23:01:17 +0000 Received: from localhost ([127.0.0.1]:57330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmXYz-000216-0L for submit@debbugs.gnu.org; Tue, 11 Jun 2013 19:01:17 -0400 Received: from mail-qe0-f43.google.com ([209.85.128.43]:51483) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmXYx-00020u-7p for 14548@debbugs.gnu.org; Tue, 11 Jun 2013 19:01:15 -0400 Received: by mail-qe0-f43.google.com with SMTP id q19so1895622qeb.16 for <14548@debbugs.gnu.org>; Tue, 11 Jun 2013 16:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Ju+Ys9+S4jutCc6WmNtNXDirBj1GZuUuv3OBGyZHMNk=; b=FzLGIXJOTQ5N1yCyE21ZA04gq5OZyWHolU2wv5/2cDdAZVI7GTTZrvPBs1RV74igew 6zQ6tt/L90BZNCGdaimRCtEqbSaDZRc7w8Vml6XiRBnIAazRyCEQ6orjNGWN8YPhRYnN AUoaZo5cNi9v1nQTjjzFDXKn8H4Mne7at22oOu5smQGZvHYfgrnc6Dx4/xX49YIHuS4S gWKj7ync8RbHYvZVQgULCOhZ9+oZj4LMWhJ/XXHi3qFPRawyjysofVnNikK5UUvaY5SN 3fpad0JN3a2ImAfgWHY1NxggwKWlpOIwXzZrSSGPiujX06cvooGRbpLajojTDJYmYzxy jdxQ== MIME-Version: 1.0 X-Received: by 10.229.136.213 with SMTP id s21mr2216016qct.9.1370991652405; Tue, 11 Jun 2013 16:00:52 -0700 (PDT) Received: by 10.49.18.162 with HTTP; Tue, 11 Jun 2013 16:00:52 -0700 (PDT) In-Reply-To: References: <1qr4g8lb29.fsf@fencepost.gnu.org> Date: Wed, 12 Jun 2013 00:00:52 +0100 Message-ID: Subject: Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays From: E Sabof To: Glenn Morris Content-Type: multipart/alternative; boundary=002354790f1c6e8be604dee8deb7 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14548 Cc: 14548@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --002354790f1c6e8be604dee8deb7 Content-Type: text/plain; charset=ISO-8859-1 On Tue, Jun 11, 2013 at 11:12 PM, Glenn Morris wrote: > Stefan Monnier wrote: > > >> The idea seems fine, but as written it won't work without requiring > >> cl-lib at run-time. > > > > That's fine for non-preloaded packages. > > I meant that image-dired does not presently require cl-lib at runtime, > so to be a complete solution the patch should have included that change > too. > Basically, whenever a line contains an overlay and this function is evoked, it thinks it already has a thumbnail, and won't put a new one there. I can rewrite the function so it doesn't use cl-remove-if-not, although I assumed that avoidance of the execution/expansion distinction was one of the reasons cl-lib was created. Evgeni --002354790f1c6e8be604dee8deb7 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable --002354790f1c6e8be604dee8deb7-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 08:01:20 2013 Received: (at 14548) by debbugs.gnu.org; 12 Jun 2013 12:01:20 +0000 Received: from localhost ([127.0.0.1]:58336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Umjjr-0000UF-D4 for submit@debbugs.gnu.org; Wed, 12 Jun 2013 08:01:20 -0400 Received: from mail-qa0-f44.google.com ([209.85.216.44]:37624) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Umjjn-0000Tl-ED for 14548@debbugs.gnu.org; Wed, 12 Jun 2013 08:01:18 -0400 Received: by mail-qa0-f44.google.com with SMTP id j8so258444qah.3 for <14548@debbugs.gnu.org>; Wed, 12 Jun 2013 05:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=XNGNf7wxqHBpwWjg9b3Rw2jdiUQR5dtZ1MS0Ha9GmL8=; b=dDEnLNp2iL/ABPXd/JyPcCKW6NYVBBlYPYwJeCJ8e2zpKX8d7YOnXFzsct6syQLbMu wBZcmLs/3HlQo95F2DHv2mLLKUK72SRlFyZ5W25k2nwV3PK1XOzZwO06At5DdM69Et2n cgrpgQC75ZczYH47hzI4nmSGiXmbhZmU3EPHczyDOtPCL9/Gk9EHeAT8SjahhTdSSMLn iwbJ9vuxvpCwyzmm8AVQydOWaosTzjatH7u5vs7tDDAeymbWT2EJE+ZGhFe75XBeEq0s tptKQUsTk5lHZEz3BJJL/0CU+43kFHVDmNB67RTOjgoiyLt8Wb8UivMD+DZJkjkop4Qc fnvA== MIME-Version: 1.0 X-Received: by 10.49.18.166 with SMTP id x6mr23070560qed.39.1371038469416; Wed, 12 Jun 2013 05:01:09 -0700 (PDT) Received: by 10.49.18.162 with HTTP; Wed, 12 Jun 2013 05:01:09 -0700 (PDT) In-Reply-To: References: <1qr4g8lb29.fsf@fencepost.gnu.org> Date: Wed, 12 Jun 2013 13:01:09 +0100 Message-ID: Subject: Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays From: E Sabof To: Glenn Morris Content-Type: multipart/alternative; boundary=047d7bea3ac2f16d1d04def3c4d8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14548 Cc: 14548@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7bea3ac2f16d1d04def3c4d8 Content-Type: text/plain; charset=ISO-8859-1 Bellow is the patch for the trunk version, without cl-remove-if-not diff --git a/lisp/image-dired.el b/lisp/image-dired.el index bbb41d4..2e169ed 100644 --- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -657,16 +657,24 @@ previous -ARG, if ARG<0) files." (string-match-p (image-file-name-regexp) image-file)) (setq thumb-file (image-dired-get-thumbnail-image image-file)) ;; If image is not already added, then add it. - (let ((cur-ov (overlays-in (point) (1+ (point))))) - (if cur-ov - (delete-overlay (car cur-ov)) - (put-image thumb-file image-pos) - (setq overlay - (cl-loop for o in (overlays-in (point) (1+ (point))) - when (overlay-get o 'put-image) collect o into ov - finally return (car ov))) - (overlay-put overlay 'image-file image-file) - (overlay-put overlay 'thumb-file thumb-file))))) + (let (( cur-ovs (overlays-in (point) (1+ (point)))) + thumb-ov) + (while (and cur-ovs + (if (overlay-get (car cur-ovs) 'thumb-file) + (progn + (setq thumb-ov (car cur-ovs)) + nil) + (pop cur-ovs)))) + (if thumb-ov + (delete-overlay thumb-ov) + (progn + (put-image thumb-file image-pos) + (setq overlay + (cl-loop for o in (overlays-in (point) (1+ (point))) + when (overlay-get o 'put-image) collect o into ov + finally return (car ov))) + (overlay-put overlay 'image-file image-file) + (overlay-put overlay 'thumb-file thumb-file)))))) arg ; Show or hide image on ARG next files. 'show-progress) ; Update dired display after each image is updated. (add-hook 'dired-after-readin-hook --047d7bea3ac2f16d1d04def3c4d8 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Bellow is the patch for the trunk version, without cl= -remove-if-not

diff --git a/lisp/image-dired.el b/= lisp/image-dired.el
index bbb41d4..2e169ed 100644
--- a= /lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -657,16 +657,24 @@ previous -AR= G, if ARG<0) files."
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(= string-match-p (image-file-name-regexp) image-file))
=A0 =A0 =A0 = =A0 (setq thumb-file (image-dired-get-thumbnail-image image-file))
=A0 =A0 =A0 =A0 ;; If image is not already added, then add it.
- =A0 =A0 =A0 (let ((cur-ov (overlays-in (point) (1+ (point)))))
- =A0 =A0 =A0 =A0 (if cur-ov
- =A0 =A0 =A0 =A0 =A0 =A0 (delete= -overlay (car cur-ov))
- =A0 (put-image thumb-f= ile image-pos)
- =A0 (setq overlay
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (cl-loop f= or o in (overlays-in (point) (1+ (point)))
- =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0when (overlay-get= o 'put-image) collect o into ov
- =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0finally return (car ov)))
- =A0 (overlay-put overlay 'imag= e-file image-file)
- =A0 (overlay-put = overlay 'thumb-file thumb-file)))))
+ =A0 =A0 =A0 (let (( cur= -ovs (overlays-in (point) (1+ (point))))
+ =A0 =A0 =A0 =A0 =A0 = =A0 thumb-ov)
+ =A0 =A0 =A0 =A0 (while (and cur-ovs
+ =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 (if (overlay-get (car cur-ovs) 'thumb-file)
+= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (progn
+ =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (setq thumb-ov (car cur-ovs))<= /div>
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 nil)
+= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (pop cur-ovs))))
+ =A0 =A0 =A0 =A0 (if thumb-ov
+ =A0 =A0 =A0 =A0 =A0 =A0 (delete= -overlay thumb-ov)
+ =A0 =A0 =A0 =A0 =A0 =A0 (progn
+ = =A0 =A0 =A0 =A0 =A0 =A0 =A0 (put-image thumb-file image-pos)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 (setq overlay
+ =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 (cl-loop for o in (overlays-in (point) (1+ (poi= nt)))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0when (overlay-get o 'put-image) collect o into ov
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0finally return= (car ov)))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 (overlay-put overlay &#= 39;image-file image-file)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 (overlay-= put overlay 'thumb-file thumb-file))))))
=A0 =A0 arg =A0 =A0 =A0 =A0 =A0 =A0 ; Show or hide image on ARG next files.=
=A0 =A0 'show-progress) ; Update dired display after each im= age is updated.
=A0 =A0(add-hook 'dired-after-readin-hook

--047d7bea3ac2f16d1d04def3c4d8-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 15:25:49 2013 Received: (at 14548) by debbugs.gnu.org; 12 Jun 2013 19:25:49 +0000 Received: from localhost ([127.0.0.1]:59362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Umqg1-00057a-5w for submit@debbugs.gnu.org; Wed, 12 Jun 2013 15:25:49 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:40031) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Umqfz-00057T-Nu for 14548@debbugs.gnu.org; Wed, 12 Jun 2013 15:25:48 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.DIT.UMontreal.CA (8.14.1/8.14.1) with ESMTP id r5CJPl0S003019; Wed, 12 Jun 2013 15:25:47 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id C088AB4106; Wed, 12 Jun 2013 15:25:46 -0400 (EDT) From: Stefan Monnier To: E Sabof Subject: Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays Message-ID: References: <1qr4g8lb29.fsf@fencepost.gnu.org> Date: Wed, 12 Jun 2013 15:25:46 -0400 In-Reply-To: (E. Sabof's message of "Wed, 12 Jun 2013 13:01:09 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4607=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4607> : streams <980330> : uri <1445839> X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 14548 Cc: Glenn Morris , 14548@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) > Bellow is the patch for the trunk version, without cl-remove-if-not cl-remove-if-not is perfectly acceptable. But it needs a (require 'cl-lib) at the top of the file (and not within eval-when-compile). Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 01:11:28 2013 Received: (at 14548-done) by debbugs.gnu.org; 13 Jun 2013 05:11:28 +0000 Received: from localhost ([127.0.0.1]:40459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Umzof-0002F9-5X for submit@debbugs.gnu.org; Thu, 13 Jun 2013 01:11:26 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59163 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmzoW-0002Ep-S1 for 14548-done@debbugs.gnu.org; Thu, 13 Jun 2013 01:11:17 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UmzoU-00022d-Qs; Thu, 13 Jun 2013 01:11:11 -0400 From: Glenn Morris To: 14548-done@debbugs.gnu.org Subject: Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays References: <1qr4g8lb29.fsf@fencepost.gnu.org> X-Spook: cryptanalysis security UOP world domination Merlin Indigo X-Ran: &LN@N$.a*xK:,.3!><7Iy=PG!|fo9EEcqO[nF]+PFWe~FJjN.gv@b5%x4Wxx{*QEVIckg5 X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 13 Jun 2013 01:11:10 -0400 In-Reply-To: <1qr4g8lb29.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 11 Jun 2013 15:08:46 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: 14548-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) Version: 24.4 Applied in this form. > *** lisp/image-dired.el 2013-02-17 00:45:53 +0000 > --- lisp/image-dired.el 2013-06-11 19:00:18 +0000 > *************** > *** 657,665 **** > (string-match-p (image-file-name-regexp) image-file)) > (setq thumb-file (image-dired-get-thumbnail-image image-file)) > ;; If image is not already added, then add it. > ! (let ((cur-ov (overlays-in (point) (1+ (point))))) > ! (if cur-ov > ! (delete-overlay (car cur-ov)) > (put-image thumb-file image-pos) > (setq overlay > (cl-loop for o in (overlays-in (point) (1+ (point))) > --- 657,668 ---- > (string-match-p (image-file-name-regexp) image-file)) > (setq thumb-file (image-dired-get-thumbnail-image image-file)) > ;; If image is not already added, then add it. > ! (let* ((cur-ovs (overlays-in (point) (1+ (point)))) > ! (thumb-ov (car (cl-remove-if-not > ! (lambda (ov) (overlay-get ov 'thumb-file)) > ! cur-ovs)))) > ! (if thumb-ov > ! (delete-overlay thumb-ov) > (put-image thumb-file image-pos) > (setq overlay > (cl-loop for o in (overlays-in (point) (1+ (point))) From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 10:18:16 2013 Received: (at 14548) by debbugs.gnu.org; 13 Jun 2013 14:18:16 +0000 Received: from localhost ([127.0.0.1]:41467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Un8Lv-00074l-CG for submit@debbugs.gnu.org; Thu, 13 Jun 2013 10:18:15 -0400 Received: from relais.videotron.ca ([24.201.245.36]:62277) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Un8Lt-00074d-Gf for 14548@debbugs.gnu.org; Thu, 13 Jun 2013 10:18:13 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from ceviche.home ([24.201.64.104]) by VL-VM-MR001.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MOC00FR352C9N10@VL-VM-MR001.ip.videotron.ca> for 14548@debbugs.gnu.org; Thu, 13 Jun 2013 10:18:13 -0400 (EDT) Received: by ceviche.home (Postfix, from userid 20848) id 2F89E6610B; Thu, 13 Jun 2013 10:18:12 -0400 (EDT) From: Stefan Monnier To: 14548@debbugs.gnu.org Subject: Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays Message-id: References: <1qr4g8lb29.fsf@fencepost.gnu.org> Date: Thu, 13 Jun 2013 10:18:12 -0400 In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 14548 Cc: rgm@gnu.org, esabof@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) >> ! (let* ((cur-ovs (overlays-in (point) (1+ (point)))) >> ! (thumb-ov (car (cl-remove-if-not >> ! (lambda (ov) (overlay-get ov 'thumb-file)) >> ! cur-ovs)))) >> ! (if thumb-ov >> ! (delete-overlay thumb-ov) BTW, now that I actually look at the code, I twonder why it doesn't use remove-overlays. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 10:39:57 2013 Received: (at 14548) by debbugs.gnu.org; 13 Jun 2013 14:39:57 +0000 Received: from localhost ([127.0.0.1]:41528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Un8gu-0007zD-O2 for submit@debbugs.gnu.org; Thu, 13 Jun 2013 10:39:57 -0400 Received: from mail-qe0-f47.google.com ([209.85.128.47]:45068) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Un8gs-0007yX-Nk for 14548@debbugs.gnu.org; Thu, 13 Jun 2013 10:39:55 -0400 Received: by mail-qe0-f47.google.com with SMTP id 1so6572695qec.34 for <14548@debbugs.gnu.org>; Thu, 13 Jun 2013 07:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=FDR6mShHILp4XTkYslgxG32rGNN3I8rpXP/k1jlzNZQ=; b=QkpYvQIg14iCvTKaTtUP8yRbfA6HBs3STpWDAG/23z/dNTfZ11Ile308gTlkQCOghh L+il4Eu+Npvq3695VL4aThA/uy6o6RTqIVvYP6QONUfJiyHpG2PJz1wcVhasTnt3f5qi RXyYxQwgwGupLeMmnyBjNlsUJhl3ZIg6nkKIkQMHtL6cscr+VmBoq529MKxanQEcxzvN IFI2dUgPyuv7DV0gEY82eHjSwTtbUABIZB1txKAOuYU66lStrIcvzWnmgZg60msSpBVC A9AruG/6Pv4Uwo2ICnjHdwpsvGHOeXYqmHTgKtn9O2J1YbK/IIf0MuZDrjM9GKrdikmX fv4w== MIME-Version: 1.0 X-Received: by 10.224.79.209 with SMTP id q17mr3305918qak.88.1371134389115; Thu, 13 Jun 2013 07:39:49 -0700 (PDT) Received: by 10.49.96.226 with HTTP; Thu, 13 Jun 2013 07:39:49 -0700 (PDT) In-Reply-To: References: <1qr4g8lb29.fsf@fencepost.gnu.org> Date: Thu, 13 Jun 2013 15:39:49 +0100 Message-ID: Subject: Re: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays From: E Sabof To: Stefan Monnier Content-Type: multipart/alternative; boundary=047d7bf1617633dfe904df0a1ad4 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14548 Cc: Glenn Morris , 14548@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7bf1617633dfe904df0a1ad4 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Jun 13, 2013 at 3:18 PM, Stefan Monnier wrote: > >> ! (let* ((cur-ovs (overlays-in (point) (1+ (point)))) > >> ! (thumb-ov (car (cl-remove-if-not > >> ! (lambda (ov) (overlay-get ov > 'thumb-file)) > >> ! cur-ovs)))) > >> ! (if thumb-ov > >> ! (delete-overlay thumb-ov) > > BTW, now that I actually look at the code, I twonder why it doesn't use > remove-overlays. > > > Stefan > It's a toggler. It will remove the overlay if present, or create one. And remove-overlays always returns nil. Evgeni --047d7bf1617633dfe904df0a1ad4 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Thu, Jun 13, 2013 at 3:18 PM, Stefan Monnier <= monnier@iro.umontreal.ca> wrote:
>> ! =A0 =A0 =A0 =A0(let* ((cur-ov= s (overlays-in (point) (1+ (point))))
>> ! =A0 =A0 =A0 =A0 =A0 =A0 =A0 (thumb-ov (car (cl-remove-if-not
>> ! =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (lam= bda (ov) (overlay-get ov 'thumb-file))
>> ! =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 cur-= ovs))))
>> ! =A0 =A0 =A0 =A0 =A0(if thumb-ov
>> ! =A0 =A0 =A0 =A0 =A0 =A0 =A0(delete-overlay thumb-ov)

BTW, now that I actually look at the code, I twonder why it doesn'= ;t use
remove-overlays.


=A0 =A0 =A0 =A0 Stefan
=A0
It= 's a toggler. It will remove the overlay if present, or create one. And= remove-overlays always returns nil.
Evgeni
--047d7bf1617633dfe904df0a1ad4-- From unknown Tue Jun 17 20:15:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 12 Jul 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator