Subject: bug#14539: closed (Re: bug#14539: [PATCH] dircolors: add pnm image)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 02 Jun 2013 23:55:02 +0000

Your bug report

#14539: [PATCH] dircolors: add pnm image

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
14539: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14539
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#14539: [PATCH] dircolors: add pnm image
From: Pádraig Brady <[email-masked]>
To: Javier Lopez <[email-masked]>
Cc: [email-masked]
Date: Mon, 03 Jun 2013 00:52:36 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

On 06/02/2013 11:09 PM, Javier Lopez wrote:
> Hi,
> 
> Attached patch adds colorizing for *.pnm images. Pnm images are amongst others
> generated by Xsane scans. Although they're basically text files, they are
> considered as images (a file command returns "Netpbm PPM "rawbits" image data"
> so their color code should probably be 01;35.
> 
> This issue was first noted by ultrapeer AT lavabit.com and forwarded to Ubuntu
> 
> ======================================================================
> 
> diff --git a/src/dircolors.hin b/src/dircolors.hin
> index 18e1552..3a0c03f 100644
> --- a/src/dircolors.hin
> +++ b/src/dircolors.hin
> @@ -165,6 +165,7 @@ EXEC 01;32
>  .tif 01;35
>  .tiff 01;35
>  .png 01;35
> +.pnm 01;35
>  .svg 01;35
>  .svgz 01;35
>  .mng 01;35

`man pnm` suggests that pnm isn't a format in its own right,
but "just an abstraction of the PBM, PGM, and PPM formats".

Therefore I'm inclined not to include this.

thanks,
Pádraig.

Subject: [PATCH] dircolors: add pnm image
From: Javier Lopez <[email-masked]>
To: [email-masked]
Date: Sun, 2 Jun 2013 17:09:13 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Attached patch adds colorizing for *.pnm images. Pnm images are amongst others
generated by Xsane scans. Although they're basically text files, they are
considered as images (a file command returns "Netpbm PPM "rawbits" image data"
so their color code should probably be 01;35.

This issue was first noted by ultrapeer AT lavabit.com and forwarded to Ubuntu

======================================================================

diff --git a/src/dircolors.hin b/src/dircolors.hin
index 18e1552..3a0c03f 100644
--- a/src/dircolors.hin
+++ b/src/dircolors.hin
@@ -165,6 +165,7 @@ EXEC 01;32
 .tif 01;35
 .tiff 01;35
 .png 01;35
+.pnm 01;35
 .svg 01;35
 .svgz 01;35
 .mng 01;35