GNU bug report logs - #14539
[PATCH] dircolors: add pnm image

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14539 in the body.
You can then email your comments to 14539 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Javier Lopez <chilicuil <at> ubuntu.com>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] dircolors: add pnm image
Date: Sun, 2 Jun 2013 17:09:13 -0500

Hi,

Attached patch adds colorizing for *.pnm images. Pnm images are amongst others
generated by Xsane scans. Although they're basically text files, they are
considered as images (a file command returns "Netpbm PPM "rawbits" image data"
so their color code should probably be 01;35.

This issue was first noted by ultrapeer AT lavabit.com and forwarded to Ubuntu

======================================================================

diff --git a/src/dircolors.hin b/src/dircolors.hin
index 18e1552..3a0c03f 100644
--- a/src/dircolors.hin
+++ b/src/dircolors.hin
@@ -165,6 +165,7 @@ EXEC 01;32
 .tif 01;35
 .tiff 01;35
 .png 01;35
+.pnm 01;35
 .svg 01;35
 .svgz 01;35
 .mng 01;35

Message #10 received at 14539-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Javier Lopez <chilicuil <at> ubuntu.com>
Cc: 14539-done <at> debbugs.gnu.org
Subject: Re: bug#14539: [PATCH] dircolors: add pnm image
Date: Mon, 03 Jun 2013 00:52:36 +0100

On 06/02/2013 11:09 PM, Javier Lopez wrote:
> Hi,
> 
> Attached patch adds colorizing for *.pnm images. Pnm images are amongst others
> generated by Xsane scans. Although they're basically text files, they are
> considered as images (a file command returns "Netpbm PPM "rawbits" image data"
> so their color code should probably be 01;35.
> 
> This issue was first noted by ultrapeer AT lavabit.com and forwarded to Ubuntu
> 
> ======================================================================
> 
> diff --git a/src/dircolors.hin b/src/dircolors.hin
> index 18e1552..3a0c03f 100644
> --- a/src/dircolors.hin
> +++ b/src/dircolors.hin
> @@ -165,6 +165,7 @@ EXEC 01;32
>  .tif 01;35
>  .tiff 01;35
>  .png 01;35
> +.pnm 01;35
>  .svg 01;35
>  .svgz 01;35
>  .mng 01;35

`man pnm` suggests that pnm isn't a format in its own right,
but "just an abstraction of the PBM, PGM, and PPM formats".

Therefore I'm inclined not to include this.

thanks,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.