GNU bug report logs - #14529
gv--defsetter, advice--set-buffer-local compilation warnings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14529 in the body.
You can then email your comments to 14529 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: gv--defsetter, advice--set-buffer-local compilation warnings
Date: Sat, 01 Jun 2013 18:39:46 -0400

Package: emacs
Severity: minor
Version: 24.3.50

There are these (spurious?) warnings while bootstrapping:

  the function `gv--defsetter' might not be defined at runtime.
  (image-mode, winner, avl-tree, eieio)

  the function `advice--set-buffer-local' might not be defined at runtime.
  (mailabbrev)

Message #6 received at 14529 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 14529 <at> debbugs.gnu.org
Subject: Re: bug#14529: gv--defsetter,
	advice--set-buffer-local compilation warnings
Date: Sat, 01 Jun 2013 22:42:03 -0400

>   the function `gv--defsetter' might not be defined at runtime.
>   (image-mode, winner, avl-tree, eieio)

gv--setter is used inside a function placed on the `gv-expander'
property of some symbols, which should never be used except by gv.el
code (at which point gv--defsetter will be defined).

>   the function `advice--set-buffer-local' might not be defined at runtime.
>   (mailabbrev)

Hmmm... not sure what that is.


        Stefan

Message #11 received at 14529-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 14529-done <at> debbugs.gnu.org
Subject: Re: gv--defsetter, advice--set-buffer-local compilation warnings
Date: Wed, 25 Nov 2015 11:12:40 +0000

This bug has gone away.  Closing.

On Sat, Jun 01, 2013 at 06:39:46PM -0400, Glenn Morris wrote:
> Package: emacs
> Severity: minor
> Version: 24.3.50

> There are these (spurious?) warnings while bootstrapping:

>   the function `gv--defsetter' might not be defined at runtime.
>   (image-mode, winner, avl-tree, eieio)

>   the function `advice--set-buffer-local' might not be defined at runtime.
>   (mailabbrev)

-- 
Alan Mackenzie (Nuremberg, Germany).

Message #22 received at 14529 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 14529 <at> debbugs.gnu.org
Subject: Re: bug#14529: gv--defsetter,
 advice--set-buffer-local compilation warnings
Date: Fri, 23 Mar 2018 17:16:40 -0400

Stefan Monnier wrote:

>>   the function `gv--defsetter' might not be defined at runtime.
>>   (image-mode, winner, avl-tree []
>
> gv--setter is used inside a function placed on the `gv-expander'
> property of some symbols, which should never be used except by gv.el
> code (at which point gv--defsetter will be defined).

These warnings have come back following 97b7e58.
Obviously they can be declare-functioned away, but it would be nicer if
there was a general solution that did not require modifying each file
that declares a gv-setter.

Message #25 received at 14529 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 14529 <at> debbugs.gnu.org
Subject: Re: bug#14529: gv--defsetter,
 advice--set-buffer-local compilation warnings
Date: Fri, 23 Mar 2018 19:25:01 -0400

Glenn Morris <rgm <at> gnu.org> writes:

> Stefan Monnier wrote:
>
>>>   the function `gv--defsetter' might not be defined at runtime.
>>>   (image-mode, winner, avl-tree []
>>
>> gv--setter is used inside a function placed on the `gv-expander'
>> property of some symbols, which should never be used except by gv.el
>> code (at which point gv--defsetter will be defined).
>
> These warnings have come back following 97b7e58.
> Obviously they can be declare-functioned away, but it would be nicer if
> there was a general solution that did not require modifying each file
> that declares a gv-setter.

I'd love to have a general way to say things like "code on symbol
property `gv-expand' can use any function provided by gv.el", but in the
mean time would the patch below work?


        Stefan


diff --git a/lisp/emacs-lisp/gv.el b/lisp/emacs-lisp/gv.el
index 1e5347d206..230d59f189 100644
--- a/lisp/emacs-lisp/gv.el
+++ b/lisp/emacs-lisp/gv.el
@@ -216,6 +216,8 @@ gv-define-setter
   (declare (indent 2) (debug (&define name sexp body)))
   `(gv-define-expander ,name
      (lambda (do &rest args)
+       (declare-function
+        gv--defsetter "gv" (name setter do args &optional vars))
        (gv--defsetter ',name (lambda ,arglist ,@body) do args))))
 
 ;;;###autoload

Message #28 received at 14529 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 14529 <at> debbugs.gnu.org
Subject: Re: bug#14529: gv--defsetter,
 advice--set-buffer-local compilation warnings
Date: Tue, 17 Apr 2018 14:28:43 -0400

Stefan Monnier wrote:

> --- a/lisp/emacs-lisp/gv.el
> +++ b/lisp/emacs-lisp/gv.el
> @@ -216,6 +216,8 @@ gv-define-setter
>    (declare (indent 2) (debug (&define name sexp body)))
>    `(gv-define-expander ,name
>       (lambda (do &rest args)
> +       (declare-function
> +        gv--defsetter "gv" (name setter do args &optional vars))
>         (gv--defsetter ',name (lambda ,arglist ,@body) do args))))
>  
>  ;;;###autoload

Works for me, thanks.

Message #31 received at 14529 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 14529 <at> debbugs.gnu.org
Subject: Re: bug#14529: gv--defsetter,
 advice--set-buffer-local compilation warnings
Date: Wed, 18 Apr 2018 15:57:59 -0400

> Works for me, thanks.

Pushed to master.  Can we close this bug or is the
advice--set-buffer-local still pending?


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.