From unknown Sun Aug 10 16:50:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14517 <14517@debbugs.gnu.org> To: bug#14517 <14517@debbugs.gnu.org> Subject: Status: t/tags-pr12372.sh assumes that etags generates tags for all files Reply-To: bug#14517 <14517@debbugs.gnu.org> Date: Sun, 10 Aug 2025 23:50:51 +0000 retitle 14517 t/tags-pr12372.sh assumes that etags generates tags for all f= iles reassign 14517 automake submitter 14517 Peter Rosin severity 14517 minor tag 14517 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 05:17:34 2013 Received: (at submit) by debbugs.gnu.org; 31 May 2013 09:17:34 +0000 Received: from localhost ([127.0.0.1]:43878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiLSo-0001a3-1v for submit@debbugs.gnu.org; Fri, 31 May 2013 05:17:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43549) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiLSl-0001Zn-PP for submit@debbugs.gnu.org; Fri, 31 May 2013 05:17:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiLR9-00062F-0U for submit@debbugs.gnu.org; Fri, 31 May 2013 05:15:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.0 required=5.0 tests=BAYES_40, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiLR8-00062B-SV for submit@debbugs.gnu.org; Fri, 31 May 2013 05:15:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiLR7-0004mH-6E for bug-automake@gnu.org; Fri, 31 May 2013 05:15:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiLR5-0005z1-Gr for bug-automake@gnu.org; Fri, 31 May 2013 05:15:49 -0400 Received: from mail.lysator.liu.se ([2001:6b0:17:f0a0::3]:57157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiLR5-0005xV-AU for bug-automake@gnu.org; Fri, 31 May 2013 05:15:47 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id DBD7D40011 for ; Fri, 31 May 2013 11:15:43 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 9E84740002 for ; Fri, 31 May 2013 11:15:43 +0200 (CEST) Message-ID: <51A86A3E.30104@lysator.liu.se> Date: Fri, 31 May 2013 11:15:42 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: bug-automake@gnu.org Subject: t/tags-pr12372.sh assumes that etags generates tags for all files Content-Type: text/plain; charset=UTF-8 X-Virus-Scanned: ClamAV using ClamSMTP Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Hi! I recently installed etags on Cygwin. $ etags --version Exuberant Ctags 5.8, Copyright (C) 1996-2009 Darren Hiebert Compiled: Dec 11 2009, 11:42:40 Addresses: , http://ctags.sourceforge.n= et Optional compiled features: +wildcards, +regex, +internal-sort This caused t/tags-pr12372.sh (v1.13.2-63-gb4bfacb, i.e. not the very latest, but close enough) to go from SKIP to FAIL. The reason for the FAIL is that this etags program will not by default generate any tags for file extensions it does not recognize. Quoting from the manual: SOURCE FILES Unless the --language-force option is specified, the language of= each source file is automatically selected based upon a mapping of = file names to languages. The mappings in effect for each language m= ay be display using the --list-maps option and may be changed using= the --langmap option. On platforms which support it, if the name of a= file is not mapped to a language and the file is executable, the first = line of the file is checked to see if the file is a "#!" script for a r= ecog=E2=80=90 nized language. With that info (and with the help of the docs for the --langmap option), = I can make the test PASS *for this etags* with the below patch. I also question if it's wise to 'cat TAGS' in the test, as I have non-printable characters the tags files. Cheers, Peter diff --git a/t/tags-pr12372.sh b/t/tags-pr12372.sh index 4eeb9be..14b500e 100644 --- a/t/tags-pr12372.sh +++ b/t/tags-pr12372.sh @@ -63,7 +63,7 @@ $AUTOMAKE ./configure -$MAKE +$MAKE ETAGSFLAGS=3D"--langmap=3Dc:+.pc" cat TAGS cat sub/TAGS $FGREP foo-main.pc TAGS From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 05:38:32 2013 Received: (at 14517) by debbugs.gnu.org; 31 May 2013 09:38:32 +0000 Received: from localhost ([127.0.0.1]:43905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiLn5-0002h7-Le for submit@debbugs.gnu.org; Fri, 31 May 2013 05:38:32 -0400 Received: from mail-bk0-f51.google.com ([209.85.214.51]:43868) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiLn3-0002ga-31; Fri, 31 May 2013 05:38:30 -0400 Received: by mail-bk0-f51.google.com with SMTP id ji1so642980bkc.10 for ; Fri, 31 May 2013 02:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=sd5l9v4gmSpyRBVRelxjpi2yOr7Pa6j/pPo+MSsfMrg=; b=sOqWXPV07fRkgSzBUdtHFAO6EP2uGfUrH85bZidxMh4nwbC2ELQ3UlggU2TO559vOO dVPQnnRhPtY0GYfe0HvHPvbjO+fn7ivb8nEMa4y2lcwLuj/Dk7wurIp3QMJwEPTGRk/4 Jtiw8zlwaGqKwucMjxrFmJuSHOLaengcYZ0qf3FmtDhyoeiTELMmBTvs8+GJkFj4bL3f IQWS7/ql7VbW/NlsrVa9K7Yefp86icefVhmZJB2v4DQhjXnSMoCMcYAc7Bt0YJpGkK79 GFIOU0iSo30PGvbVQukn9VESxzTR2bsbbEwAvj/Y5B9kaSsLlhP/SmmWWfN5y5uo9oIZ 9Ogw== X-Received: by 10.204.173.9 with SMTP id n9mr3042482bkz.47.1369993008713; Fri, 31 May 2013 02:36:48 -0700 (PDT) Received: from [192.168.178.20] (host93-95-dynamic.6-79-r.retail.telecomitalia.it. [79.6.95.93]) by mx.google.com with ESMTPSA id i15sm14889631bkz.12.2013.05.31.02.36.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 31 May 2013 02:36:47 -0700 (PDT) Message-ID: <51A86F26.6020209@gmail.com> Date: Fri, 31 May 2013 11:36:38 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Peter Rosin Subject: Re: bug#14517: t/tags-pr12372.sh assumes that etags generates tags for all files References: <51A86A3E.30104@lysator.liu.se> In-Reply-To: <51A86A3E.30104@lysator.liu.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 14517 Cc: 14517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) severity 14517 minor stop Hi Peter, thanks for the report. On 05/31/2013 11:15 AM, Peter Rosin wrote: > Hi! > > I recently installed etags on Cygwin. > > $ etags --version > Exuberant Ctags 5.8, Copyright (C) 1996-2009 Darren Hiebert > Compiled: Dec 11 2009, 11:42:40 > Addresses: , http://ctags.sourceforge.net > Optional compiled features: +wildcards, +regex, +internal-sort > > This caused t/tags-pr12372.sh (v1.13.2-63-gb4bfacb, i.e. not the very > latest, but close enough) to go from SKIP to FAIL. > > The reason for the FAIL is that this etags program will not by default > generate any tags for file extensions it does not recognize. > > Quoting from the manual: > > > SOURCE FILES > Unless the --language-force option is specified, the language of each > source file is automatically selected based upon a mapping of file > names to languages. The mappings in effect for each language may be > display using the --list-maps option and may be changed using the > --langmap option. On platforms which support it, if the name of a file > is not mapped to a language and the file is executable, the first line > of the file is checked to see if the file is a "#!" script for a recog‐ > nized language. > > > With that info (and with the help of the docs for the --langmap option), I > can make the test PASS *for this etags* with the below patch. > > I also question if it's wise to 'cat TAGS' in the test, as I have > non-printable characters the tags files. > Log files generated by the automake testsuite harness should be able to contain binary output without confusing any of the other automake-generated recipes. That is considered a feature, and is also tested in the Automake testsuite somewhere. Are you having concrete problem with this? If yes, that's a bug we might want to address. > Cheers, > Peter > > > diff --git a/t/tags-pr12372.sh b/t/tags-pr12372.sh > index 4eeb9be..14b500e 100644 > --- a/t/tags-pr12372.sh > +++ b/t/tags-pr12372.sh > @@ -63,7 +63,7 @@ $AUTOMAKE > > ./configure > > -$MAKE > +$MAKE ETAGSFLAGS="--langmap=c:+.pc" > This will break with my etags, though. $ etags --version etags (GNU Emacs 23.4) Copyright (C) 2012 Free Software Foundation, Inc. This program is distributed under the terms in ETAGS.README Maybe you should make your change condition to whether etags is "Exuberant Ctags"? > cat TAGS > cat sub/TAGS > $FGREP foo-main.pc TAGS > > Thanks, Stefano From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 05:54:08 2013 Received: (at 14517) by debbugs.gnu.org; 31 May 2013 09:54:08 +0000 Received: from localhost ([127.0.0.1]:43933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiM2C-0004Nm-Aq for submit@debbugs.gnu.org; Fri, 31 May 2013 05:54:08 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:36422) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiM2A-0004NZ-2N for 14517@debbugs.gnu.org; Fri, 31 May 2013 05:54:07 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 2435940016; Fri, 31 May 2013 11:52:30 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id E032940011; Fri, 31 May 2013 11:52:29 +0200 (CEST) Message-ID: <51A872DD.7090409@lysator.liu.se> Date: Fri, 31 May 2013 11:52:29 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Stefano Lattarini Subject: Re: bug#14517: t/tags-pr12372.sh assumes that etags generates tags for all files References: <51A86A3E.30104@lysator.liu.se> <51A86F26.6020209@gmail.com> In-Reply-To: <51A86F26.6020209@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 14517 Cc: 14517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On 2013-05-31 11:36, Stefano Lattarini wrote: >> With that info (and with the help of the docs for the --langmap option), I >> can make the test PASS *for this etags* with the below patch. >> >> I also question if it's wise to 'cat TAGS' in the test, as I have >> non-printable characters the tags files. >> > Log files generated by the automake testsuite harness should be able to contain > binary output without confusing any of the other automake-generated recipes. > That is considered a feature, and is also tested in the Automake testsuite > somewhere. Are you having concrete problem with this? If yes, that's a bug > we might want to address. No, no concrete problem here, but it makes it harder to exchange the log files, especially since people might assume they are regular text files. They sure look texty on a cursory glance. >> >> diff --git a/t/tags-pr12372.sh b/t/tags-pr12372.sh >> index 4eeb9be..14b500e 100644 >> --- a/t/tags-pr12372.sh >> +++ b/t/tags-pr12372.sh >> @@ -63,7 +63,7 @@ $AUTOMAKE >> >> ./configure >> >> -$MAKE >> +$MAKE ETAGSFLAGS="--langmap=c:+.pc" >> > This will break with my etags, though. Of course, that is why I emphasized *with this etags* above. I never expected this patch to fly, it was a throwaway thing (I didn't even commit it locally, and I didn't send it to automake-patches). I considered it only as input to whomever would write a proper patch. > $ etags --version > etags (GNU Emacs 23.4) > Copyright (C) 2012 Free Software Foundation, Inc. > This program is distributed under the terms in ETAGS.README > > Maybe you should make your change condition to whether etags is > "Exuberant Ctags"? Or, even better, check if etags swallows "--langmap=c:.pc", which seems more robust than relying on names and versions of tools. I'm not going to write the patch this week though, and possibly not in the near future as I have other things ($$$) to do as well... Cheers, Peter From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 06:00:32 2013 Received: (at 14517) by debbugs.gnu.org; 31 May 2013 10:00:32 +0000 Received: from localhost ([127.0.0.1]:43945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiM8O-0004dV-4s for submit@debbugs.gnu.org; Fri, 31 May 2013 06:00:32 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:61014) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiM8L-0004dI-Kw for 14517@debbugs.gnu.org; Fri, 31 May 2013 06:00:30 -0400 Received: by mail-bk0-f46.google.com with SMTP id na10so647062bkb.19 for <14517@debbugs.gnu.org>; Fri, 31 May 2013 02:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=PLGQYcdH+HdPeXkA6nhRaSMgQlEPT3kiB7zOb8GmGOQ=; b=AsMf7y5btkOkfONgkTYn2z/nz86x0X8fB4gymlYSKF4HUgpkVu84ndXI9IBbk/hlUs iD2wRZKLCONA/Xi07hPLWevIaMXKqgWCMYwcIx5dy38y9rcRmodzp+VKZ7qJ/CnWS64p ezL4/9W1yZAw+hC2TOR5GBc87SJkHx5hTNmfQZcujZCPgZGoUOBWNIVtgkCJZ7Yhen6K 245TxVqqcMLIa8yYmE/lKjhKhfV8BWWQxiaK8zV+LdvENFYdapdLYfy73SQSkFTHAzYG pyKOUEDGR8Ftrj1xPJYlUZ+2jKqKXFWb/F7GvoHGCC+zCi3se90SyQOTxNx+p/hiHCiV 1xtQ== X-Received: by 10.205.46.4 with SMTP id um4mr3088627bkb.116.1369994329544; Fri, 31 May 2013 02:58:49 -0700 (PDT) Received: from [192.168.178.20] (host93-95-dynamic.6-79-r.retail.telecomitalia.it. [79.6.95.93]) by mx.google.com with ESMTPSA id tl1sm14892105bkb.7.2013.05.31.02.58.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 31 May 2013 02:58:48 -0700 (PDT) Message-ID: <51A87456.8010209@gmail.com> Date: Fri, 31 May 2013 11:58:46 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Peter Rosin Subject: Re: bug#14517: t/tags-pr12372.sh assumes that etags generates tags for all files References: <51A86A3E.30104@lysator.liu.se> <51A86F26.6020209@gmail.com> <51A872DD.7090409@lysator.liu.se> In-Reply-To: <51A872DD.7090409@lysator.liu.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 14517 Cc: 14517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 05/31/2013 11:52 AM, Peter Rosin wrote: > On 2013-05-31 11:36, Stefano Lattarini wrote: >>> With that info (and with the help of the docs for the --langmap option), I >>> can make the test PASS *for this etags* with the below patch. >>> >>> I also question if it's wise to 'cat TAGS' in the test, as I have >>> non-printable characters the tags files. >>> >> Log files generated by the automake testsuite harness should be able to contain >> binary output without confusing any of the other automake-generated recipes. >> That is considered a feature, and is also tested in the Automake testsuite >> somewhere. Are you having concrete problem with this? If yes, that's a bug >> we might want to address. > > No, no concrete problem here, but it makes it harder to exchange the log > files, especially since people might assume they are regular text files. > They sure look texty on a cursory glance. > Let's cross that bridge when we come to it then (i.e., a real problem arises). Of course, feel free to go ahead if you want to write a patch to preventively addresses this and similar potential issues (I think is should be easily doable using perl). I won't do it myself, but I'll certainly ACK a patch from you. >>> >>> diff --git a/t/tags-pr12372.sh b/t/tags-pr12372.sh >>> index 4eeb9be..14b500e 100644 >>> --- a/t/tags-pr12372.sh >>> +++ b/t/tags-pr12372.sh >>> @@ -63,7 +63,7 @@ $AUTOMAKE >>> >>> ./configure >>> >>> -$MAKE >>> +$MAKE ETAGSFLAGS="--langmap=c:+.pc" >>> >> This will break with my etags, though. > > Of course, that is why I emphasized *with this etags* above. I never > expected this patch to fly, it was a throwaway thing (I didn't even > commit it locally, and I didn't send it to automake-patches). I > considered it only as input to whomever would write a proper patch. > >> $ etags --version >> etags (GNU Emacs 23.4) >> Copyright (C) 2012 Free Software Foundation, Inc. >> This program is distributed under the terms in ETAGS.README >> >> Maybe you should make your change condition to whether etags is >> "Exuberant Ctags"? > > Or, even better, check if etags swallows "--langmap=c:.pc", which > seems more robust than relying on names and versions of tools. > > I'm not going to write the patch this week though, and possibly > not in the near future as I have other things ($$$) to do as well... > Not to worry, the bug remains open, I will get to it eventually (maybe soon). Thanks, Stefano From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 06:03:46 2013 Received: (at 14517) by debbugs.gnu.org; 31 May 2013 10:03:46 +0000 Received: from localhost ([127.0.0.1]:43951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiMBT-0004kp-Mw for submit@debbugs.gnu.org; Fri, 31 May 2013 06:03:44 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:41419) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiMBR-0004kb-1D for 14517@debbugs.gnu.org; Fri, 31 May 2013 06:03:41 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id F11D940011; Fri, 31 May 2013 12:02:05 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id A5F1940002; Fri, 31 May 2013 12:02:05 +0200 (CEST) Message-ID: <51A8751D.5050900@lysator.liu.se> Date: Fri, 31 May 2013 12:02:05 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Stefano Lattarini Subject: Re: bug#14517: t/tags-pr12372.sh assumes that etags generates tags for all files References: <51A86A3E.30104@lysator.liu.se> <51A86F26.6020209@gmail.com> <51A872DD.7090409@lysator.liu.se> <51A87456.8010209@gmail.com> In-Reply-To: <51A87456.8010209@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 14517 Cc: 14517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On 2013-05-31 11:58, Stefano Lattarini wrote: > On 05/31/2013 11:52 AM, Peter Rosin wrote: >> I'm not going to write the patch this week though, and possibly >> not in the near future as I have other things ($$$) to do as well... >> > Not to worry, the bug remains open, I will get to it eventually > (maybe soon). Yup, I'm happy to test anything you come up with (within reason :-). Cheers, Peter From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 05:49:27 2013 Received: (at 14517) by debbugs.gnu.org; 3 Jun 2013 09:49:27 +0000 Received: from localhost ([127.0.0.1]:48523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjROJ-0006sj-1z for submit@debbugs.gnu.org; Mon, 03 Jun 2013 05:49:27 -0400 Received: from mail-bk0-f53.google.com ([209.85.214.53]:61418) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjROG-0006sA-Fy; Mon, 03 Jun 2013 05:49:25 -0400 Received: by mail-bk0-f53.google.com with SMTP id mx10so1751345bkb.26 for ; Mon, 03 Jun 2013 02:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=hs4I7WpRKEVEaSIpOwJtsPbIRFu69tThyAihc3jJdNY=; b=VdOCriQjFwARFwTugvv+J0S8ghBbWcsu8TSRjUCLthpqBH9b/092aQ8XrSpMLduYo/ IEay0u6jWuAmYT1UTq6/airBv8xG46mCmtkCpqJPn+M2XyVP/MI56FCRzwGCT7QCw7Hk C3uCHcTAsBguvisU10/N4tW1WCa62Dp1sp/ezyMceZakGuZl4bLMF9nUlmkA42THKcFU go7NXA87ZdpJCPYtZF8THf0GuPwFMBF7g8PWnsTRtpH5OMrdy5FI+4DiaPyKt4ZySGRN JGdny3JbIByv5vK7rgzRUScfttl3s5ssNi3MYV8wqbZFZ5yoEhFlzKKI1dQ94l/QTR7i P/Tg== X-Received: by 10.204.185.136 with SMTP id co8mr6204859bkb.23.1370252847107; Mon, 03 Jun 2013 02:47:27 -0700 (PDT) Received: from [192.168.178.20] (host93-95-dynamic.6-79-r.retail.telecomitalia.it. [79.6.95.93]) by mx.google.com with ESMTPSA id jy7sm11264926bkb.6.2013.06.03.02.47.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Jun 2013 02:47:26 -0700 (PDT) Message-ID: <51AC662B.9010203@gmail.com> Date: Mon, 03 Jun 2013 11:47:23 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Peter Rosin Subject: Re: bug#14517: t/tags-pr12372.sh assumes that etags generates tags for all files References: <51A86A3E.30104@lysator.liu.se> <51A86F26.6020209@gmail.com> <51A872DD.7090409@lysator.liu.se> <51A87456.8010209@gmail.com> <51A8751D.5050900@lysator.liu.se> In-Reply-To: <51A8751D.5050900@lysator.liu.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 14517 Cc: 14517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 14517 + patch thanks On 05/31/2013 12:02 PM, Peter Rosin wrote: > On 2013-05-31 11:58, Stefano Lattarini wrote: >> On 05/31/2013 11:52 AM, Peter Rosin wrote: >>> I'm not going to write the patch this week though, and possibly >>> not in the near future as I have other things ($$$) to do as well... >>> >> Not to worry, the bug remains open, I will get to it eventually >> (maybe soon). > > Yup, I'm happy to test anything you come up with (within reason :-). > Here it is. Does it work for you? ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- 8< ---- >From 9137db89c88d5fceed1c80beeb2969d36a9e72c9 Mon Sep 17 00:00:00 2001 Message-Id: <9137db89c88d5fceed1c80beeb2969d36a9e72c9.1370252733.git.stefano.lattarini@gmail.com> From: Stefano Lattarini Date: Mon, 3 Jun 2013 11:45:29 +0200 Subject: [PATCH] tests: fix spurious failure when 'etags' program is Exuberant Ctags Fixes automake bug#14517. * t/tags-pr12372.sh: If the 'etags' program in use supports the '--langmap' option, use it. That is required to avoid spurious failures with Exuberant Ctags (at least version 5.8), which by default do not generate any tags for file extensions it doesn't recognize. Signed-off-by: Stefano Lattarini --- t/tags-pr12372.sh | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/t/tags-pr12372.sh b/t/tags-pr12372.sh index 4eeb9be..657be60 100644 --- a/t/tags-pr12372.sh +++ b/t/tags-pr12372.sh @@ -63,7 +63,17 @@ $AUTOMAKE ./configure -$MAKE +# Exuberant Ctags (at least version 5.8) do not generate any tags +# for file extensions it doesn't recognize. This can be fixed by +# using the '--langmap' option. But we must be careful, because +# etags from Emacs (at least version 23.4) doesn't recognize that +# option. +if etags --help | grep '.*--langmap'; then + run_make ETAGSFLAGS="--langmap=c:+.pc" +else + $MAKE +fi + cat TAGS cat sub/TAGS $FGREP foo-main.pc TAGS -- 1.8.3.rc3.8.g5e49f30 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 09:23:15 2013 Received: (at 14517-done) by debbugs.gnu.org; 3 Jun 2013 13:23:15 +0000 Received: from localhost ([127.0.0.1]:48831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjUjB-0005xk-U5 for submit@debbugs.gnu.org; Mon, 03 Jun 2013 09:23:15 -0400 Received: from mail-bk0-f47.google.com ([209.85.214.47]:45086) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjUj5-0005wr-32 for 14517-done@debbugs.gnu.org; Mon, 03 Jun 2013 09:23:12 -0400 Received: by mail-bk0-f47.google.com with SMTP id jg9so1558421bkc.34 for <14517-done@debbugs.gnu.org>; Mon, 03 Jun 2013 06:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=4PKfFqFURlfHv4q05+7tcOqODjuxdyVbF/x+Sxk4oOY=; b=RkiMNSZn2RQ7hxxSHOYADN4PUMFsD/8FcL1ItGYdLflU/dVxfgm9ux8x6YXHQPGHpN nx3e1rjqSUgD7z2XEDSXKrWAjWUvd6wMryMUAJ6U+HhQyhZU1JmS2xaOr2upY/crnRwf mS2XaEODjBku4XyuoGmSekAe0MWDVMafb6ac9loRXLySIlUmjLmWZaVNVbiu2aJNsrzR hRl0GPkS1MIZ+A+S6PVMyEySa/26/k9QLiDJJl6ZXeBPz++MXHnGNG3O0mmE4kCWQyzv wQy60iMZMETDTWdskeKYAqxdFm1Cf/d/mGJTfrjqzjSF4cRsiMJ13FucuPhiL7irOaUn rEsA== X-Received: by 10.205.47.133 with SMTP id us5mr6585799bkb.110.1370265669104; Mon, 03 Jun 2013 06:21:09 -0700 (PDT) Received: from [192.168.178.20] (host93-95-dynamic.6-79-r.retail.telecomitalia.it. [79.6.95.93]) by mx.google.com with ESMTPSA id hh3sm7500789bkc.5.2013.06.03.06.21.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Jun 2013 06:21:08 -0700 (PDT) Message-ID: <51AC9840.9060302@gmail.com> Date: Mon, 03 Jun 2013 15:21:04 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Peter Rosin Subject: Re: bug#14517: t/tags-pr12372.sh assumes that etags generates tags for all files References: <51A86A3E.30104@lysator.liu.se> <51A86F26.6020209@gmail.com> <51A872DD.7090409@lysator.liu.se> <51A87456.8010209@gmail.com> <51A8751D.5050900@lysator.liu.se> <51AC662B.9010203@gmail.com> In-Reply-To: <51AC662B.9010203@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 14517-done Cc: 14517-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 06/03/2013 11:47 AM, Stefano Lattarini wrote: > > Peter Rosin wrote: >> >> Yup, I'm happy to test anything you come up with (within reason :-). >> > Here it is. Does it work for you? > > PATCH] tests: fix spurious failure when 'etags' program is Exuberant Ctags > > Fixes automake bug#14517. > > * t/tags-pr12372.sh: If the 'etags' program in use supports the > '--langmap' option, use it. That is required to avoid spurious > failures with Exuberant Ctags (at least version 5.8), which by > default do not generate any tags for file extensions it doesn't > recognize. > I've tried the patch with etags from both Exuberant Ctags and from Emacs, and everything works correctly. I'm thus closing this report. Peter, please holler if the problems somehow still persists for you, since I'm planning to release Automake 1.13.3 this evening or tomorrow morning. Thanks, and best regards, Stefano From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 09:46:22 2013 Received: (at 14517) by debbugs.gnu.org; 3 Jun 2013 13:46:22 +0000 Received: from localhost ([127.0.0.1]:48875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjV5Y-00076G-TV for submit@debbugs.gnu.org; Mon, 03 Jun 2013 09:46:22 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:40183) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjV5V-00075k-7J for 14517@debbugs.gnu.org; Mon, 03 Jun 2013 09:46:19 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 7FE9E4000B; Mon, 3 Jun 2013 15:44:23 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 5B64F40005; Mon, 3 Jun 2013 15:44:23 +0200 (CEST) Message-ID: <51AC9DB2.1070609@lysator.liu.se> Date: Mon, 03 Jun 2013 15:44:18 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: 14517@debbugs.gnu.org, stefano.lattarini@gmail.com Subject: Re: bug#14517: t/tags-pr12372.sh assumes that etags generates tags for all files References: <51A86A3E.30104@lysator.liu.se> <51A86F26.6020209@gmail.com> <51A872DD.7090409@lysator.liu.se> <51A87456.8010209@gmail.com> <51A8751D.5050900@lysator.liu.se> <51AC662B.9010203@gmail.com> <51AC9840.9060302@gmail.com> In-Reply-To: <51AC9840.9060302@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: 14517 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.4 (--) On 2013-06-03 15:21, Stefano Lattarini wrote: > On 06/03/2013 11:47 AM, Stefano Lattarini wrote: >> >> Peter Rosin wrote: >>> >>> Yup, I'm happy to test anything you come up with (within reason :-). >>> >> Here it is. Does it work for you? >> >> PATCH] tests: fix spurious failure when 'etags' program is Exuberant Ctags >> >> Fixes automake bug#14517. >> >> * t/tags-pr12372.sh: If the 'etags' program in use supports the >> '--langmap' option, use it. That is required to avoid spurious >> failures with Exuberant Ctags (at least version 5.8), which by >> default do not generate any tags for file extensions it doesn't >> recognize. >> > I've tried the patch with etags from both Exuberant Ctags and from > Emacs, and everything works correctly. I'm thus closing this report. > Peter, please holler if the problems somehow still persists for you, > since I'm planning to release Automake 1.13.3 this evening or > tomorrow morning. Hi Stefano! I was right in the middle of something, but since you're on a tight schedule, I took the time to check and it indeed fixes the problem here. Thanks! There is one little nitpick in the comment if you care: +# Exuberant Ctags (at least version 5.8) do not generate any tags ^^^^ s/ do / does / Cheers, Peter From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 10:24:14 2013 Received: (at 14517) by debbugs.gnu.org; 3 Jun 2013 14:24:14 +0000 Received: from localhost ([127.0.0.1]:49138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjVgA-00016i-Tj for submit@debbugs.gnu.org; Mon, 03 Jun 2013 10:24:14 -0400 Received: from mail-bk0-f52.google.com ([209.85.214.52]:44946) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UjVg6-000164-VU for 14517@debbugs.gnu.org; Mon, 03 Jun 2013 10:24:08 -0400 Received: by mail-bk0-f52.google.com with SMTP id e11so872740bkh.25 for <14517@debbugs.gnu.org>; Mon, 03 Jun 2013 07:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=W9kRS9xxvB4nbbkKTCoHDKIGtdaUE3rY6XBv9EhQrPk=; b=p+Ra7nvEeEL7/vP6oiTzzG474jY16w6J/mrAqVl/5Jjm1sBmMIP1qdSLuA0AGP2LZX NrnAThVLLV3X6pP87MnziQroC7gjEI7XrChR9QTqKQcgftjCYbffvnOntnvU82qrMnw1 vO/hJBROQb3/nqfREt1k8VM2pr/Cah7BtEUBTATv4kR+dJaNLKs1KGiYH8+dr6Fuf0lF EQ3ljG9AJ0/rl6og7hsqpAXSNpiCdQ3d+6p8nvtSQ6RO5qxAGHsWqhjfsT7vWL6fUAIo +WZbKt055ZGCF1RGW9g5zIQkDT1fw0wD0mu11IOikuaAVlQqBaiyAgPUKFwjSJbiCzyu bNug== X-Received: by 10.205.15.137 with SMTP id pu9mr5601675bkb.6.1370269328535; Mon, 03 Jun 2013 07:22:08 -0700 (PDT) Received: from [192.168.178.20] (host93-95-dynamic.6-79-r.retail.telecomitalia.it. [79.6.95.93]) by mx.google.com with ESMTPSA id iy11sm20363133bkb.11.2013.06.03.07.22.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Jun 2013 07:22:07 -0700 (PDT) Message-ID: <51ACA68D.6020804@gmail.com> Date: Mon, 03 Jun 2013 16:22:05 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Peter Rosin Subject: Re: bug#14517: t/tags-pr12372.sh assumes that etags generates tags for all files References: <51A86A3E.30104@lysator.liu.se> <51A86F26.6020209@gmail.com> <51A872DD.7090409@lysator.liu.se> <51A87456.8010209@gmail.com> <51A8751D.5050900@lysator.liu.se> <51AC662B.9010203@gmail.com> <51AC9840.9060302@gmail.com> <51AC9DB2.1070609@lysator.liu.se> In-Reply-To: <51AC9DB2.1070609@lysator.liu.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 14517 Cc: 14517@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 06/03/2013 03:44 PM, Peter Rosin wrote: > On 2013-06-03 15:21, Stefano Lattarini wrote: >> On 06/03/2013 11:47 AM, Stefano Lattarini wrote: >>> >>> Peter Rosin wrote: >>>> >>>> Yup, I'm happy to test anything you come up with (within reason :-). >>>> >>> Here it is. Does it work for you? >>> >>> PATCH] tests: fix spurious failure when 'etags' program is Exuberant Ctags >>> >>> Fixes automake bug#14517. >>> >>> * t/tags-pr12372.sh: If the 'etags' program in use supports the >>> '--langmap' option, use it. That is required to avoid spurious >>> failures with Exuberant Ctags (at least version 5.8), which by >>> default do not generate any tags for file extensions it doesn't >>> recognize. >>> >> I've tried the patch with etags from both Exuberant Ctags and from >> Emacs, and everything works correctly. I'm thus closing this report. >> Peter, please holler if the problems somehow still persists for you, >> since I'm planning to release Automake 1.13.3 this evening or >> tomorrow morning. > > Hi Stefano! > > I was right in the middle of something, but since you're on a tight > schedule, I took the time to check and it indeed fixes the problem > here. Thanks! > Thank you, this is really appreciated. > There is one little nitpick in the comment if you care: > > +# Exuberant Ctags (at least version 5.8) do not generate any tags > ^^^^ > s/ do / does / > Thanks, since I've already merged to maint I'll fix that up with a later commit in your name. Regards, Stefano From unknown Sun Aug 10 16:50:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Jul 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator