From unknown Sat Sep 06 02:32:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14501: dependency generation FAIL in t/subobj11a.sh Resent-From: Peter Rosin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 29 May 2013 07:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14501 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 14501@debbugs.gnu.org X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136981341714043 (code B ref -1); Wed, 29 May 2013 07:44:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2013 07:43:37 +0000 Received: from localhost ([127.0.0.1]:38808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uhb2m-0003eL-2L for submit@debbugs.gnu.org; Wed, 29 May 2013 03:43:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60950) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uhb2k-0003e8-Fi for submit@debbugs.gnu.org; Wed, 29 May 2013 03:43:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uhb1G-0007DG-0K for submit@debbugs.gnu.org; Wed, 29 May 2013 03:42:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.3 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:50659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhb1F-0007DC-Te for submit@debbugs.gnu.org; Wed, 29 May 2013 03:42:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhb1B-0004it-B0 for bug-automake@gnu.org; Wed, 29 May 2013 03:42:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uhb12-0007Av-Lb for bug-automake@gnu.org; Wed, 29 May 2013 03:41:57 -0400 Received: from mail.lysator.liu.se ([2001:6b0:17:f0a0::3]:44715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhb12-0007Ae-Ea for bug-automake@gnu.org; Wed, 29 May 2013 03:41:48 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 2229C40003 for ; Wed, 29 May 2013 09:41:46 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id F416A40002 for ; Wed, 29 May 2013 09:41:45 +0200 (CEST) Message-ID: <51A5B139.3060400@lysator.liu.se> Date: Wed, 29 May 2013 09:41:45 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Hi! On Automake master (baf8a1c22acce0908), t/subobj11a.sh fails on MSYS/MSVC (depmode=msvc7msys), like this: + make quux src/.deps/foo.Po:1: *** target pattern contains no `%'. Stop. It appears that the generated foo.Po is broken. Adding a cat "$depdir"/foo.Po just before the $MAKE quux invocation reveals that the originally generated foo.Po has this single line content: src/foo.obj : \ Notice the trailing backslash. When the testcase then adds a line of its own, the trailing backslash makes it blow up. Cheers, Peter From unknown Sat Sep 06 02:32:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14501: dependency generation FAIL in t/subobj11a.sh Resent-From: Peter Rosin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 29 May 2013 07:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14501 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 14501@debbugs.gnu.org Received: via spool by 14501-submit@debbugs.gnu.org id=B14501.136981378614814 (code B ref 14501); Wed, 29 May 2013 07:50:01 +0000 Received: (at 14501) by debbugs.gnu.org; 29 May 2013 07:49:46 +0000 Received: from localhost ([127.0.0.1]:38820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uhb8i-0003qp-VC for submit@debbugs.gnu.org; Wed, 29 May 2013 03:49:46 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:42762) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uhb8g-0003qi-LI for 14501@debbugs.gnu.org; Wed, 29 May 2013 03:49:43 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 1883440003 for <14501@debbugs.gnu.org>; Wed, 29 May 2013 09:48:19 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id F065940002 for <14501@debbugs.gnu.org>; Wed, 29 May 2013 09:48:18 +0200 (CEST) Message-ID: <51A5B2C2.7070008@lysator.liu.se> Date: Wed, 29 May 2013 09:48:18 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 References: <51A5B139.3060400@lysator.liu.se> In-Reply-To: <51A5B139.3060400@lysator.liu.se> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On 2013-05-29 09:41, Peter Rosin wrote: > Hi! > > On Automake master (baf8a1c22acce0908), t/subobj11a.sh fails > on MSYS/MSVC (depmode=msvc7msys), like this: > > + make quux > src/.deps/foo.Po:1: *** target pattern contains no `%'. Stop. > > > It appears that the generated foo.Po is broken. Adding a > cat "$depdir"/foo.Po > just before the $MAKE quux invocation reveals that the originally > generated foo.Po has this single line content: > > src/foo.obj : \ > > Notice the trailing backslash. When the testcase then adds a > line of its own, the trailing backslash makes it blow up. I forgot to mention that adding an empty line before the other added line, e.g. with echo >> "$depdir"/foo.Po works around the problem and makes the test pass. Cheers, Peter From unknown Sat Sep 06 02:32:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14501: dependency generation FAIL in t/subobj11a.sh Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 29 May 2013 09:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14501 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Peter Rosin Cc: 14501@debbugs.gnu.org Received: via spool by 14501-submit@debbugs.gnu.org id=B14501.136981949427322 (code B ref 14501); Wed, 29 May 2013 09:25:01 +0000 Received: (at 14501) by debbugs.gnu.org; 29 May 2013 09:24:54 +0000 Received: from localhost ([127.0.0.1]:38962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uhccm-00076b-Aj for submit@debbugs.gnu.org; Wed, 29 May 2013 05:24:54 -0400 Received: from mail-ee0-f45.google.com ([74.125.83.45]:59516) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uhcch-00076J-Tm for 14501@debbugs.gnu.org; Wed, 29 May 2013 05:24:49 -0400 Received: by mail-ee0-f45.google.com with SMTP id l10so5254358eei.4 for <14501@debbugs.gnu.org>; Wed, 29 May 2013 02:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=GDS+jxusbl0VSAb1pgQPyAVxBgqzjBTm9ERYvB2qeBY=; b=fDzdg+eq/y0qttKFYRSuvsjPyg/RZlfcmUGoI0L6WcIVvXYLqYZSfyhxkN6KWSAK9q 1dbffbVfRZ0tZ5bm9Gng02GjOj7mz42NxrbfT7u7XxwGDw+Ir+0tY+nAG4Dmrgz+IptU ni1FHm0c6TIGUwHw9kk4JZAnkSlYEuWznGGft23TmjE9DP54afI4haysAZ4n8VpbMAnw RZukmZa0ltGE20DOQlzo3prrJHm3ABik1pJ8InKVXkcFjOfO5ngCFJVnyt8UYRwPDYiR lfKNSWbLD3gu5hkMMpR4VXUwk70CdARi3Yt/OETH9f1Wz2Wvodu10fBRBlxSj66uTtZE NWdQ== X-Received: by 10.15.81.197 with SMTP id x45mr1657889eey.9.1369819399297; Wed, 29 May 2013 02:23:19 -0700 (PDT) Received: from [192.168.178.20] (host93-95-dynamic.6-79-r.retail.telecomitalia.it. [79.6.95.93]) by mx.google.com with ESMTPSA id f1sm24455765eem.17.2013.05.29.02.23.17 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 29 May 2013 02:23:18 -0700 (PDT) Message-ID: <51A5C904.10408@gmail.com> Date: Wed, 29 May 2013 11:23:16 +0200 From: Stefano Lattarini MIME-Version: 1.0 References: <51A5B139.3060400@lysator.liu.se> <51A5B2C2.7070008@lysator.liu.se> In-Reply-To: <51A5B2C2.7070008@lysator.liu.se> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 05/29/2013 09:48 AM, Peter Rosin wrote: > On 2013-05-29 09:41, Peter Rosin wrote: >> Hi! >> >> On Automake master (baf8a1c22acce0908), t/subobj11a.sh fails >> on MSYS/MSVC (depmode=msvc7msys), like this: >> >> + make quux >> src/.deps/foo.Po:1: *** target pattern contains no `%'. Stop. >> >> >> It appears that the generated foo.Po is broken. Adding a >> cat "$depdir"/foo.Po >> just before the $MAKE quux invocation reveals that the originally >> generated foo.Po has this single line content: >> >> src/foo.obj : \ >> >> Notice the trailing backslash. >> And I assume this, by itself, doesn't cause any problem to make, correct? >> When the testcase then adds a >> line of its own, the trailing backslash makes it blow up. > > I forgot to mention that adding an empty line before the other > added line, e.g. with > > echo >> "$depdir"/foo.Po > > works around the problem and makes the test pass. > I think we should go this way, yes. After all, albeit the trailing '\' in the .Po file looks strange, it's not causing any problem in practice, and it's only our hacky editing of said .Po that is triggering the failure. So let's fix this editing and live happy. Any patch that does so (and adds brief a comment explaining why we need the extra 'echo') can be considered pre-approved. Thanks, Stefano From unknown Sat Sep 06 02:32:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14501: dependency generation FAIL in t/subobj11a.sh Resent-From: Peter Rosin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 30 May 2013 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14501 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: "automake-patches@gnu.org" Cc: 14501@debbugs.gnu.org Received: via spool by 14501-submit@debbugs.gnu.org id=B14501.136989903026234 (code B ref 14501); Thu, 30 May 2013 07:31:02 +0000 Received: (at 14501) by debbugs.gnu.org; 30 May 2013 07:30:30 +0000 Received: from localhost ([127.0.0.1]:41512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhxJc-0006p3-Ni for submit@debbugs.gnu.org; Thu, 30 May 2013 03:30:29 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:42127) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhxJY-0006om-CD for 14501@debbugs.gnu.org; Thu, 30 May 2013 03:30:26 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 9A8304001A; Thu, 30 May 2013 09:28:54 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 31B1340002; Thu, 30 May 2013 09:28:54 +0200 (CEST) Message-ID: <51A6FFB5.2090203@lysator.liu.se> Date: Thu, 30 May 2013 09:28:53 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 References: <51A5B139.3060400@lysator.liu.se> <51A5B2C2.7070008@lysator.liu.se> <51A5C904.10408@gmail.com> In-Reply-To: <51A5C904.10408@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On 2013-05-29 11:23, Stefano Lattarini wrote: > On 05/29/2013 09:48 AM, Peter Rosin wrote: >> On 2013-05-29 09:41, Peter Rosin wrote: >>> Hi! >>> >>> On Automake master (baf8a1c22acce0908), t/subobj11a.sh fails >>> on MSYS/MSVC (depmode=msvc7msys), like this: >>> >>> + make quux >>> src/.deps/foo.Po:1: *** target pattern contains no `%'. Stop. >>> >>> >>> It appears that the generated foo.Po is broken. Adding a >>> cat "$depdir"/foo.Po >>> just before the $MAKE quux invocation reveals that the originally >>> generated foo.Po has this single line content: >>> >>> src/foo.obj : \ >>> >>> Notice the trailing backslash. >>> > And I assume this, by itself, doesn't cause any problem to make, > correct? Not that I have seen, no. But it feels fishy all the same. >>> When the testcase then adds a >>> line of its own, the trailing backslash makes it blow up. >> >> I forgot to mention that adding an empty line before the other >> added line, e.g. with >> >> echo >> "$depdir"/foo.Po >> >> works around the problem and makes the test pass. >> > I think we should go this way, yes. After all, albeit the trailing > '\' in the .Po file looks strange, it's not causing any problem in > practice, and it's only our hacky editing of said .Po that is > triggering the failure. So let's fix this editing and live happy. > > Any patch that does so (and adds brief a comment explaining why we > need the extra 'echo') can be considered pre-approved. So, I think the below is a better fix. Ok for micro? Cheers, Peter >From 2131bd330a167d37274ee9b179d3885e090d0839 Mon Sep 17 00:00:00 2001 From: Peter Rosin Date: Thu, 30 May 2013 09:26:45 +0200 Subject: [PATCH] depcomp: make sure the depfile ends nicely for depmode=msvc7 When compiling a file without any dependencies (no #includes), the msvc7 depmode (and consequently msvc7msys) generates a depfile Makefile fragment with the last line ending with a backslash. This is less robust than needed. Fixes automake bug#14501. * lib/depcomp (msvc7): Finish off the depfile Makefile fragment with an empty line. (scriptversion): Update. Signed-off-by: Peter Rosin --- lib/depcomp | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/depcomp b/lib/depcomp index 06b0882..4ebd5b3 100755 --- a/lib/depcomp +++ b/lib/depcomp @@ -1,7 +1,7 @@ #! /bin/sh # depcomp - compile a program generating dependencies as side-effects -scriptversion=2012-10-18.11; # UTC +scriptversion=2013-05-30.07; # UTC # Copyright (C) 1999-2013 Free Software Foundation, Inc. @@ -552,6 +552,7 @@ $ { G p }' >> "$depfile" + echo >> "$depfile" # make sure the fragment doesn't end with a backslash rm -f "$tmpdepfile" ;; -- 1.7.9 From unknown Sat Sep 06 02:32:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14501: dependency generation FAIL in t/subobj11a.sh Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 30 May 2013 08:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14501 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Peter Rosin Cc: 14501@debbugs.gnu.org, "automake-patches@gnu.org" Received: via spool by 14501-submit@debbugs.gnu.org id=B14501.13699035786267 (code B ref 14501); Thu, 30 May 2013 08:47:02 +0000 Received: (at 14501) by debbugs.gnu.org; 30 May 2013 08:46:18 +0000 Received: from localhost ([127.0.0.1]:41584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhyUz-0001cz-HU for submit@debbugs.gnu.org; Thu, 30 May 2013 04:46:18 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:64650) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhyUw-0001cd-C3 for 14501@debbugs.gnu.org; Thu, 30 May 2013 04:46:15 -0400 Received: by mail-bk0-f46.google.com with SMTP id na10so31632bkb.19 for <14501@debbugs.gnu.org>; Thu, 30 May 2013 01:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=NRJGhYSaJZc5BR5YcXIMKq3CQjcFMK5ZlqLGYslKN0w=; b=vSoWYg9RudYCSLfBQTK1GSOZytjr6jUveVzOh/MzaswtawEYp4vzKYwOEaoXX2COAF rTIuLb9P02Ou11Emk+xFoGNBO59kpgFtWCJstGGsS597CkcmS3MToSjkHVy+XaUkztqg dAkPGN6/o2ou7UnwbfU/UMk/Lk/E7wGvZJXq+LQIqr9XUcUHptpdu0CabA64iy4+UdOi kmiKWb3dDgtZvYmXzQUfh7m4xz2iEsYMaPGhoN+jJGpZqIHmgXLkY/RPe04aZgNIyXbg 7Mr9FmTxi8OK9w/g7PprxGGcen8YTevfpWnbBnr+92xKAkrRoLITxjV4izfEbPdVtUFW mwLQ== X-Received: by 10.205.45.130 with SMTP id uk2mr1504441bkb.68.1369903479932; Thu, 30 May 2013 01:44:39 -0700 (PDT) Received: from [192.168.178.20] (host93-95-dynamic.6-79-r.retail.telecomitalia.it. [79.6.95.93]) by mx.google.com with ESMTPSA id jy7sm4848228bkb.6.2013.05.30.01.44.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 30 May 2013 01:44:39 -0700 (PDT) Message-ID: <51A7116D.9070802@gmail.com> Date: Thu, 30 May 2013 10:44:29 +0200 From: Stefano Lattarini MIME-Version: 1.0 References: <51A5B139.3060400@lysator.liu.se> <51A5B2C2.7070008@lysator.liu.se> <51A5C904.10408@gmail.com> <51A6FFB5.2090203@lysator.liu.se> In-Reply-To: <51A6FFB5.2090203@lysator.liu.se> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 05/30/2013 09:28 AM, Peter Rosin wrote: > On 2013-05-29 11:23, Stefano Lattarini wrote: >> On 05/29/2013 09:48 AM, Peter Rosin wrote: >>> On 2013-05-29 09:41, Peter Rosin wrote: >>>> Hi! >>>> >>>> On Automake master (baf8a1c22acce0908), t/subobj11a.sh fails >>>> on MSYS/MSVC (depmode=msvc7msys), like this: >>>> >>>> + make quux >>>> src/.deps/foo.Po:1: *** target pattern contains no `%'. Stop. >>>> >>>> >>>> It appears that the generated foo.Po is broken. Adding a >>>> cat "$depdir"/foo.Po >>>> just before the $MAKE quux invocation reveals that the originally >>>> generated foo.Po has this single line content: >>>> >>>> src/foo.obj : \ >>>> >>>> Notice the trailing backslash. >>>> >> And I assume this, by itself, doesn't cause any problem to make, >> correct? > > Not that I have seen, no. But it feels fishy all the same. > >>>> When the testcase then adds a >>>> line of its own, the trailing backslash makes it blow up. >>> >>> I forgot to mention that adding an empty line before the other >>> added line, e.g. with >>> >>> echo >> "$depdir"/foo.Po >>> >>> works around the problem and makes the test pass. >>> >> I think we should go this way, yes. After all, albeit the trailing >> '\' in the .Po file looks strange, it's not causing any problem in >> practice, and it's only our hacky editing of said .Po that is >> triggering the failure. So let's fix this editing and live happy. >> >> Any patch that does so (and adds brief a comment explaining why we >> need the extra 'echo') can be considered pre-approved. > > So, I think the below is a better fix. Ok for micro? > > Cheers, > Peter > > > > From 2131bd330a167d37274ee9b179d3885e090d0839 Mon Sep 17 00:00:00 2001 > From: Peter Rosin > Date: Thu, 30 May 2013 09:26:45 +0200 > Subject: [PATCH] depcomp: make sure the depfile ends nicely for depmode=msvc7 > Or even "depcmp: avoid trailing backslash in depfile for depmode=msvc7", maybe? > When compiling a file without any dependencies (no #includes), the > msvc7 depmode (and consequently msvc7msys) generates a depfile > Makefile fragment with the last line ending with a backslash. This > is less robust than needed. > > Fixes automake bug#14501. > > * lib/depcomp (msvc7): Finish off the depfile Makefile fragment with > an empty line. > (scriptversion): Update. > > Signed-off-by: Peter Rosin > --- > lib/depcomp | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/lib/depcomp b/lib/depcomp > index 06b0882..4ebd5b3 100755 > --- a/lib/depcomp > +++ b/lib/depcomp > @@ -1,7 +1,7 @@ > #! /bin/sh > # depcomp - compile a program generating dependencies as side-effects > > -scriptversion=2012-10-18.11; # UTC > +scriptversion=2013-05-30.07; # UTC > > # Copyright (C) 1999-2013 Free Software Foundation, Inc. > > @@ -552,6 +552,7 @@ $ { > G > p > }' >> "$depfile" > + echo >> "$depfile" # make sure the fragment doesn't end with a backslash > rm -f "$tmpdepfile" > ;; > ACK, with either your original subject line or with the one I suggested (as you prefer). Thanks, Stefano From unknown Sat Sep 06 02:32:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14501: dependency generation FAIL in t/subobj11a.sh Resent-From: Peter Rosin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 30 May 2013 08:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14501 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Stefano Lattarini Cc: 14501@debbugs.gnu.org, "automake-patches@gnu.org" Received: via spool by 14501-submit@debbugs.gnu.org id=B14501.13699040547652 (code B ref 14501); Thu, 30 May 2013 08:55:02 +0000 Received: (at 14501) by debbugs.gnu.org; 30 May 2013 08:54:14 +0000 Received: from localhost ([127.0.0.1]:41593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uhycf-0001zN-Ve for submit@debbugs.gnu.org; Thu, 30 May 2013 04:54:14 -0400 Received: from mail.lysator.liu.se ([130.236.254.3]:34654) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uhycd-0001zA-TJ for 14501@debbugs.gnu.org; Thu, 30 May 2013 04:54:12 -0400 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id DBAA14001A; Thu, 30 May 2013 10:52:41 +0200 (CEST) Received: from [192.168.0.64] (90-227-119-137-no95.business.telia.com [90.227.119.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 9954A40002; Thu, 30 May 2013 10:52:41 +0200 (CEST) Message-ID: <51A71358.9070804@lysator.liu.se> Date: Thu, 30 May 2013 10:52:40 +0200 From: Peter Rosin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 References: <51A5B139.3060400@lysator.liu.se> <51A5B2C2.7070008@lysator.liu.se> <51A5C904.10408@gmail.com> <51A6FFB5.2090203@lysator.liu.se> <51A7116D.9070802@gmail.com> In-Reply-To: <51A7116D.9070802@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On 2013-05-30 10:44, Stefano Lattarini wrote: > Or even "depcmp: avoid trailing backslash in depfile for depmode=msvc7", > maybe? Pushed with your subject. Thanks! Cheers, Peter From debbugs-submit-bounces@debbugs.gnu.org Thu May 30 17:07:30 2013 Received: (at control) by debbugs.gnu.org; 30 May 2013 21:07:30 +0000 Received: from localhost ([127.0.0.1]:43001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiA4H-0000e9-8c for submit@debbugs.gnu.org; Thu, 30 May 2013 17:07:30 -0400 Received: from mail-ea0-f171.google.com ([209.85.215.171]:39714) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiA4F-0000dq-1Q for control@debbugs.gnu.org; Thu, 30 May 2013 17:07:27 -0400 Received: by mail-ea0-f171.google.com with SMTP id b15so847132eae.16 for ; Thu, 30 May 2013 14:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:subject:content-type :content-transfer-encoding; bh=RGutHN14lFeSP99QBDFaamO/9CDWbpGJPiOIra0kr+4=; b=kSEe0wK68e7oevRvyg2MXjmAFU7FCjLOOUaxVoqr4yUeNYleUKfVetq7YzU3xGc30S BFwzH9f2cu9jXjJqcFX0+RnwTeQEAIuYdYdUranGR8LZ615xbRYPMO/lY9L1I/BIBOTu LIonzWRnykrBK70nT4wJ36CWSRzRRR2XMZwKcsWmmsm5BEEM6eguqwT9LZAhTqcNhIPi oXOeQsQJpbV8lLC9sHpszT+b4fDMZ8EQZnILSXHo6p+mTLeym4T+FMu6i1pfU776KbcI duhNPAaDNkkRAoAS6xMm4SAor9Km+A3WRjQtE3cb7C6z/slYUrvlyJG02bIfTiiliWjm 24Xg== X-Received: by 10.15.52.133 with SMTP id p5mr11208783eew.55.1369947950091; Thu, 30 May 2013 14:05:50 -0700 (PDT) Received: from [192.168.178.20] (host93-95-dynamic.6-79-r.retail.telecomitalia.it. [79.6.95.93]) by mx.google.com with ESMTPSA id t6sm26656662eev.14.2013.05.30.14.05.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 30 May 2013 14:05:48 -0700 (PDT) Message-ID: <51A7BF23.5060809@gmail.com> Date: Thu, 30 May 2013 23:05:39 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: GNU bug tracker automated control server Subject: x Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 14500 + patch severity 14500 minor close 14500 tags 14499 + patch severity 14499 minor close 14499 tags 14498 + patch severity 14498 minor close 14498 tags 14495 + patch severity 14495 minor close 14495 tags 14494 + patch severity 14494 minor close 14494 tags 14501 + patch severity 14501 minor close 14501 stop