GNU bug report logs - #14498
Failure with MSVC in t/yacc-bison-skeleton.sh

Previous Next

Package: automake;

Reported by: Peter Rosin <peda <at> lysator.liu.se>

Date: Wed, 29 May 2013 05:51:02 UTC

Severity: minor

Tags: patch

Done: Stefano Lattarini <stefano.lattarini <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #17 received at 14498 <at> debbugs.gnu.org (full text, mbox):

From: Peter Rosin <peda <at> lysator.liu.se>
To: "automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Cc: 14498 <at> debbugs.gnu.org
Subject: Re: bug#14498: Failure with MSVC in t/yacc-bison-skeleton.sh
Date: Wed, 29 May 2013 12:10:12 +0200
On 2013-05-29 11:56, Stefano Lattarini wrote:
> On 05/29/2013 11:54 AM, Peter Rosin wrote:
>> diff --git a/t/yacc-bison-skeleton.sh b/t/yacc-bison-skeleton.sh
>> index b89d44c..3dfc83f 100644
>> --- a/t/yacc-bison-skeleton.sh
>> +++ b/t/yacc-bison-skeleton.sh
>> @@ -22,6 +22,7 @@ required='cc bison'
>>
>>  cat >> configure.ac << 'END'
>>  AC_PROG_CC
>> +AC_C_INLINE
>>  AC_PROG_YACC
>>  AC_OUTPUT
>>  END
>>
> ACK.  Extra points if you add an explicative comment, like:
> 
>   AC_C_INLINE  dnl Required by MSVC.

Pushing this:

From d817a68e133f5bf41e1b5926d64ece7bc43ca8c3 Mon Sep 17 00:00:00 2001
From: Peter Rosin <peda <at> lysator.liu.se>
Date: Wed, 29 May 2013 12:06:17 +0200
Subject: [PATCH 2/2] tests: avoid a spurious failure with MSVC

Fixes automake bug#14498.

* t/yacc-bison-skeleton.sh: inline was not standardized prior to C99.

Signed-off-by: Peter Rosin <peda <at> lysator.liu.se>
---
 t/yacc-bison-skeleton.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/t/yacc-bison-skeleton.sh b/t/yacc-bison-skeleton.sh
index b89d44c..4553f7e 100644
--- a/t/yacc-bison-skeleton.sh
+++ b/t/yacc-bison-skeleton.sh
@@ -22,6 +22,7 @@ required='cc bison'
 
 cat >> configure.ac << 'END'
 AC_PROG_CC
+AC_C_INLINE    dnl Required by some pre-C99 compilers such as MSVC.
 AC_PROG_YACC
 AC_OUTPUT
 END
-- 
1.7.9






This bug report was last modified 12 years and 54 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.