Subject: Re: bug#14498: Failure with MSVC in t/yacc-bison-skeleton.sh

From: Stefano Lattarini <[email-masked]>
Date: Wed, 29 May 2013 11:56:48 +0200

On 05/29/2013 11:54 AM, Peter Rosin wrote:
> On 2013-05-29 07:48, Peter Rosin wrote:
>> Hi!
>>
>> With the master branch (baf8a1c22acce0908) bison generates code with
>> a bunch of inline functions, but inline is spelled __inline with
>> MSVC, and the test fails spectacularly.
>>
>> An example error message:
>> zardoz.c(873) : error C2054: expected '(' to follow 'inline'
>>
>> $ bison --version
>> bison (GNU Bison) 2.4.2
>> Written by Robert Corbett and Richard Stallman.
>> ...
> 
> The below change makes the test pass for me. Ok to push such a change?
> 
> Cheers,
> Peter
> 
> diff --git a/t/yacc-bison-skeleton.sh b/t/yacc-bison-skeleton.sh
> index b89d44c..3dfc83f 100644
> --- a/t/yacc-bison-skeleton.sh
> +++ b/t/yacc-bison-skeleton.sh
> @@ -22,6 +22,7 @@ required='cc bison'
> 
>  cat >> configure.ac << 'END'
>  AC_PROG_CC
> +AC_C_INLINE
>  AC_PROG_YACC
>  AC_OUTPUT
>  END
> 
ACK.  Extra points if you add an explicative comment, like:

  AC_C_INLINE  dnl Required by MSVC.

Thanks,
  Stefano