GNU bug report logs - #14493
MSYS line ending problem in t/cxx-demo.sh

Previous Next

Full log

View this message in rfc822 format

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: automake-patches <at> gnu.org
Cc: Peter Rosin <peda <at> lysator.liu.se>, 14493 <at> debbugs.gnu.org
Subject: bug#14493: [FYI] {micro} tests: slightly stricter checks in t/cxx-demo.sh
Date: Mon,  3 Jun 2013 12:02:12 +0200

This is a follow-up to the commit fixing automake bug#14493.

* t/cxx-demo.sh: Also check that the built program returns the
correct (i.e., zero) exit status when run.  And improve comments
a little while at it.

Signed-off-by: Stefano Lattarini <stefano.lattarini <at> gmail.com>
---
 t/cxx-demo.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/t/cxx-demo.sh b/t/cxx-demo.sh
index f872c43..97a46ce 100644
--- a/t/cxx-demo.sh
+++ b/t/cxx-demo.sh
@@ -165,7 +165,11 @@ END
     Good morning, work.
 END
   for p in play work; do
-    # Strip CR characters catering to MinGW programs on MSYS.
+    # The program must run correctly (exit status = 0).
+    ./$p
+    # And it must have the expected output.  Note that we strip extra
+    # CR characters (if any), to cater to MinGW programs on MSYS.
+    # See automake bug#14493.
     ./$p | tr -d '\015' > got.$p || { cat got.$p; exit 1; }
     cat exp.$p
     cat got.$p
-- 
1.8.3.rc3.8.g5e49f30

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.