GNU bug report logs - #14484
24.3.50; doc of `after-find-file'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14484 in the body.
You can then email your comments to 14484 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; doc of `after-find-file'
Date: Mon, 27 May 2013 08:11:45 -0700 (PDT)

1. The parameter is named _AFTER-FIND-FILE-FROM-REVERT-BUFFER, not
AFTER-FIND-FILE-FROM-REVERT-BUFFER.

2. This makes no sense:
"(see `revert-buffer-in-progress-p' for similar functionality)."

Similar functionality to what?  The parameter is _ignored_!

Seems like this doc string got incompletely updated when the function
got modified to ignore this parameter.  Just a guess - incomprehensible
as it stands.

3. And since _AFTER-FIND-FILE-FROM-REVERT-BUFFER is ignored, why
does `recover-file' continue to make a point of using it?  Why doesn't
it just use `(after-find-file)'?  Again, it seems like someone made an
incomplete change to the code, neglecting to clean up here and there.

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-05-24 on LEG570
Bzr revision: 112715 yamaoka <at> jpl.org-20130524143612-v96chr0e5istvj82
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr --enable-checking CFLAGS='-O0 -g3'
 CPPFLAGS='-DGLYPH_DEBUG=1 -I/c/usr/include''

Message #8 received at 14484 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 14484 <at> debbugs.gnu.org
Subject: Re: bug#14484: 24.3.50; doc of `after-find-file'
Date: Fri, 29 Apr 2016 01:39:11 +0200

Drew Adams <drew.adams <at> oracle.com> writes:

> 1. The parameter is named _AFTER-FIND-FILE-FROM-REVERT-BUFFER, not
> AFTER-FIND-FILE-FROM-REVERT-BUFFER.

This is how `C-h f' on that starts:

after-find-file is a compiled Lisp function in ‘files.el’.

(after-find-file &optional ERROR WARN NOAUTO
AFTER-FIND-FILE-FROM-REVERT-BUFFER NOMODES)

So it's consistent, even if the arg is "really" _'d.

> 2. This makes no sense:
> "(see `revert-buffer-in-progress-p' for similar functionality)."
>
> Similar functionality to what?  The parameter is _ignored_!

I think it means "if this is what you used to use, use this similar
thing instead".  Seems clear to me.

> 3. And since _AFTER-FIND-FILE-FROM-REVERT-BUFFER is ignored, why
> does `recover-file' continue to make a point of using it?  Why doesn't
> it just use `(after-find-file)'?  Again, it seems like someone made an
> incomplete change to the code, neglecting to clean up here and there.

It calls

(after-find-file nil nil t)

so if it did, it's been fixed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.