GNU bug report logs - #14480
[PATCH] A few error to user-error replacements

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14480 in the body.
You can then email your comments to 14480 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kelly Dean <kellydeanch <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] A few error to user-error replacements
Date: Sun, 26 May 2013 18:26:05 -0700 (PDT)

[Message part 1 (text/plain, inline)]

I put (setq debug-on-error t) in my init.el recently and started hitting some of these.
Patch attached.
There are over 8000 occurrences "(error" in emacs-24.3/lisp and subdirs, probably a lot that should be replaced; should we report them every time we hit new ones or maybe queue for a few months to avoid spamming the bug db?

[user-error.patch (text/x-diff, attachment)]

Message #8 received at 14480 <at> debbugs.gnu.org (full text, mbox):

From: Kelly Dean <kellydeanch <at> yahoo.com>
To: 14480 <at> debbugs.gnu.org
Subject: [PATCH2] Re: bug#14480: A few error to user-error replacements
Date: Mon, 3 Jun 2013 17:35:31 -0700 (PDT)

[Message part 1 (text/plain, inline)]

Here are some more. Additional patch attached.

[user-error2.patch (text/x-diff, attachment)]

Message #11 received at 14480 <at> debbugs.gnu.org (full text, mbox):

From: Kelly Dean <kellydeanch <at> yahoo.com>
To: 14480 <at> debbugs.gnu.org
Subject: [PATCH3] Re: bug#14480: A few error to user-error replacements
Date: Tue, 11 Jun 2013 17:52:36 -0700 (PDT)

[Message part 1 (text/plain, inline)]

Here's another one:
(setq debug-on-error t)
M-x M-x
It enters debugger.
Also:
M-x C-x o M-x
It enters debugger.

The attached patch fixes it in both cases. It also applies to trunk; just ignore the hunk for undo.c (user_error is already deleted from undo.c in trunk, but the hunk is needed for 24.3 to prevent a compiler error).

Also, in primitive-undo in simple.el in trunk, the 4 occurrences of
(error "Changes to be undone are outside visible portion of buffer")
might be a regression; primitive-undo in undo.c in 24.3 uses user_error in all 4 cases. But I haven't checked to make sure; maybe they really are program errors, not user errors.

Also, between 24.3 and trunk, bitch_at_user in dispnew.c changed from using the error function to manually signalling a user error. It should just use user_error, which does the same thing.

[user-error3.patch (text/x-diff, attachment)]

Message #14 received at 14480 <at> debbugs.gnu.org (full text, mbox):

From: Kelly Dean <kellydeanch <at> yahoo.com>
To: 14480 <at> debbugs.gnu.org
Subject: Re: bug#14480: A few error to user-error replacements
Date: Wed, 12 Jun 2013 06:49:47 -0700 (PDT)

A couple more: in emacs-24.3/lisp/emacs-lisp/lisp.el, the calls to error on lines 187 and 618 should be calls to user-error. Can't say current line numbers in trunk, since they'll probably change by the time somebody reads this, and can't provide context via diff since the FSF requested that I not send any more patches
(see http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14492).

Reporting these minor things in prose seems not worth the effort. Should users even be reporting them? Or is some computer-assisted error->user-error bulk conversion going to take place, and reporting individual ones is unnecessary?

Message #21 received at 14480-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 14480-done <at> debbugs.gnu.org
Subject: Re: bug#14480: [PATCH] A few error to user-error replacements
Date: Thu, 27 Feb 2014 21:34:35 -0500

Thanks for the user-error patches, but as you know we can't use them
without a copyright assignment. Since we are aware that it is desirable
to replace error by user-eror where applicable, I don't think it is
necessary to keep this bug report open.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.