From unknown Fri Jun 20 07:11:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14479 <14479@debbugs.gnu.org> To: bug#14479 <14479@debbugs.gnu.org> Subject: Status: [PATCH] Infinite loop when error in auto-save-hook Reply-To: bug#14479 <14479@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:45 +0000 retitle 14479 [PATCH] Infinite loop when error in auto-save-hook reassign 14479 emacs submitter 14479 Kelly Dean severity 14479 normal tag 14479 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun May 26 21:23:02 2013 Received: (at submit) by debbugs.gnu.org; 27 May 2013 01:23:02 +0000 Received: from localhost ([127.0.0.1]:35895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ugm9N-0005M8-Hc for submit@debbugs.gnu.org; Sun, 26 May 2013 21:23:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43625) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ugm9L-0005LR-0n for submit@debbugs.gnu.org; Sun, 26 May 2013 21:23:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ugm84-0000KG-Rc for submit@debbugs.gnu.org; Sun, 26 May 2013 21:21:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_XBL,RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugm84-0000KC-PH for submit@debbugs.gnu.org; Sun, 26 May 2013 21:21:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugm81-00032F-8y for bug-gnu-emacs@gnu.org; Sun, 26 May 2013 21:21:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ugm7y-0000IT-NY for bug-gnu-emacs@gnu.org; Sun, 26 May 2013 21:21:37 -0400 Received: from nm40-vm4.bullet.mail.bf1.yahoo.com ([72.30.239.212]:30577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugm7y-0000IN-GM for bug-gnu-emacs@gnu.org; Sun, 26 May 2013 21:21:34 -0400 Received: from [98.139.215.142] by nm40.bullet.mail.bf1.yahoo.com with NNFMP; 27 May 2013 01:21:33 -0000 Received: from [98.139.212.221] by tm13.bullet.mail.bf1.yahoo.com with NNFMP; 27 May 2013 01:21:33 -0000 Received: from [127.0.0.1] by omp1030.mail.bf1.yahoo.com with NNFMP; 27 May 2013 01:21:33 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 349387.15780.bm@omp1030.mail.bf1.yahoo.com Received: (qmail 29029 invoked by uid 60001); 27 May 2013 01:21:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1369617693; bh=LwLs05Gfmhg6LIuvqx4ZL2ECInqHt4L72ErC7WbV4V0=; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:MIME-Version:Content-Type; b=gxfIBcEYnX2b/VlitCGn+fkJHYe4zcTf9ly/D7eCiYMXGXzgmnrMt4be4wbSOeJ/0J1zDUfc7HuNfZpCreTRjV7Byd0mnWbltzPC678nwsaZjbelcnYGayGYDYVnQNz/YyMnHdwZzkjlVOw77EKEpYgjB+h/MoMBlt6mIRvr5Sg= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Rocket-MIMEInfo:X-Mailer:Message-ID:Date:From:Subject:To:MIME-Version:Content-Type; b=n4JYRhNkWx4A7OklF/cwID8cBNh5xjSvOevLjhIkRFItuPVFp8kVIIk8emdjFqwOz0zk7/r+9+943URToTjrFOt4YjllSr7JTRSvZvToD8gFDSuGPyAuys4RNdzhXFf4VbLaEJk4/2adjvNqjjiiTF66mBFvdPtcXBL4J3Swd1I=; X-YMail-OSG: qKV3wXcVM1lVaMLVJdwqmakPnW_2O0u_FsdLeR2Y5gIdB5D _o0ph495XIB7oLk3EXbmj2Qo292y3FXQ5eDPwnV6FJggBMx4Z0VNm_ES_qvC kO29PebWpqA4lExugn6QwbrlZtgvjNJsnATg13ByErPaJSfOohzbcGXNLd1u u_dt5_Wlz7O_VoJ2XP42qW2kcjYB6ABj6xDrIKvlT3Nr446Nu4LpgK1Im37U bBBqfudiVjRiV4cTOXPwA38P6qTwJYehPoWgZg.da7.jDY9vBeI3LRI8LlA2 teEXbP_Tvtcrt06eUsrMQ1JngdKTnDttaD3aLTc0ikLBFTC6oTiLLTSHaTgV s2tdJpWn0A92MS33CWfkJNeKkhiYGggytDtpEfkq2a7Gq4ZfKgbBMJK8R5w6 PwPV.vdHDJzdXdi9.8gTcg4m1GdsrFnuifZkgN6C1K_VrraiAOSs0N03btau ZZ0toLmD2nPs- Received: from [213.130.246.228] by web141101.mail.bf1.yahoo.com via HTTP; Sun, 26 May 2013 18:21:32 PDT X-Rocket-MIMEInfo: 002.001, UHV0IGluIGluaXQuZWw6CihzZXRxIGluaGliaXQtc3RhcnR1cC1zY3JlZW4gdCkKKGFkZC1ob29rICdhdXRvLXNhdmUtaG9vayAobGFtYmRhICgpIChlcnJvciAiRm9vIikpKQooc2V0cSBhdXRvLXNhdmUtaW50ZXJ2YWwgMzApCihzd2l0Y2gtdG8tYnVmZmVyICIqTWVzc2FnZXMqIikKClN0YXJ0IEVtYWNzIDI0LjMsIHRoZW4gcHJlc3MgYW55IGtleSAzMSB0aW1lcy4gSXQgcHJpbnRzICJGb28iIGFuZCBiZWdpbnMgYmVuY2htYXJraW5nIGFuIGF1dG9zYXZlIHJldHJ5IGxvb3AsIG9uIG15IHN5c3RlbSBhYm8BMAEBAQE- X-Mailer: YahooMailClassic/15.1.8 YahooMailWebService/0.8.144.546 Message-ID: <1369617692.28825.YahooMailClassic@web141101.mail.bf1.yahoo.com> Date: Sun, 26 May 2013 18:21:32 -0700 (PDT) From: Kelly Dean Subject: [PATCH] Infinite loop when error in auto-save-hook To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Put in init.el: (setq inhibit-startup-screen t) (add-hook 'auto-save-hook (lambda () (error "Foo"))) (setq auto-save-interval 30) (switch-to-buffer "*Messages*") Start Emacs 24.3, then press any key 31 times. It prints "Foo" and begins benchmarking an autosave retry loop, on my system about 300 retries/second, because Fdo_auto_save fails when it tries to run auto-save-hook, so it never gets to record_auto_save which updates last_auto_save, which is what's supposed to prevent the retries via keyboard.c line 2608. The patch below fixes it. Unlike the case for post-command-hook, removing the offending auto-save hook isn't vital, but I think it's the best thing to do. Anyway, continuing the autosave despite the error is vital, and safe_run_hooks is the easiest way to accomplish both. --- emacs-24.3/src/fileio.c +++ emacs-24.3/src/fileio.c @@ -5445,7 +5445,7 @@ point to non-strings reached from Vbuffer_alist. */ hook = intern ("auto-save-hook"); - Frun_hooks (1, &hook); + safe_run_hooks (hook); if (STRINGP (Vauto_save_list_file_name)) { From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 13 01:13:40 2013 Received: (at 14479-done) by debbugs.gnu.org; 13 Jun 2013 05:13:40 +0000 Received: from localhost ([127.0.0.1]:40467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Umzqt-0002M7-Fx for submit@debbugs.gnu.org; Thu, 13 Jun 2013 01:13:39 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59194 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Umzqq-0002Ly-Nd for 14479-done@debbugs.gnu.org; Thu, 13 Jun 2013 01:13:36 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Umzqq-0002Ep-95; Thu, 13 Jun 2013 01:13:36 -0400 From: Glenn Morris To: 14479-done@debbugs.gnu.org Subject: Re: bug#14479: [PATCH] Infinite loop when error in auto-save-hook References: <1369617692.28825.YahooMailClassic@web141101.mail.bf1.yahoo.com> X-Spook: diwn Jiang Zemin doctrine Ermes Compsec Soviet UOP X-Ran: `e(7{CY#]sXMd8xB{CaREFfeMJSE1=zcg{`)C&vOEJr2N./@xAj`x9Q5coOZQG[W$/D{W- X-Hue: black X-Attribution: GM Date: Thu, 13 Jun 2013 01:13:36 -0400 In-Reply-To: <1369617692.28825.YahooMailClassic@web141101.mail.bf1.yahoo.com> (Kelly Dean's message of "Sun, 26 May 2013 18:21:32 -0700 (PDT)") Message-ID: <6imwqu4mpr.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: 14479-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) Version: 24.4 Thanks; applied. From unknown Fri Jun 20 07:11:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 Jul 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator