GNU bug report logs - #14477
[PATCH] tests: numfmt: use the printf program, not the shell builtin

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#14477: closed ([PATCH] tests: numfmt: use the printf program,
 not the shell builtin)
Date: Sun, 26 May 2013 23:21:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 27 May 2013 00:18:46 +0100
with message-id <51A29856.5010709 <at> draigBrady.com>
and subject line Re: bug#14477: [PATCH] tests: numfmt: use the printf program, not the shell builtin
has caused the debbugs.gnu.org bug report #14477,
regarding [PATCH] tests: numfmt: use the printf program, not the shell builtin
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
14477: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14477
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: bug-coreutils <at> gnu.org
Cc: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Subject: [PATCH] tests: numfmt: use the printf program, not the shell builtin
Date: Mon, 27 May 2013 00:06:00 +0200

* tests/misc/numfmt.pl: Here.  This avoids a spurious failure when
/bin/sh is dash (as can happen on Debian systems).
---
 tests/misc/numfmt.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/misc/numfmt.pl b/tests/misc/numfmt.pl
index 61917fb..553f68b 100644
--- a/tests/misc/numfmt.pl
+++ b/tests/misc/numfmt.pl
@@ -887,7 +887,7 @@ if ($locale ne 'C')
   {
     # Reset locale to 'C' if LOCALE_FR_UTF8 doesn't output as expected
     # as determined by the separate printf program.
-    open(LOC_NUM, "LC_ALL=$locale printf \"%'d\" 1234|")
+    open(LOC_NUM, "env LC_ALL=$locale printf \"%'d\" 1234|")
       or die "Can't fork command: $!";
     my $loc_num = <LOC_NUM>;
     close(LOC_NUM) || die "Failed to read grouped number from printf";
-- 
1.8.3.rc3.8.g5e49f30

[Message part 3 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 14477-done <at> debbugs.gnu.org
Subject: Re: bug#14477: [PATCH] tests: numfmt: use the printf program, not
	the shell builtin
Date: Mon, 27 May 2013 00:18:46 +0100

On 05/26/2013 11:06 PM, Stefano Lattarini wrote:
> * tests/misc/numfmt.pl: Here.  This avoids a spurious failure when
> /bin/sh is dash (as can happen on Debian systems).
> ---
>  tests/misc/numfmt.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/misc/numfmt.pl b/tests/misc/numfmt.pl
> index 61917fb..553f68b 100644
> --- a/tests/misc/numfmt.pl
> +++ b/tests/misc/numfmt.pl
> @@ -887,7 +887,7 @@ if ($locale ne 'C')
>    {
>      # Reset locale to 'C' if LOCALE_FR_UTF8 doesn't output as expected
>      # as determined by the separate printf program.
> -    open(LOC_NUM, "LC_ALL=$locale printf \"%'d\" 1234|")
> +    open(LOC_NUM, "env LC_ALL=$locale printf \"%'d\" 1234|")
>        or die "Can't fork command: $!";
>      my $loc_num = <LOC_NUM>;
>      close(LOC_NUM) || die "Failed to read grouped number from printf";
> 

Applied.

thanks,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.